April 2013 - openlmi-devel - Fedora Mailing-Lists

Review Request 209: Add TimerManager: [6/6] Set default log level to INFO.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/209/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Set default log level to INFO. This patch does not really belong to the patchset, I just fixed it when I was testing logging. DEBUG is too verbose. On the other hand, we'll see no logging until something sets more verbose level, e.g. after configuration load. Diffs ----- src/python/openlmi/common/cmpi_logging.py c8755f5cdcdcd8474d695bc0838fe448890572d0 Diff: http://reviewboard-openlmi.rhcloud.com/r/209/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
2
0 / 0

Review Request 208: Add TimerManager: [5/6] Use UTC times for all wall clock times.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/208/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Use UTC times for all wall clock times. clocktime_of_last_state_change was in local time. Diffs ----- src/python/openlmi/common/JobManager.py bb6fed806de5c2e47d67d3261159a33625bfadce Diff: http://reviewboard-openlmi.rhcloud.com/r/208/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
2
0 / 0

Review Request 207: Add TimerManager: [4/6] Remove whitespaces.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/207/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Remove whitespaces. Diffs ----- src/python/openlmi/common/JobManager.py bb6fed806de5c2e47d67d3261159a33625bfadce Diff: http://reviewboard-openlmi.rhcloud.com/r/207/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
2
0 / 0

Review Request 206: Add TimerManager: [3/6] Use monotonic clock for job expiration.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/206/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Use monotonic clock for job expiration. Job expiration timer should not be influenced by admin changing date or time. Diffs ----- src/python/openlmi/common/JobManager.py bb6fed806de5c2e47d67d3261159a33625bfadce Diff: http://reviewboard-openlmi.rhcloud.com/r/206/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
2
0 / 0

Review Request 204: Add TimerManager: [1/6] Add TimerManager.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/204/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Add TimerManager. Standard Python threading.Timer starts separate thread for each timer. That has two unpleseant consequences: - We end up with lot of sleeping threads. - If we want to use logging in thread callbacks, we must register the thread at CIMOM using AttachThread (=tedious). So let's create TimerManager - Uses only on thread. - It is possible to log stuff in timer callbacks. Diffs ----- src/python/openlmi/common/TimerManager.py PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/204/diff/ Testing ------- Thanks, Jan Safranek

11 years, 1 month

1
2
0 / 0

Review Request 148: openlmi-networking [1/3] Rework setting creation

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/148/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-networking Description ------- Rework setting creation methods Methods CreateStaticSetting, CreateDHCPSetting and CreateSlaveSetting was renamed to CreateOrModifyStaticSetting, CreateOrModifyDynamicSetting and CreateOrModifySlaveSetting. All of them now can be used to modify existing setting when SettingData input argument is supplied. CreateOrModifyStaticSetting now supports multiple IP addresses, netmasks/prefixes and gateways -- it's more aligned with ExtendedStaticIPAssignmentSettingData class. Diffs ----- mof/LMI_Networking.mof fb9580105931ba03d1895279d9af561a0e5c5b46 src/LMI_IPAssignmentSettingDataProvider.c c3b632c49378233432945cbb8bd3f215425b96ae src/LMI_IPConfigurationServiceProvider.c 14af9e65aa0948955a551ac1edce1f5262a28588 src/connection.h 668460a76d97e0195e53804c29f631b095df2782 src/connection.c 7678cab5785e6b95edef103dbf3a3fa5f0612efd src/connection_nm.c a0b92223c0bc1a18a29d7bf3342cf5423c835c7f src/setting.h 514e7f0469085e73d3293a060752a0193816d9fd src/setting.c 25fa7cbad6e8d52359d0142c7210fa8e6a9d5d71 test/test_apply_connection.py 887cf7825a316ffc437eae650cb55afff02c7b0d test/test_create_destroy_connection.py b278d6acfbb509a8398926f3d6106a92adbe1dcc test/test_enable_disable_iface.py 792d3ade8a854ecea38b70ac7d73e157f59f0e53 test/test_modify_connection.py PRE-CREATION Diff: http://reviewboard-openlmi.rhcloud.com/r/148/diff/ Testing ------- Thanks, Radek Novacek

11 years, 1 month

1
2
0 / 0

Please add me to mailing list

by Danny Brennan

Sent from my iPad

11 years, 1 month

2
1
0 / 0

Review Request 233: Typo in LMI_StorageConfigurationService.py

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/233/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Typo in LMI_StorageConfigurationService.py Diffs ----- src/openlmi/storage/LMI_StorageConfigurationService.py 8ea10fbff155d627873c71bd09890a1bb1bb5341 Diff: http://reviewboard-openlmi.rhcloud.com/r/233/diff/ Testing ------- Thanks, Jan Synacek

11 years, 1 month

1
2
0 / 0

Review Request 231: openlmi-providers: Fix path to configured openlmi.pc file

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/231/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Fix path to configured openlmi.pc file Diffs ----- src/CMakeLists.txt d5335a6e10a7947a4a2bebd7c02f4296eefa98a3 Diff: http://reviewboard-openlmi.rhcloud.com/r/231/diff/ Testing ------- Thanks, Radek Novacek

11 years, 1 month

1
2
0 / 0

Review Request 230: [1/1] Replace eval() with ast.literal_eval().

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/230/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Replace eval() with ast.literal_eval(). This can be used for safely evaluating strings containing Python expressions from untrusted sources without the need to parse the values oneself. Diffs ----- src/openlmi/storage/SettingProvider.py 2aafb2c14b756814b64665ec325920bd47289326 Diff: http://reviewboard-openlmi.rhcloud.com/r/230/diff/ Testing ------- Thanks, Jan Synacek

11 years, 1 month

1
2
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

openlmi-devel April 2013