September 2013 - openlmi-devel - Fedora Mailing-Lists

Re: Review Request 859: [1/1] logicalfile: ignore some key properties

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/859/#review1177 ----------------------------------------------------------- Ship it! Ship It! - Michal Minar On Sept. 13, 2013, 11:31 a.m., Jan Synacek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard-openlmi.rhcloud.com/r/859/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 11:31 a.m.) > > > Review request for OpenLMI Developers. > > > Repository: openlmi-providers > > > Description > ------- > > logicalfile: ignore some key properties > > CIM_LogicalFile and CIM_UnixFile have some key properties that are not > needed when calling GetInstance(). On Linux systems, all is needed to > get information about a file is its path. Type of the filesystem that > the file resides on and the file type itself are not needed. In fact, > it's not desirable to require those when querying remote systems. > > Ignore FSCreationClassName, FSName, LFCreationClassName and > CreationClassName. > > This commit reverts most of the functionality of commit > 5c3e1a6203e495bec37acd8c3731ca41377beb94. > > > Diffs > ----- > > src/logicalfile/LMI_DirectoryContainsFileProvider.c 753cb00d184a71bbaa3a3d63883110480750d8d9 > src/logicalfile/LMI_FileIdentityProvider.c 7ada7873c0b90f88bcbf5b3ba1a44aa704c713e4 > src/logicalfile/LMI_RootDirectoryProvider.c 2be709f0d0a0ca50271508dffe67bbfc357cc710 > src/logicalfile/LMI_UnixFileProvider.c 5da5bb0a471228653fabc30c5a7793c526ebaff3 > src/logicalfile/file.h b7ecb53cf43ee2f290c5bbdf091165c81b86ac2d > src/logicalfile/file.c ca0d9f4e88d1b4b78ee7104eb88f676ab30535af > src/logicalfile/test/test_basic.py fbcf6d57829d35e134cfdedab9501043fd3c372a > > Diff: http://reviewboard-openlmi.rhcloud.com/r/859/diff/ > > > Testing > ------- > > > Thanks, > > Jan Synacek > > _______________________________________________ openlmi-reviews mailing list openlmi-reviews(a)lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

10 years, 7 months

1
0
0 / 0

openlmi-reviews Digest, Vol 5, Issue 12

by openlmi-reviews-request＠lists.fedorahosted.org

Send openlmi-reviews mailing list submissions to openlmi-reviews(a)lists.fedorahosted.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews or, via email, send a message with subject or body 'help' to openlmi-reviews-request(a)lists.fedorahosted.org You can reach the person managing the list at openlmi-reviews-owner(a)lists.fedorahosted.org When replying, please edit your Subject line so it is more specific than "Re: Contents of openlmi-reviews digest..." Today's Topics: 1. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 2. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 3. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) _______________________________________________ openlmi-reviews mailing list openlmi-reviews(a)lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

10 years, 7 months

1
0
0 / 0

openlmi-reviews Digest, Vol 5, Issue 11

by openlmi-reviews-request＠lists.fedorahosted.org

Send openlmi-reviews mailing list submissions to openlmi-reviews(a)lists.fedorahosted.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews or, via email, send a message with subject or body 'help' to openlmi-reviews-request(a)lists.fedorahosted.org You can reach the person managing the list at openlmi-reviews-owner(a)lists.fedorahosted.org When replying, please edit your Subject line so it is more specific than "Re: Contents of openlmi-reviews digest..." Today's Topics: 1. Review Request 855: openlmi-python [1/1] logging improvements and fix (Michal Minar) 2. Review Request 856: software [1/1] software: fixed critical section problem (Michal Minar) 3. Review Request 857: [1/2] logicalfile: warn if udev context creation fails (Jan Synacek) 4. Review Request 858: [2/2] logicalfile: ignore some key properties (Jan Synacek) 5. Re: Review Request 856: software [1/1] software: fixed critical section problem (Jan Synacek) 6. Re: Review Request 858: [2/2] logicalfile: ignore some key properties (Jan Synacek) 7. Re: Review Request 855: openlmi-python [1/1] logging improvements and fix (Jan Safranek) 8. Re: Review Request 857: [1/2] logicalfile: warn if udev context creation fails (Jan Safranek) 9. Re: Review Request 857: [1/2] logicalfile: warn if udev context creation fails (Jan Synacek) 10. Re: Review Request 856: software [1/1] software: fixed critical section problem (Michal Minar) 11. Re: Review Request 855: openlmi-python [1/1] logging improvements and fix (Michal Minar) 12. Review Request 859: [1/1] logicalfile: ignore some key properties (Jan Synacek) 13. Re: Review Request 859: [1/1] logicalfile: ignore some key properties (Jan Synacek) 14. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 15. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 16. Re: Review Request 859: [1/1] logicalfile: ignore some key properties (Michal Minar) 17. Re: Review Request 859: [1/1] logicalfile: ignore some key properties (Jan Synacek) 18. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 19. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 20. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 21. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 22. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 23. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 24. Re: Review Request 859: [1/1] logicalfile: ignore some key properties (Jan Synacek) _______________________________________________ openlmi-reviews mailing list openlmi-reviews(a)lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

10 years, 7 months

1
0
0 / 0

openlmi-reviews Digest, Vol 5, Issue 10

by openlmi-reviews-request＠lists.fedorahosted.org

Send openlmi-reviews mailing list submissions to openlmi-reviews(a)lists.fedorahosted.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews or, via email, send a message with subject or body 'help' to openlmi-reviews-request(a)lists.fedorahosted.org You can reach the person managing the list at openlmi-reviews-owner(a)lists.fedorahosted.org When replying, please edit your Subject line so it is more specific than "Re: Contents of openlmi-reviews digest..." Today's Topics: 1. Re: Review Request 847: journald: Add iterator tests (=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=) 2. Re: Review Request 847: journald: Add iterator tests (=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=) 3. Review Request 851: [1/1] Service: Propagate error messages, check for invalid (NULL) service names (Vitezslav Crhonek) 4. Review Request 852: journald: Update tests to match modified message format (=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=) 5. Re: Review Request 847: journald: Add iterator tests (Michal Minar) 6. Re: Review Request 852: journald: Update tests to match modified message format (Michal Minar) 7. Review Request 853: [1/1] Account: Better check of pool initialization failure. (Robin Hack) 8. Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) 9. Re: Review Request 840: [1/1] Account: First upstream account test from qa. (Robin Hack) 10. Re: Review Request 854: [1/1] Account: Added QA test for account provider. (Robin Hack) _______________________________________________ openlmi-reviews mailing list openlmi-reviews(a)lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

10 years, 7 months

1
0
0 / 0

openlmi-scripts docs available

by Michal Minář

I'm happy to announce the availability of openlmi-scripts documentation on Python Hosted: http://pythonhosted.org/openlmi-scripts/index.html Its source is written in reStructuredText markup language and is located in our git repository: https://github.com/openlmi/openlmi-scripts/tree/master/doc Feel free to comment on it and improve it if you find any mistakes. Also our openlmi-tools and openlmi-scripts are now available on Python Package Index (PyPI) which makes them easier to install and try out: https://pypi.python.org/pypi?%3Aaction=search&term=openlmi&submit=search

10 years, 7 months

1
0
0 / 0

openlmi-reviews Digest, Vol 5, Issue 9

by openlmi-reviews-request＠lists.fedorahosted.org

Send openlmi-reviews mailing list submissions to openlmi-reviews(a)lists.fedorahosted.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews or, via email, send a message with subject or body 'help' to openlmi-reviews-request(a)lists.fedorahosted.org You can reach the person managing the list at openlmi-reviews-owner(a)lists.fedorahosted.org When replying, please edit your Subject line so it is more specific than "Re: Contents of openlmi-reviews digest..." Today's Topics: 1. Re: Review Request 842: [1/1] Account: Added associative thread locking. (Jan Safranek) 2. Re: Review Request 842: [1/1] Account: Added associative thread locking. (Jan Safranek) 3. Re: Review Request 842: [1/1] Account: Added associative thread locking. (Robin Hack) 4. Re: Review Request 842: [1/1] Account: Added associative thread locking. (Robin Hack) 5. Re: Review Request 842: [1/1] Account: Added associative thread locking. (Jan Safranek) 6. Re: Review Request 824: python(PyPI)-registration) [1/1] python: added license to setup and corrected classifiers (Michal Minar) 7. Re: Review Request 823: software(fixes) [2/2] software: fixed updating of package done by async method (Michal Minar) 8. Re: Review Request 822: software(fixes) [1/2] fix issues when creating instance for broken repository (Michal Minar) 9. Re: Review Request 816: software(fix) [1/1] fixed getting information about verification job (Michal Minar) 10. Re: Review Request 844: service-provider [1/1] Service: Fix detection of service state (Vitezslav Crhonek) 11. Re: Review Request 842: [5/5] Account: Account: Added associative thread locking. (Robin Hack) 12. Re: Review Request 842: [5/5] Account: Added associative thread locking. (Robin Hack) 13. Re: Review Request 842: [5/5] Account: Added associative thread locking. (Robin Hack) 14. Review Request 846: [1/1] Account: Added associative thread locking. (Robin Hack) 15. Re: Review Request 846: [1/1] Account: Added associative thread locking. (Robin Hack) 16. Re: Review Request 846: [1/1] Account: Added associative thread locking. (Roman Rakus) 17. Re: Review Request 846: [1/1] Account: Added associative thread locking. (Radek Novacek) 18. Re: Review Request 842: [5/5] Account: Added associative thread locking. (Jan Safranek) 19. Re: Review Request 846: [1/1] Account: Added associative thread locking. (Jan Safranek) 20. Review Request 847: journald: Add iterator tests (=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=) 21. Review Request 848: lmishell, unify method call arguments with instance filtering (Peter Hatina) 22. Review Request 849: Hardware: Move PCI bus initialization to the Initialize() function (Peter Schiffer) 23. Re: Review Request 848: lmishell, unify method call arguments with instance filtering (Michal Minar) 24. Re: Review Request 848: lmishell, unify method call arguments with instance filtering (Michal Minar) 25. Re: Review Request 849: Hardware: Move PCI bus initialization to the Initialize() function (Michal Minar) 26. Re: Review Request 847: journald: Add iterator tests (Michal Minar) 27. Re: Review Request 847: journald: Add iterator tests (Michal Minar) 28. Review Request 850: [1/1] Account: Removed unused macro undefinitions. (Robin Hack) 29. Re: Review Request 846: [1/1] Account: Added associative thread locking. (Robin Hack) 30. Re: Review Request 850: [1/1] Account: Removed unused macro undefinitions. (Jan Safranek) 31. Re: Review Request 850: [1/1] Account: Removed unused macro undefinitions. (Robin Hack) 32. Re: Review Request 846: [1/1] Account: Added associative thread locking. (Robin Hack) _______________________________________________ openlmi-reviews mailing list openlmi-reviews(a)lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

10 years, 7 months

1
0
0 / 0

openlmi-reviews Digest, Vol 5, Issue 8

by openlmi-reviews-request＠lists.fedorahosted.org

Send openlmi-reviews mailing list submissions to openlmi-reviews(a)lists.fedorahosted.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews or, via email, send a message with subject or body 'help' to openlmi-reviews-request(a)lists.fedorahosted.org You can reach the person managing the list at openlmi-reviews-owner(a)lists.fedorahosted.org When replying, please edit your Subject line so it is more specific than "Re: Contents of openlmi-reviews digest..." Today's Topics: 1. Re: Review Request 830: completion [1/1] Completion: bash completion for lmi shell (Roman Rakus) 2. Re: Review Request 837: journald: Add support for iterators (=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=) 3. Re: Review Request 837: journald: Add support for iterators (=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=) 4. Review Request 839: Hardware: Added PCI_Bridge provider (Peter Schiffer) 5. Re: Review Request 795: [1/1] Account: Added associative thread locking. (Robin Hack) 6. Re: Review Request 795: [3/3] Account: Added associative thread locking. (Robin Hack) 7. Review Request 840: [1/1] Account: First upstream account test from qa. (Robin Hack) 8. Re: Review Request 795: [2/2] Account: Added associative thread locking. (Robin Hack) 9. Re: Review Request 795: [3/3] Account: Added associative thread locking. (Robin Hack) 10. Re: Review Request 795: [3/3] Account: Added associative thread locking. (Robin Hack) 11. Re: Review Request 840: [1/1] Account: First upstream account test from qa. (Jan Synacek) 12. Review Request 841: openlmi-providers [1/1] test: Add path to service-dbus tests to nosetest.cfg (Radek Novacek) 13. Re: Review Request 840: [1/1] Account: First upstream account test from qa. (Robin Hack) 14. Re: Review Request 795: [3/3] Account: Added associative thread locking. (Robin Hack) 15. Review Request 842: [1/1] Account: Added associative thread locking. (Robin Hack) 16. Re: Review Request 842: [1/1] Account: Added associative thread locking. (Robin Hack) 17. Re: Review Request 840: [1/1] Account: First upstream account test from qa. (Radek Novacek) 18. Re: Review Request 842: [1/1] Account: Added associative thread locking. (Robin Hack) 19. Re: Review Request 840: [1/1] Account: First upstream account test from qa. (Robin Hack) 20. Re: Review Request 840: [1/1] Account: First upstream account test from qa. (Robin Hack) 21. Re: Review Request 840: [1/1] Account: First upstream account test from qa. (Robin Hack) 22. Review Request 843: openlmi-networking [1/1] Fix nonfunctional CQL syntax in IndicationFilters (Radek Novacek) 23. Re: Review Request 843: openlmi-networking [1/1] Fix nonfunctional CQL syntax in IndicationFilters (Michal Minar) 24. Re: Review Request 841: openlmi-providers [1/1] test: Add path to service-dbus tests to nosetest.cfg (Michal Minar) 25. Re: Review Request 843: openlmi-networking [1/1] Fix nonfunctional CQL syntax in IndicationFilters (Radek Novacek) 26. Re: Review Request 841: openlmi-providers [1/1] test: Add path to service-dbus tests to nosetest.cfg (Radek Novacek) 27. Review Request 844: service-provider [1/1] Service: Fix detection of service state (Vitezslav Crhonek) 28. Re: Review Request 430: openlmi-locale [1/1] New provider: Locale (Vitezslav Crhonek) 29. Re: Review Request 824: python(PyPI)-registration) [1/1] python: added license to setup and corrected classifiers (Jan Safranek) 30. Review Request 845: [1/1] Software: First upstream test for software provider from QA. (Robin Hack) 31. Re: Review Request 845: [1/1] Software: First upstream test for software provider from QA. (Robin Hack) 32. Re: Review Request 845: [1/1] Software: First upstream test for software provider from QA. (Robin Hack) 33. Re: Review Request 839: Hardware: Added PCI_Bridge provider (Jan Safranek) 34. Re: Review Request 845: [1/1] Software: First upstream test for software provider from QA. (Michal Minar) 35. Re: Review Request 844: service-provider [1/1] Service: Fix detection of service state (Radek Novacek) _______________________________________________ openlmi-reviews mailing list openlmi-reviews(a)lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

10 years, 7 months

1
0
0 / 0

openlmi-reviews Digest, Vol 5, Issue 7

by openlmi-reviews-request＠lists.fedorahosted.org

Send openlmi-reviews mailing list submissions to openlmi-reviews(a)lists.fedorahosted.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews or, via email, send a message with subject or body 'help' to openlmi-reviews-request(a)lists.fedorahosted.org You can reach the person managing the list at openlmi-reviews-owner(a)lists.fedorahosted.org When replying, please edit your Subject line so it is more specific than "Re: Contents of openlmi-reviews digest..." Today's Topics: 1. Re: Review Request 836: openlmi-mof-register.py: database listing support (Jan Synacek) 2. Re: Review Request 832: [2/4] logicalfile: use lstat(2) instead of stat(2) (Michal Minar) 3. Re: Review Request 833: [3/4] logicalfile: protect libselinux calls with a mutex (Michal Minar) 4. Re: Review Request 831: [1/4] add libselinux-devel to dependencies in README (Michal Minar) 5. Re: Review Request 834: [4/4] logicalfile: correctly return an objectpath (Michal Minar) 6. Re: Review Request 836: openlmi-mof-register.py: database listing support (Michal Minar) 7. Re: Review Request 830: completion [1/1] Completion: bash completion for lmi shell (Michal Minar) 8. Re: Review Request 833: [3/4] logicalfile: protect libselinux calls with a mutex (Jan Synacek) 9. Re: Review Request 833: [3/4] logicalfile: protect libselinux calls with a mutex (Michal Minar) 10. Re: Review Request 833: [3/4] logicalfile: protect libselinux calls with a mutex (Radek Novacek) 11. Re: Review Request 833: [3/4] logicalfile: protect libselinux calls with a mutex (Jan Synacek) 12. Re: Review Request 832: [2/4] logicalfile: use lstat(2) instead of stat(2) (Jan Synacek) 13. Re: Review Request 831: [1/4] add libselinux-devel to dependencies in README (Jan Synacek) 14. Re: Review Request 834: [4/4] logicalfile: correctly return an objectpath (Jan Synacek) 15. Re: Review Request 830: completion [1/1] Completion: bash completion for lmi shell (Roman Rakus) 16. Re: Review Request 795: [1/1] Account: Added associative thread locking. (Robin Hack) 17. Re: Review Request 795: [1/1] Account: Added associative thread locking. (Roman Rakus) 18. Review Request 838: openlmi-networking [1/1] C functions need to mark no argurments as void (Radek Novacek) 19. Re: Review Request 830: completion [1/1] Completion: bash completion for lmi shell (Jan Synacek) 20. Re: Review Request 838: openlmi-networking [1/1] C functions need to mark no argurments as void (Jan Synacek) 21. Re: Review Request 838: openlmi-networking [1/1] C functions need to mark no argurments as void (Radek Novacek) 22. Re: Review Request 830: completion [1/1] Completion: bash completion for lmi shell (Roman Rakus) 23. Re: Review Request 830: completion [1/1] Completion: bash completion for lmi shell (Roman Rakus) 24. Re: Review Request 795: [1/1] Account: Added associative thread locking. (Robin Hack) 25. Re: Review Request 830: completion [1/1] Completion: bash completion for lmi shell (Michal Minar) _______________________________________________ openlmi-reviews mailing list openlmi-reviews(a)lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

10 years, 7 months

1
0
0 / 0

openlmi-reviews Digest, Vol 5, Issue 6

by openlmi-reviews-request＠lists.fedorahosted.org

Send openlmi-reviews mailing list submissions to openlmi-reviews(a)lists.fedorahosted.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews or, via email, send a message with subject or body 'help' to openlmi-reviews-request(a)lists.fedorahosted.org You can reach the person managing the list at openlmi-reviews-owner(a)lists.fedorahosted.org When replying, please edit your Subject line so it is more specific than "Re: Contents of openlmi-reviews digest..." Today's Topics: 1. Re: Review Request 830: completion [1/1] Completion: bash completion for lmi shell (Roman Rakus) 2. Review Request 831: [1/4] add libselinux-devel to dependencies in README (Jan Synacek) 3. Review Request 832: [2/4] logicalfile: use lstat(2) instead of stat(2) (Jan Synacek) 4. Review Request 834: [4/4] logicalfile: correctly return an objectpath (Jan Synacek) 5. Review Request 833: [3/4] logicalfile: protect libselinux calls with a mutex (Jan Synacek) 6. Review Request 836: openlmi-mof-register.py: database listing support (Tomas Smetana) 7. Review Request 837: journald: Add support for iterators (=?utf-8?b?VG9tw6HFoSBCxb5hdGVr?=) 8. Re: Review Request 837: journald: Add support for iterators (Roman Rakus) _______________________________________________ openlmi-reviews mailing list openlmi-reviews(a)lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews

10 years, 7 months

1
0
0 / 0

LogicalFile provider usability

by Jan Synacek

All LogicalFile classes as well as LMI_UnixFile require information about the filesystem (its CreationClassName and UUID/partition name) and the type of the file (is it a directory/symlink/blockdevice/...?) to be known before it's possible to call GetInstance() on them. Now on the client side, if I want show information about a file, I only want to specify its path, nothing else. And that's a problem, because I usually have no idea what the file's type and the partition it lies on is, that's why I want to ask the provider in the first place. Currently, the provider checks for all those key properties and returns an error if they are not present, or they are incorrect. So, on the client side, I have to provide information that I don't know, and on the server side, it requires those pieces of information, otherwise an error is raised. Which leads me to a few questions. 1) What is the purpose of FSCreationClassName, FSName and LFCreationClassName in the LMI_UnixFile class? If my understanding is correct, in the linux environment, it should be safe to ignore those, because it is impossible for any two files on the filesystem to have different paths and actually be the same file (following symlinks doesn't count here). In other words, file's path should be enough to unambiguously identify that file. Please, correct me if I'm wrong. 2) Is there a way how to find out what the aforementioned key properties are? As for the solution, I'm for simply ignoring FSCreationClassName, FSName and LFCreationClassName in the provider. Comments appreciated. Cheers, -- Jan Synacek Software Engineer, Red Hat

10 years, 7 months

3
6
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

openlmi-devel September 2013