Review Request 94: Unused devices: [2/5] Added a function to check for unused devices.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/94/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Added a function to check for unused devices.


Diffs
-----

  src/openlmi/storage/util/storage.py fa966fcd947d1cd04d19f157a66251a3fa84c6fa 

Diff: http://reviewboard-openlmi.rhcloud.com/r/94/diff/


Testing
-------


Thanks,

Jan Safranek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/94/#review101
-----------------------------------------------------------



src/openlmi/storage/util/storage.py
<http://reviewboard-openlmi.rhcloud.com/r/94/#comment59>

    is used by `child' and not `children'


- Roman Rakus


On April 4, 2013, 4:33 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/94/
>  -----------------------------------------------------------
>  
>  (Updated April 4, 2013, 4:33 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Added a function to check for unused devices.
>  
>  
>  Diffs
>  -----
>  
>    src/openlmi/storage/util/storage.py fa966fcd947d1cd04d19f157a66251a3fa84c6fa 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/94/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

>  On April 5, 2013, 2 p.m., Roman Rakus wrote:
>  > src/openlmi/storage/util/storage.py, line 258
>  > <http://reviewboard-openlmi.rhcloud.com/r/94/diff/1/?file=493#file493line2...
>  >
>  >     is used by `child' and not `children' 
I've fixed this, I won't post new set just because this one-liner.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/94/#review101
-----------------------------------------------------------


On April 4, 2013, 6:33 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/94/
>  -----------------------------------------------------------
>  
>  (Updated April 4, 2013, 6:33 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Added a function to check for unused devices.
>  
>  
>  Diffs
>  -----
>  
>    src/openlmi/storage/util/storage.py fa966fcd947d1cd04d19f157a66251a3fa84c6fa 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/94/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/94/
-----------------------------------------------------------

(Updated April 8, 2013, 1:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Added a function to check for unused devices.


Diffs
-----

  src/openlmi/storage/util/storage.py fa966fcd947d1cd04d19f157a66251a3fa84c6fa 

Diff: http://reviewboard-openlmi.rhcloud.com/r/94/diff/


Testing
-------


Thanks,

Jan Safranek