Review Request 95: Unused devices: [3/5] Added checks to overwrite only unused devices.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/95/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Added checks to overwrite only unused devices.


Diffs
-----

  src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py
195a66e6cdc8f98e054aa3d6e7efb2306d721871 
  src/openlmi/storage/LMI_FileSystemConfigurationService.py
f8b76551652443e1c53e3b592a52a3c0bb740494 
  src/openlmi/storage/LMI_StorageConfigurationService.py
0abd5099b6ebb707abf95bbc6bdbc64951f3128a 

Diff: http://reviewboard-openlmi.rhcloud.com/r/95/diff/


Testing
-------


Thanks,

Jan Safranek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/95/#review102
-----------------------------------------------------------

Ship it!


Ship It!

- Roman Rakus


On April 4, 2013, 4:33 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/95/
>  -----------------------------------------------------------
>  
>  (Updated April 4, 2013, 4:33 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Added checks to overwrite only unused devices.
>  
>  
>  Diffs
>  -----
>  
>    src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py
> 195a66e6cdc8f98e054aa3d6e7efb2306d721871 
>    src/openlmi/storage/LMI_FileSystemConfigurationService.py
> f8b76551652443e1c53e3b592a52a3c0bb740494 
>    src/openlmi/storage/LMI_StorageConfigurationService.py
> 0abd5099b6ebb707abf95bbc6bdbc64951f3128a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/95/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/95/#review105
-----------------------------------------------------------



src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py
<http://reviewboard-openlmi.rhcloud.com/r/95/#comment60>

    I think it would be much more readable to have comment like "Raise CIMError if
device is used". Now it's not clear what will happen without looking at
check_unused implementation.


- Radek Novacek


On April 4, 2013, 6:33 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/95/
>  -----------------------------------------------------------
>  
>  (Updated April 4, 2013, 6:33 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Added checks to overwrite only unused devices.
>  
>  
>  Diffs
>  -----
>  
>    src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py
> 195a66e6cdc8f98e054aa3d6e7efb2306d721871 
>    src/openlmi/storage/LMI_FileSystemConfigurationService.py
> f8b76551652443e1c53e3b592a52a3c0bb740494 
>    src/openlmi/storage/LMI_StorageConfigurationService.py
> 0abd5099b6ebb707abf95bbc6bdbc64951f3128a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/95/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

>  On April 5, 2013, 3:23 p.m., Radek Novacek wrote:
>  > src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py, line 81
>  > <http://reviewboard-openlmi.rhcloud.com/r/95/diff/1/?file=494#file494line8...
>  >
>  >     I think it would be much more readable to have comment like "Raise CIMError
> if device is used". Now it's not clear what will happen without looking at
> check_unused implementation. 
I'll rename the 'check_unused' method to 'assert_unused' to make it
clear what happens.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/95/#review105
-----------------------------------------------------------


On April 4, 2013, 6:33 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/95/
>  -----------------------------------------------------------
>  
>  (Updated April 4, 2013, 6:33 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Added checks to overwrite only unused devices.
>  
>  
>  Diffs
>  -----
>  
>    src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py
> 195a66e6cdc8f98e054aa3d6e7efb2306d721871 
>    src/openlmi/storage/LMI_FileSystemConfigurationService.py
> f8b76551652443e1c53e3b592a52a3c0bb740494 
>    src/openlmi/storage/LMI_StorageConfigurationService.py
> 0abd5099b6ebb707abf95bbc6bdbc64951f3128a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/95/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/95/#review106
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On April 4, 2013, 6:33 p.m., Jan Safranek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/95/
>  -----------------------------------------------------------
>  
>  (Updated April 4, 2013, 6:33 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Added checks to overwrite only unused devices.
>  
>  
>  Diffs
>  -----
>  
>    src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py
> 195a66e6cdc8f98e054aa3d6e7efb2306d721871 
>    src/openlmi/storage/LMI_FileSystemConfigurationService.py
> f8b76551652443e1c53e3b592a52a3c0bb740494 
>    src/openlmi/storage/LMI_StorageConfigurationService.py
> 0abd5099b6ebb707abf95bbc6bdbc64951f3128a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/95/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Safranek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/95/
-----------------------------------------------------------

(Updated April 8, 2013, 1:10 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Added checks to overwrite only unused devices.


Diffs
-----

  src/openlmi/storage/LMI_DiskPartitioningConfigurationService.py
195a66e6cdc8f98e054aa3d6e7efb2306d721871 
  src/openlmi/storage/LMI_FileSystemConfigurationService.py
f8b76551652443e1c53e3b592a52a3c0bb740494 
  src/openlmi/storage/LMI_StorageConfigurationService.py
0abd5099b6ebb707abf95bbc6bdbc64951f3128a 

Diff: http://reviewboard-openlmi.rhcloud.com/r/95/diff/


Testing
-------


Thanks,

Jan Safranek