----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Add LMI_MountedFileSystem and LMI_HostedMount.
Diffs -----
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_HostedMount.py PRE-CREATION src/openlmi/storage/LMI_MountedFileSystem.py PRE-CREATION src/openlmi/storage/MountingProvider.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/130/diff/
Testing -------
Thanks,
Jan Synacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/ -----------------------------------------------------------
(Updated April 8, 2013, 3:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Add LMI_MountedFileSystem and LMI_HostedMount.
Diffs -----
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_HostedMount.py PRE-CREATION src/openlmi/storage/LMI_MountedFileSystem.py PRE-CREATION src/openlmi/storage/MountingProvider.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/130/diff/
Testing -------
Thanks,
Jan Synacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/#review135 -----------------------------------------------------------
src/openlmi/storage/LMI_HostedMount.py http://reviewboard-openlmi.rhcloud.com/r/130/#comment83
These lines should be removed, we use cimom_entry.py as the entry point from CIMOM
src/openlmi/storage/MountingProvider.py http://reviewboard-openlmi.rhcloud.com/r/130/#comment86
I would appreciate more information why is this class useful.
src/openlmi/storage/MountingProvider.py http://reviewboard-openlmi.rhcloud.com/r/130/#comment84
device.parents is not related with filesystem on the device in any way, why is the check here?
src/openlmi/storage/MountingProvider.py http://reviewboard-openlmi.rhcloud.com/r/130/#comment85
If I read it correctly, this says that if a device is not mounted, it's still added to list of mounts. Is this correct? It sounds weird to me.
- Jan Safranek
On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/
(Updated April 8, 2013, 3:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add LMI_MountedFileSystem and LMI_HostedMount.
Diffs
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_HostedMount.py PRE-CREATION src/openlmi/storage/LMI_MountedFileSystem.py PRE-CREATION src/openlmi/storage/MountingProvider.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/130/diff/
Testing
Thanks,
Jan Synacek
On April 9, 2013, 4:47 p.m., Jan Safranek wrote:
src/openlmi/storage/MountingProvider.py, lines 44-45 http://reviewboard-openlmi.rhcloud.com/r/130/diff/1/?file=724#file724line44
If I read it correctly, this says that if a device is not mounted, it's still added to list of mounts. Is this correct? It sounds weird to me.
Yes. It's totally wrong, I'll remove it.
On April 9, 2013, 4:47 p.m., Jan Safranek wrote:
src/openlmi/storage/MountingProvider.py, lines 41-42 http://reviewboard-openlmi.rhcloud.com/r/130/diff/1/?file=724#file724line41
device.parents is not related with filesystem on the device in any way, why is the check here?
This was there to prevent the parent device from displaying. A modified the code slightly so it's not needed there anymore.
- Jan
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/#review135 -----------------------------------------------------------
On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/
(Updated April 8, 2013, 3:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add LMI_MountedFileSystem and LMI_HostedMount.
Diffs
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_HostedMount.py PRE-CREATION src/openlmi/storage/LMI_MountedFileSystem.py PRE-CREATION src/openlmi/storage/MountingProvider.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/130/diff/
Testing
Thanks,
Jan Synacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/#review136 -----------------------------------------------------------
src/openlmi/storage/LMI_MountedFileSystem.py http://reviewboard-openlmi.rhcloud.com/r/130/#comment87
These lines should be removed, we use cimom_entry.py as the entry point from CIMOM
- Jan Safranek
On April 8, 2013, 3:22 p.m., Jan Synacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/
(Updated April 8, 2013, 3:22 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add LMI_MountedFileSystem and LMI_HostedMount.
Diffs
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_HostedMount.py PRE-CREATION src/openlmi/storage/LMI_MountedFileSystem.py PRE-CREATION src/openlmi/storage/MountingProvider.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/130/diff/
Testing
Thanks,
Jan Synacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/130/ -----------------------------------------------------------
(Updated April 17, 2013, 10:06 a.m.)
Status ------
This change has been discarded.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Add LMI_MountedFileSystem and LMI_HostedMount.
Diffs -----
mof/LMI_Storage.reg 36b149a8f52aef299ee4efff35217c72218a0ae2 src/openlmi/storage/LMI_HostedMount.py PRE-CREATION src/openlmi/storage/LMI_MountedFileSystem.py PRE-CREATION src/openlmi/storage/MountingProvider.py PRE-CREATION src/openlmi/storage/cimom_entry.py d5d2e5274aff95395b5bdbc709af3f3337ae11e1
Diff: http://reviewboard-openlmi.rhcloud.com/r/130/diff/
Testing -------
Thanks,
Jan Synacek
openlmi-devel@lists.fedorahosted.org
-
Stephen Gallagher