Review Request 279: openlmi-networking [1/1] Add lots of error checking

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/279/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Add lots of error checking

Now most of the errors should be handled properly. The error codes still
needs to be converted to error messages and presented to users.


Diffs
-----

  src/LMI_BindsToLANEndpointProvider.c 39b4186ab3702a797b9b9c153179f5a02351fd96 
  src/LMI_DNSProtocolEndpointProvider.c 017eb11aa3444cd7c2a96188a53a8f006d2a3e8d 
  src/LMI_DNSSettingDataProvider.c a3d74623b4c801b9241a3efcf2c70f6f2c20c660 
  src/LMI_EthernetPortStatisticsProvider.c ffae836683d4a442d4be8b851a3b36453ac65f37 
  src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
e4d9a14e63343ada59ac3db82c36f31cf03f3b3a 
  src/LMI_IPConfigurationServiceAffectsElementProvider.c
874ab1dd6896267d7cadc4955224ed174ea72426 
  src/LMI_IPNetworkConnectionCapabilitiesProvider.c
4dab5c55b87879ccde2a0a59806f1efa22e14c8d 
  src/activeconnection.c 648c23fa2fdf616950758b6d1e58e78e3f6b20e4 
  src/activeconnection_nm.h c60d5da01cbe0254adb5272ff89b61d2c7737ef0 
  src/activeconnection_nm.c caef0042839b520f430f5676e88d52392962e93e 
  src/connection.h 7e6d6206bae139a0d4d066f400ae78b0c70ab12d 
  src/connection.c 969232810f0342d15f8e75c64bf841b6a42b065f 
  src/connection_nm.h 8a43bd068717a4961ba986705c277fecf518aec3 
  src/connection_nm.c a5fba58e1eab8f5dc5ba3793ad247da8dbf404e0 
  src/connection_private.h 821e9fd765ab24e9262665540d03a28c91d6c2ab 
  src/dbus_wrapper.c a2d1e98a7cba16036d02a39bf314511b90d4f816 
  src/errors.h bbeec9b4fc7959f23209a6807527a2f86dbc00c8 
  src/globals.h e06b5f4fd595c277370e5ef98ac37dfd69023550 
  src/globals.c f7ce75d47d139910e13b0eec51ec537b1bca37f4 
  src/ipassignmentsettingdata.c 78489a83d262b4e78546c654e16c7a9a2401172f 
  src/ipconfig.c 575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2 
  src/network.h 9a70c28ffec537e9fdb441ea96d27e32f0da5ea3 
  src/network.c 8b64c0f06704d5a5644215f6a9af125c8ca0c598 
  src/network_nm.c 24455f3b0d0002424449bde12c854d19ad6591fe 
  src/network_private.h 27fe247e6bfc6a0381d93f23c8e0953571461cbc 
  src/nm_support.h 7f8b6cabb504ee88a6e5af16eade7e4aeddb004f 
  src/nm_support.c 272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94 
  src/port.h a249c8b34ce629f7539d562926928f7a44031fc9 
  src/port.c 4b5cd96b94b4448acb3f0498b17d74b5133f3d39 
  src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9 
  src/setting.h 80e8591f98c8378aff2ea4389f69a8f67df2578b 
  src/setting.c 91e311779829b23c927660add0bc68e479e655a4 
  src/setting_nm.h 6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28 
  src/setting_nm.c c005917c0d4bb72d715a32eabfb132a06c8983bc 
  src/unittest/mock_nm.c 7509b493418bbacd5294a1a16a0da19147a7087e 
  src/unittest/test.h 0db0dc94895a91b640c991f39ba745a13720e5fc 
  src/unittest/test_connection.c 5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4 
  src/unittest/test_network.c f1e8fe9692428679e1a79373575a098239456230 
  src/unittest/test_setting.c a03b51b45df266372212ab6d925434b2daec6bcc 

Diff: http://reviewboard-openlmi.rhcloud.com/r/279/diff/


Testing
-------


Thanks,

Radek Novacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/279/#review332
-----------------------------------------------------------



src/LMI_DNSSettingDataProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/279/#comment207>

    Looks like copy&paste error. The message should say something different. Or at
least there are "for of", so maybe remove " of".



src/LMI_IPNetworkConnectionCapabilitiesProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/279/#comment208>

    Is there ERR_NOT_SUPPORTED (or not implemented) return if it is TODO list?



src/connection_nm.c
<http://reviewboard-openlmi.rhcloud.com/r/279/#comment210>

    Looks like unintended change - moving *.



src/connection_nm.c
<http://reviewboard-openlmi.rhcloud.com/r/279/#comment211>

    Why no error("Memory allocation") here?



src/globals.c
<http://reviewboard-openlmi.rhcloud.com/r/279/#comment212>

    Now I see that the caller have to free() allocated memory. It would be good to add a
comment for it here.


- Roman Rakus


On April 29, 2013, 7:14 a.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/279/
>  -----------------------------------------------------------
>  
>  (Updated April 29, 2013, 7:14 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Add lots of error checking
>  
>  Now most of the errors should be handled properly. The error codes still
>  needs to be converted to error messages and presented to users.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_BindsToLANEndpointProvider.c 39b4186ab3702a797b9b9c153179f5a02351fd96 
>    src/LMI_DNSProtocolEndpointProvider.c 017eb11aa3444cd7c2a96188a53a8f006d2a3e8d 
>    src/LMI_DNSSettingDataProvider.c a3d74623b4c801b9241a3efcf2c70f6f2c20c660 
>    src/LMI_EthernetPortStatisticsProvider.c ffae836683d4a442d4be8b851a3b36453ac65f37 
>    src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
> e4d9a14e63343ada59ac3db82c36f31cf03f3b3a 
>    src/LMI_IPConfigurationServiceAffectsElementProvider.c
> 874ab1dd6896267d7cadc4955224ed174ea72426 
>    src/LMI_IPNetworkConnectionCapabilitiesProvider.c
> 4dab5c55b87879ccde2a0a59806f1efa22e14c8d 
>    src/activeconnection.c 648c23fa2fdf616950758b6d1e58e78e3f6b20e4 
>    src/activeconnection_nm.h c60d5da01cbe0254adb5272ff89b61d2c7737ef0 
>    src/activeconnection_nm.c caef0042839b520f430f5676e88d52392962e93e 
>    src/connection.h 7e6d6206bae139a0d4d066f400ae78b0c70ab12d 
>    src/connection.c 969232810f0342d15f8e75c64bf841b6a42b065f 
>    src/connection_nm.h 8a43bd068717a4961ba986705c277fecf518aec3 
>    src/connection_nm.c a5fba58e1eab8f5dc5ba3793ad247da8dbf404e0 
>    src/connection_private.h 821e9fd765ab24e9262665540d03a28c91d6c2ab 
>    src/dbus_wrapper.c a2d1e98a7cba16036d02a39bf314511b90d4f816 
>    src/errors.h bbeec9b4fc7959f23209a6807527a2f86dbc00c8 
>    src/globals.h e06b5f4fd595c277370e5ef98ac37dfd69023550 
>    src/globals.c f7ce75d47d139910e13b0eec51ec537b1bca37f4 
>    src/ipassignmentsettingdata.c 78489a83d262b4e78546c654e16c7a9a2401172f 
>    src/ipconfig.c 575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2 
>    src/network.h 9a70c28ffec537e9fdb441ea96d27e32f0da5ea3 
>    src/network.c 8b64c0f06704d5a5644215f6a9af125c8ca0c598 
>    src/network_nm.c 24455f3b0d0002424449bde12c854d19ad6591fe 
>    src/network_private.h 27fe247e6bfc6a0381d93f23c8e0953571461cbc 
>    src/nm_support.h 7f8b6cabb504ee88a6e5af16eade7e4aeddb004f 
>    src/nm_support.c 272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94 
>    src/port.h a249c8b34ce629f7539d562926928f7a44031fc9 
>    src/port.c 4b5cd96b94b4448acb3f0498b17d74b5133f3d39 
>    src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9 
>    src/setting.h 80e8591f98c8378aff2ea4389f69a8f67df2578b 
>    src/setting.c 91e311779829b23c927660add0bc68e479e655a4 
>    src/setting_nm.h 6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28 
>    src/setting_nm.c c005917c0d4bb72d715a32eabfb132a06c8983bc 
>    src/unittest/mock_nm.c 7509b493418bbacd5294a1a16a0da19147a7087e 
>    src/unittest/test.h 0db0dc94895a91b640c991f39ba745a13720e5fc 
>    src/unittest/test_connection.c 5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4 
>    src/unittest/test_network.c f1e8fe9692428679e1a79373575a098239456230 
>    src/unittest/test_setting.c a03b51b45df266372212ab6d925434b2daec6bcc 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/279/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/279/#review335
-----------------------------------------------------------



src/LMI_BindsToLANEndpointProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/279/#comment213>

    It's on more places; I'm not sure if you need to say the class name. If so, it
will be good to use macro.



src/ipassignmentsettingdata.c
<http://reviewboard-openlmi.rhcloud.com/r/279/#comment214>

    It's on more places - missing error message?


- Roman Rakus


On April 29, 2013, 7:14 a.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/279/
>  -----------------------------------------------------------
>  
>  (Updated April 29, 2013, 7:14 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Add lots of error checking
>  
>  Now most of the errors should be handled properly. The error codes still
>  needs to be converted to error messages and presented to users.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_BindsToLANEndpointProvider.c 39b4186ab3702a797b9b9c153179f5a02351fd96 
>    src/LMI_DNSProtocolEndpointProvider.c 017eb11aa3444cd7c2a96188a53a8f006d2a3e8d 
>    src/LMI_DNSSettingDataProvider.c a3d74623b4c801b9241a3efcf2c70f6f2c20c660 
>    src/LMI_EthernetPortStatisticsProvider.c ffae836683d4a442d4be8b851a3b36453ac65f37 
>    src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
> e4d9a14e63343ada59ac3db82c36f31cf03f3b3a 
>    src/LMI_IPConfigurationServiceAffectsElementProvider.c
> 874ab1dd6896267d7cadc4955224ed174ea72426 
>    src/LMI_IPNetworkConnectionCapabilitiesProvider.c
> 4dab5c55b87879ccde2a0a59806f1efa22e14c8d 
>    src/activeconnection.c 648c23fa2fdf616950758b6d1e58e78e3f6b20e4 
>    src/activeconnection_nm.h c60d5da01cbe0254adb5272ff89b61d2c7737ef0 
>    src/activeconnection_nm.c caef0042839b520f430f5676e88d52392962e93e 
>    src/connection.h 7e6d6206bae139a0d4d066f400ae78b0c70ab12d 
>    src/connection.c 969232810f0342d15f8e75c64bf841b6a42b065f 
>    src/connection_nm.h 8a43bd068717a4961ba986705c277fecf518aec3 
>    src/connection_nm.c a5fba58e1eab8f5dc5ba3793ad247da8dbf404e0 
>    src/connection_private.h 821e9fd765ab24e9262665540d03a28c91d6c2ab 
>    src/dbus_wrapper.c a2d1e98a7cba16036d02a39bf314511b90d4f816 
>    src/errors.h bbeec9b4fc7959f23209a6807527a2f86dbc00c8 
>    src/globals.h e06b5f4fd595c277370e5ef98ac37dfd69023550 
>    src/globals.c f7ce75d47d139910e13b0eec51ec537b1bca37f4 
>    src/ipassignmentsettingdata.c 78489a83d262b4e78546c654e16c7a9a2401172f 
>    src/ipconfig.c 575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2 
>    src/network.h 9a70c28ffec537e9fdb441ea96d27e32f0da5ea3 
>    src/network.c 8b64c0f06704d5a5644215f6a9af125c8ca0c598 
>    src/network_nm.c 24455f3b0d0002424449bde12c854d19ad6591fe 
>    src/network_private.h 27fe247e6bfc6a0381d93f23c8e0953571461cbc 
>    src/nm_support.h 7f8b6cabb504ee88a6e5af16eade7e4aeddb004f 
>    src/nm_support.c 272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94 
>    src/port.h a249c8b34ce629f7539d562926928f7a44031fc9 
>    src/port.c 4b5cd96b94b4448acb3f0498b17d74b5133f3d39 
>    src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9 
>    src/setting.h 80e8591f98c8378aff2ea4389f69a8f67df2578b 
>    src/setting.c 91e311779829b23c927660add0bc68e479e655a4 
>    src/setting_nm.h 6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28 
>    src/setting_nm.c c005917c0d4bb72d715a32eabfb132a06c8983bc 
>    src/unittest/mock_nm.c 7509b493418bbacd5294a1a16a0da19147a7087e 
>    src/unittest/test.h 0db0dc94895a91b640c991f39ba745a13720e5fc 
>    src/unittest/test_connection.c 5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4 
>    src/unittest/test_network.c f1e8fe9692428679e1a79373575a098239456230 
>    src/unittest/test_setting.c a03b51b45df266372212ab6d925434b2daec6bcc 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/279/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

>  On April 29, 2013, 4:02 p.m., Roman Rakus wrote:
>  > src/connection_nm.c, line 74
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/279/diff/1/?file=1549#file1549li...
>  >
>  >     Looks like unintended change - moving *. 
Yes, nice catch, will fix.


>  On April 29, 2013, 4:02 p.m., Roman Rakus wrote:
>  > src/LMI_IPNetworkConnectionCapabilitiesProvider.c, line 340
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/279/diff/1/?file=1542#file1542li...
>  >
>  >     Is there ERR_NOT_SUPPORTED (or not implemented) return if it is TODO list?
I'll add the error.


>  On April 29, 2013, 4:02 p.m., Roman Rakus wrote:
>  > src/connection_nm.c, lines 82-85
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/279/diff/1/?file=1549#file1549li...
>  >
>  >     Why no error("Memory allocation") here? 
I've overlooked it.


>  On April 29, 2013, 4:02 p.m., Roman Rakus wrote:
>  > src/globals.c, line 43
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/279/diff/1/?file=1554#file1554li...
>  >
>  >     Now I see that the caller have to free() allocated memory. It would be good to
> add a comment for it here. 
OK, will add.


- Radek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/279/#review332
-----------------------------------------------------------


On April 29, 2013, 9:14 a.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/279/
>  -----------------------------------------------------------
>  
>  (Updated April 29, 2013, 9:14 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Add lots of error checking
>  
>  Now most of the errors should be handled properly. The error codes still
>  needs to be converted to error messages and presented to users.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_BindsToLANEndpointProvider.c 39b4186ab3702a797b9b9c153179f5a02351fd96 
>    src/LMI_DNSProtocolEndpointProvider.c 017eb11aa3444cd7c2a96188a53a8f006d2a3e8d 
>    src/LMI_DNSSettingDataProvider.c a3d74623b4c801b9241a3efcf2c70f6f2c20c660 
>    src/LMI_EthernetPortStatisticsProvider.c ffae836683d4a442d4be8b851a3b36453ac65f37 
>    src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
> e4d9a14e63343ada59ac3db82c36f31cf03f3b3a 
>    src/LMI_IPConfigurationServiceAffectsElementProvider.c
> 874ab1dd6896267d7cadc4955224ed174ea72426 
>    src/LMI_IPNetworkConnectionCapabilitiesProvider.c
> 4dab5c55b87879ccde2a0a59806f1efa22e14c8d 
>    src/activeconnection.c 648c23fa2fdf616950758b6d1e58e78e3f6b20e4 
>    src/activeconnection_nm.h c60d5da01cbe0254adb5272ff89b61d2c7737ef0 
>    src/activeconnection_nm.c caef0042839b520f430f5676e88d52392962e93e 
>    src/connection.h 7e6d6206bae139a0d4d066f400ae78b0c70ab12d 
>    src/connection.c 969232810f0342d15f8e75c64bf841b6a42b065f 
>    src/connection_nm.h 8a43bd068717a4961ba986705c277fecf518aec3 
>    src/connection_nm.c a5fba58e1eab8f5dc5ba3793ad247da8dbf404e0 
>    src/connection_private.h 821e9fd765ab24e9262665540d03a28c91d6c2ab 
>    src/dbus_wrapper.c a2d1e98a7cba16036d02a39bf314511b90d4f816 
>    src/errors.h bbeec9b4fc7959f23209a6807527a2f86dbc00c8 
>    src/globals.h e06b5f4fd595c277370e5ef98ac37dfd69023550 
>    src/globals.c f7ce75d47d139910e13b0eec51ec537b1bca37f4 
>    src/ipassignmentsettingdata.c 78489a83d262b4e78546c654e16c7a9a2401172f 
>    src/ipconfig.c 575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2 
>    src/network.h 9a70c28ffec537e9fdb441ea96d27e32f0da5ea3 
>    src/network.c 8b64c0f06704d5a5644215f6a9af125c8ca0c598 
>    src/network_nm.c 24455f3b0d0002424449bde12c854d19ad6591fe 
>    src/network_private.h 27fe247e6bfc6a0381d93f23c8e0953571461cbc 
>    src/nm_support.h 7f8b6cabb504ee88a6e5af16eade7e4aeddb004f 
>    src/nm_support.c 272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94 
>    src/port.h a249c8b34ce629f7539d562926928f7a44031fc9 
>    src/port.c 4b5cd96b94b4448acb3f0498b17d74b5133f3d39 
>    src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9 
>    src/setting.h 80e8591f98c8378aff2ea4389f69a8f67df2578b 
>    src/setting.c 91e311779829b23c927660add0bc68e479e655a4 
>    src/setting_nm.h 6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28 
>    src/setting_nm.c c005917c0d4bb72d715a32eabfb132a06c8983bc 
>    src/unittest/mock_nm.c 7509b493418bbacd5294a1a16a0da19147a7087e 
>    src/unittest/test.h 0db0dc94895a91b640c991f39ba745a13720e5fc 
>    src/unittest/test_connection.c 5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4 
>    src/unittest/test_network.c f1e8fe9692428679e1a79373575a098239456230 
>    src/unittest/test_setting.c a03b51b45df266372212ab6d925434b2daec6bcc 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/279/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/279/
-----------------------------------------------------------

(Updated April 30, 2013, 8:49 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Add lots of error checking

Now most of the errors should be handled properly. The error codes still
needs to be converted to error messages and presented to users.


Diffs (updated)
-----

  src/LMI_BindsToLANEndpointProvider.c 39b4186ab3702a797b9b9c153179f5a02351fd96 
  src/LMI_DNSProtocolEndpointProvider.c 017eb11aa3444cd7c2a96188a53a8f006d2a3e8d 
  src/LMI_DNSSettingDataProvider.c 6f0cbaf1b3aa6ce557c8b0f6975a29fee4feac11 
  src/LMI_EthernetPortStatisticsProvider.c ffae836683d4a442d4be8b851a3b36453ac65f37 
  src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
731760368218c190f08cd6ebc2d5b2cb1174b8cc 
  src/LMI_IPConfigurationServiceAffectsElementProvider.c
874ab1dd6896267d7cadc4955224ed174ea72426 
  src/LMI_IPNetworkConnectionCapabilitiesProvider.c
3a1dfc4550f0b64fbd0515a5339c84c91f46e331 
  src/activeconnection.c 648c23fa2fdf616950758b6d1e58e78e3f6b20e4 
  src/activeconnection_nm.h c60d5da01cbe0254adb5272ff89b61d2c7737ef0 
  src/activeconnection_nm.c caef0042839b520f430f5676e88d52392962e93e 
  src/connection.h 49c4b85f07a8c09acff6bd3530c045580847f4cc 
  src/connection.c 58c7b8d9b9ea6a95094368da853d89fa178d6c64 
  src/connection_nm.h 8a43bd068717a4961ba986705c277fecf518aec3 
  src/connection_nm.c 2c6eab8926012089b8364dce6652c571686f473d 
  src/connection_private.h 821e9fd765ab24e9262665540d03a28c91d6c2ab 
  src/dbus_wrapper.c a2d1e98a7cba16036d02a39bf314511b90d4f816 
  src/errors.h bbeec9b4fc7959f23209a6807527a2f86dbc00c8 
  src/globals.h e06b5f4fd595c277370e5ef98ac37dfd69023550 
  src/globals.c f7ce75d47d139910e13b0eec51ec537b1bca37f4 
  src/ipassignmentsettingdata.c 1a9501e04fcf8791b54deb719fd8c3c1d32f4633 
  src/ipconfig.c 575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2 
  src/network.h 9a70c28ffec537e9fdb441ea96d27e32f0da5ea3 
  src/network.c 8b64c0f06704d5a5644215f6a9af125c8ca0c598 
  src/network_nm.c 24455f3b0d0002424449bde12c854d19ad6591fe 
  src/network_private.h 27fe247e6bfc6a0381d93f23c8e0953571461cbc 
  src/nm_support.h 7f8b6cabb504ee88a6e5af16eade7e4aeddb004f 
  src/nm_support.c 272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94 
  src/port.h a249c8b34ce629f7539d562926928f7a44031fc9 
  src/port.c 4b5cd96b94b4448acb3f0498b17d74b5133f3d39 
  src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9 
  src/setting.h 1f678c3a6c96fc26184c90089539bfaffc433e3e 
  src/setting.c e05ed50ac3b2a13806f6abe032a0e588d81e39c9 
  src/setting_nm.h 6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28 
  src/setting_nm.c c005917c0d4bb72d715a32eabfb132a06c8983bc 
  src/unittest/mock_nm.c 7509b493418bbacd5294a1a16a0da19147a7087e 
  src/unittest/test.h 4997906c65f646a785ccdb4e9bb90ecc1f549ac7 
  src/unittest/test_connection.c 5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4 
  src/unittest/test_network.c 75ef1d602fb09353cb5da871012615ac68bb3968 
  src/unittest/test_setting.c a03b51b45df266372212ab6d925434b2daec6bcc 

Diff: http://reviewboard-openlmi.rhcloud.com/r/279/diff/


Testing
-------


Thanks,

Radek Novacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/279/#review339
-----------------------------------------------------------



src/LMI_IPNetworkConnectionCapabilitiesProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/279/#comment219>

    Sorry, this came from different commit, not part of the review


- Radek Novacek


On April 30, 2013, 8:49 a.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/279/
>  -----------------------------------------------------------
>  
>  (Updated April 30, 2013, 8:49 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Add lots of error checking
>  
>  Now most of the errors should be handled properly. The error codes still
>  needs to be converted to error messages and presented to users.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_BindsToLANEndpointProvider.c 39b4186ab3702a797b9b9c153179f5a02351fd96 
>    src/LMI_DNSProtocolEndpointProvider.c 017eb11aa3444cd7c2a96188a53a8f006d2a3e8d 
>    src/LMI_DNSSettingDataProvider.c 6f0cbaf1b3aa6ce557c8b0f6975a29fee4feac11 
>    src/LMI_EthernetPortStatisticsProvider.c ffae836683d4a442d4be8b851a3b36453ac65f37 
>    src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
> 731760368218c190f08cd6ebc2d5b2cb1174b8cc 
>    src/LMI_IPConfigurationServiceAffectsElementProvider.c
> 874ab1dd6896267d7cadc4955224ed174ea72426 
>    src/LMI_IPNetworkConnectionCapabilitiesProvider.c
> 3a1dfc4550f0b64fbd0515a5339c84c91f46e331 
>    src/activeconnection.c 648c23fa2fdf616950758b6d1e58e78e3f6b20e4 
>    src/activeconnection_nm.h c60d5da01cbe0254adb5272ff89b61d2c7737ef0 
>    src/activeconnection_nm.c caef0042839b520f430f5676e88d52392962e93e 
>    src/connection.h 49c4b85f07a8c09acff6bd3530c045580847f4cc 
>    src/connection.c 58c7b8d9b9ea6a95094368da853d89fa178d6c64 
>    src/connection_nm.h 8a43bd068717a4961ba986705c277fecf518aec3 
>    src/connection_nm.c 2c6eab8926012089b8364dce6652c571686f473d 
>    src/connection_private.h 821e9fd765ab24e9262665540d03a28c91d6c2ab 
>    src/dbus_wrapper.c a2d1e98a7cba16036d02a39bf314511b90d4f816 
>    src/errors.h bbeec9b4fc7959f23209a6807527a2f86dbc00c8 
>    src/globals.h e06b5f4fd595c277370e5ef98ac37dfd69023550 
>    src/globals.c f7ce75d47d139910e13b0eec51ec537b1bca37f4 
>    src/ipassignmentsettingdata.c 1a9501e04fcf8791b54deb719fd8c3c1d32f4633 
>    src/ipconfig.c 575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2 
>    src/network.h 9a70c28ffec537e9fdb441ea96d27e32f0da5ea3 
>    src/network.c 8b64c0f06704d5a5644215f6a9af125c8ca0c598 
>    src/network_nm.c 24455f3b0d0002424449bde12c854d19ad6591fe 
>    src/network_private.h 27fe247e6bfc6a0381d93f23c8e0953571461cbc 
>    src/nm_support.h 7f8b6cabb504ee88a6e5af16eade7e4aeddb004f 
>    src/nm_support.c 272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94 
>    src/port.h a249c8b34ce629f7539d562926928f7a44031fc9 
>    src/port.c 4b5cd96b94b4448acb3f0498b17d74b5133f3d39 
>    src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9 
>    src/setting.h 1f678c3a6c96fc26184c90089539bfaffc433e3e 
>    src/setting.c e05ed50ac3b2a13806f6abe032a0e588d81e39c9 
>    src/setting_nm.h 6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28 
>    src/setting_nm.c c005917c0d4bb72d715a32eabfb132a06c8983bc 
>    src/unittest/mock_nm.c 7509b493418bbacd5294a1a16a0da19147a7087e 
>    src/unittest/test.h 4997906c65f646a785ccdb4e9bb90ecc1f549ac7 
>    src/unittest/test_connection.c 5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4 
>    src/unittest/test_network.c 75ef1d602fb09353cb5da871012615ac68bb3968 
>    src/unittest/test_setting.c a03b51b45df266372212ab6d925434b2daec6bcc 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/279/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/279/#review386
-----------------------------------------------------------



src/LMI_DNSSettingDataProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/279/#comment240>

    Still hardcoded class names.


- Roman Rakus


On April 30, 2013, 6:49 a.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/279/
>  -----------------------------------------------------------
>  
>  (Updated April 30, 2013, 6:49 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Add lots of error checking
>  
>  Now most of the errors should be handled properly. The error codes still
>  needs to be converted to error messages and presented to users.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_BindsToLANEndpointProvider.c 39b4186ab3702a797b9b9c153179f5a02351fd96 
>    src/LMI_DNSProtocolEndpointProvider.c 017eb11aa3444cd7c2a96188a53a8f006d2a3e8d 
>    src/LMI_DNSSettingDataProvider.c 6f0cbaf1b3aa6ce557c8b0f6975a29fee4feac11 
>    src/LMI_EthernetPortStatisticsProvider.c ffae836683d4a442d4be8b851a3b36453ac65f37 
>    src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
> 731760368218c190f08cd6ebc2d5b2cb1174b8cc 
>    src/LMI_IPConfigurationServiceAffectsElementProvider.c
> 874ab1dd6896267d7cadc4955224ed174ea72426 
>    src/LMI_IPNetworkConnectionCapabilitiesProvider.c
> 3a1dfc4550f0b64fbd0515a5339c84c91f46e331 
>    src/activeconnection.c 648c23fa2fdf616950758b6d1e58e78e3f6b20e4 
>    src/activeconnection_nm.h c60d5da01cbe0254adb5272ff89b61d2c7737ef0 
>    src/activeconnection_nm.c caef0042839b520f430f5676e88d52392962e93e 
>    src/connection.h 49c4b85f07a8c09acff6bd3530c045580847f4cc 
>    src/connection.c 58c7b8d9b9ea6a95094368da853d89fa178d6c64 
>    src/connection_nm.h 8a43bd068717a4961ba986705c277fecf518aec3 
>    src/connection_nm.c 2c6eab8926012089b8364dce6652c571686f473d 
>    src/connection_private.h 821e9fd765ab24e9262665540d03a28c91d6c2ab 
>    src/dbus_wrapper.c a2d1e98a7cba16036d02a39bf314511b90d4f816 
>    src/errors.h bbeec9b4fc7959f23209a6807527a2f86dbc00c8 
>    src/globals.h e06b5f4fd595c277370e5ef98ac37dfd69023550 
>    src/globals.c f7ce75d47d139910e13b0eec51ec537b1bca37f4 
>    src/ipassignmentsettingdata.c 1a9501e04fcf8791b54deb719fd8c3c1d32f4633 
>    src/ipconfig.c 575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2 
>    src/network.h 9a70c28ffec537e9fdb441ea96d27e32f0da5ea3 
>    src/network.c 8b64c0f06704d5a5644215f6a9af125c8ca0c598 
>    src/network_nm.c 24455f3b0d0002424449bde12c854d19ad6591fe 
>    src/network_private.h 27fe247e6bfc6a0381d93f23c8e0953571461cbc 
>    src/nm_support.h 7f8b6cabb504ee88a6e5af16eade7e4aeddb004f 
>    src/nm_support.c 272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94 
>    src/port.h a249c8b34ce629f7539d562926928f7a44031fc9 
>    src/port.c 4b5cd96b94b4448acb3f0498b17d74b5133f3d39 
>    src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9 
>    src/setting.h 1f678c3a6c96fc26184c90089539bfaffc433e3e 
>    src/setting.c e05ed50ac3b2a13806f6abe032a0e588d81e39c9 
>    src/setting_nm.h 6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28 
>    src/setting_nm.c c005917c0d4bb72d715a32eabfb132a06c8983bc 
>    src/unittest/mock_nm.c 7509b493418bbacd5294a1a16a0da19147a7087e 
>    src/unittest/test.h 4997906c65f646a785ccdb4e9bb90ecc1f549ac7 
>    src/unittest/test_connection.c 5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4 
>    src/unittest/test_network.c 75ef1d602fb09353cb5da871012615ac68bb3968 
>    src/unittest/test_setting.c a03b51b45df266372212ab6d925434b2daec6bcc 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/279/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/279/
-----------------------------------------------------------

(Updated May 10, 2013, 2:48 p.m.)


Review request for OpenLMI Developers.


Changes
-------

Fixed hardcoded class names.


Repository: openlmi-networking


Description
-------

Add lots of error checking

Now most of the errors should be handled properly. The error codes still
needs to be converted to error messages and presented to users.


Diffs (updated)
-----

  src/LMI_BindsToLANEndpointProvider.c 39b4186ab3702a797b9b9c153179f5a02351fd96 
  src/LMI_DNSProtocolEndpointProvider.c 017eb11aa3444cd7c2a96188a53a8f006d2a3e8d 
  src/LMI_DNSSettingDataProvider.c 6f0cbaf1b3aa6ce557c8b0f6975a29fee4feac11 
  src/LMI_EndpointForIPNetworkConnectionProvider.c
00ef28d4851d6e896bfdddd9c600a07ce330cdc1 
  src/LMI_EthernetPortProvider.c 0fa56f12881481d63834c7159c5534e5d8955e24 
  src/LMI_EthernetPortStatisticsProvider.c ffae836683d4a442d4be8b851a3b36453ac65f37 
  src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
731760368218c190f08cd6ebc2d5b2cb1174b8cc 
  src/LMI_IPAssignmentSettingDataProvider.c be1b866f4794d4d72c1784132f68005b3000422f 
  src/LMI_IPConfigurationServiceAffectsElementProvider.c
874ab1dd6896267d7cadc4955224ed174ea72426 
  src/LMI_IPConfigurationServiceProvider.c 364360b6509be87527bbbeca553e93cb55854053 
  src/LMI_IPElementSettingDataProvider.c 5a26bc45f3dbe20b8fb42fe71001b45f31722813 
  src/LMI_IPNetworkConnectionCapabilitiesProvider.c
3a1dfc4550f0b64fbd0515a5339c84c91f46e331 
  src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c
06ac9f33f3ae1a485ef615f83161fadb953024ac 
  src/LMI_IPNetworkConnectionProvider.c 995fe9da4db24305ab09ea5b59d6db2867156347 
  src/LMI_IPProtocolEndpointProvider.c 2df0131ec3b538d68b82a62e347ece6e399694e8 
  src/LMI_IPVersionElementSettingDataProvider.c 5fdc5aa8637833aadeb962eaf4abfb09cef51ee7 
  src/LMI_IPVersionSettingDataProvider.c 35d3525fb846cf1de5aa26421c7eeb49efb571ed 
  src/LMI_LAGPort8023adProvider.c b3d29bd37310cda7a3482fd9bdedcd594b6de2e5 
  src/LMI_LANEndpointProvider.c 89a12931051e753cbd54c956f073719029500b46 
  src/LMI_LinkAggregationBindsToProvider.c 836f581937e37638d082b117c3e015e386b0134a 
  src/LMI_LinkAggregationConcreteIdentityProvider.c
6ad051049bd1f6df1d194245814a0f88e3809eef 
  src/LMI_LinkAggregator8023adProvider.c 0f02ac8ff71575edcd4853dcc7ac26e3187c8a5a 
  src/LMI_NetworkDeviceSAPImplementationProvider.c
9a4254331b8249e8ed26871fbd7ae97e72ee8721 
  src/LMI_NetworkElementCapabilitiesProvider.c df6768f7d19b4e869113d59112993a4078d0f444 
  src/LMI_NetworkHostedAccessPointProvider.c 6c8829be9e20840dda978d3d58d0e9f108a97a16 
  src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
8df7f3ac03b40e4e4cff1a8480fc01c8ca9612c9 
  src/LMI_NetworkRemoteServiceAccessPointProvider.c
cb42e0cf8b63787b681a029b63394fa0eb9f2d40 
  src/LMI_NetworkSAPSAPDependencyProvider.c 23898d06dfa88677b6bb669cef81f0c9a16821be 
  src/LMI_NetworkSystemDeviceProvider.c 410810d2dfa94606c34162e7de8b5a429ecd7f85 
  src/LMI_OrderedIPAssignmentComponentProvider.c 1f3ddb92462e07f4bca7a1141a12cba702936cd5

  src/activeconnection.c 648c23fa2fdf616950758b6d1e58e78e3f6b20e4 
  src/activeconnection_nm.h c60d5da01cbe0254adb5272ff89b61d2c7737ef0 
  src/activeconnection_nm.c caef0042839b520f430f5676e88d52392962e93e 
  src/connection.h 49c4b85f07a8c09acff6bd3530c045580847f4cc 
  src/connection.c 58c7b8d9b9ea6a95094368da853d89fa178d6c64 
  src/connection_nm.h 8a43bd068717a4961ba986705c277fecf518aec3 
  src/connection_nm.c 2c6eab8926012089b8364dce6652c571686f473d 
  src/connection_private.h 821e9fd765ab24e9262665540d03a28c91d6c2ab 
  src/dbus_wrapper.c a2d1e98a7cba16036d02a39bf314511b90d4f816 
  src/errors.h bbeec9b4fc7959f23209a6807527a2f86dbc00c8 
  src/globals.h e06b5f4fd595c277370e5ef98ac37dfd69023550 
  src/globals.c f7ce75d47d139910e13b0eec51ec537b1bca37f4 
  src/ipassignmentsettingdata.c 1a9501e04fcf8791b54deb719fd8c3c1d32f4633 
  src/ipconfig.c 575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2 
  src/network.h 9a70c28ffec537e9fdb441ea96d27e32f0da5ea3 
  src/network.c 8b64c0f06704d5a5644215f6a9af125c8ca0c598 
  src/network_nm.c 24455f3b0d0002424449bde12c854d19ad6591fe 
  src/network_private.h 27fe247e6bfc6a0381d93f23c8e0953571461cbc 
  src/nm_support.h 7f8b6cabb504ee88a6e5af16eade7e4aeddb004f 
  src/nm_support.c 272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94 
  src/port.h a249c8b34ce629f7539d562926928f7a44031fc9 
  src/port.c 4b5cd96b94b4448acb3f0498b17d74b5133f3d39 
  src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9 
  src/ref_factory.c 641e387374e00a296e155194e5a468414998625d 
  src/setting.h 1f678c3a6c96fc26184c90089539bfaffc433e3e 
  src/setting.c e05ed50ac3b2a13806f6abe032a0e588d81e39c9 
  src/setting_nm.h 6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28 
  src/setting_nm.c c005917c0d4bb72d715a32eabfb132a06c8983bc 
  src/unittest/mock_nm.c 7509b493418bbacd5294a1a16a0da19147a7087e 
  src/unittest/test.h 4997906c65f646a785ccdb4e9bb90ecc1f549ac7 
  src/unittest/test_connection.c 5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4 
  src/unittest/test_network.c 75ef1d602fb09353cb5da871012615ac68bb3968 
  src/unittest/test_setting.c a03b51b45df266372212ab6d925434b2daec6bcc 

Diff: http://reviewboard-openlmi.rhcloud.com/r/279/diff/


Testing
-------


Thanks,

Radek Novacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/279/#review387
-----------------------------------------------------------

Ship it!


Ship It!

- Roman Rakus


On May 10, 2013, 12:48 p.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/279/
>  -----------------------------------------------------------
>  
>  (Updated May 10, 2013, 12:48 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Add lots of error checking
>  
>  Now most of the errors should be handled properly. The error codes still
>  needs to be converted to error messages and presented to users.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_BindsToLANEndpointProvider.c 39b4186ab3702a797b9b9c153179f5a02351fd96 
>    src/LMI_DNSProtocolEndpointProvider.c 017eb11aa3444cd7c2a96188a53a8f006d2a3e8d 
>    src/LMI_DNSSettingDataProvider.c 6f0cbaf1b3aa6ce557c8b0f6975a29fee4feac11 
>    src/LMI_EndpointForIPNetworkConnectionProvider.c
> 00ef28d4851d6e896bfdddd9c600a07ce330cdc1 
>    src/LMI_EthernetPortProvider.c 0fa56f12881481d63834c7159c5534e5d8955e24 
>    src/LMI_EthernetPortStatisticsProvider.c ffae836683d4a442d4be8b851a3b36453ac65f37 
>    src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
> 731760368218c190f08cd6ebc2d5b2cb1174b8cc 
>    src/LMI_IPAssignmentSettingDataProvider.c be1b866f4794d4d72c1784132f68005b3000422f 
>    src/LMI_IPConfigurationServiceAffectsElementProvider.c
> 874ab1dd6896267d7cadc4955224ed174ea72426 
>    src/LMI_IPConfigurationServiceProvider.c 364360b6509be87527bbbeca553e93cb55854053 
>    src/LMI_IPElementSettingDataProvider.c 5a26bc45f3dbe20b8fb42fe71001b45f31722813 
>    src/LMI_IPNetworkConnectionCapabilitiesProvider.c
> 3a1dfc4550f0b64fbd0515a5339c84c91f46e331 
>    src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c
> 06ac9f33f3ae1a485ef615f83161fadb953024ac 
>    src/LMI_IPNetworkConnectionProvider.c 995fe9da4db24305ab09ea5b59d6db2867156347 
>    src/LMI_IPProtocolEndpointProvider.c 2df0131ec3b538d68b82a62e347ece6e399694e8 
>    src/LMI_IPVersionElementSettingDataProvider.c 5fdc5aa8637833aadeb962eaf4abfb09cef51ee7
>
>    src/LMI_IPVersionSettingDataProvider.c 35d3525fb846cf1de5aa26421c7eeb49efb571ed 
>    src/LMI_LAGPort8023adProvider.c b3d29bd37310cda7a3482fd9bdedcd594b6de2e5 
>    src/LMI_LANEndpointProvider.c 89a12931051e753cbd54c956f073719029500b46 
>    src/LMI_LinkAggregationBindsToProvider.c 836f581937e37638d082b117c3e015e386b0134a 
>    src/LMI_LinkAggregationConcreteIdentityProvider.c
> 6ad051049bd1f6df1d194245814a0f88e3809eef 
>    src/LMI_LinkAggregator8023adProvider.c 0f02ac8ff71575edcd4853dcc7ac26e3187c8a5a 
>    src/LMI_NetworkDeviceSAPImplementationProvider.c
> 9a4254331b8249e8ed26871fbd7ae97e72ee8721 
>    src/LMI_NetworkElementCapabilitiesProvider.c df6768f7d19b4e869113d59112993a4078d0f444 
>    src/LMI_NetworkHostedAccessPointProvider.c 6c8829be9e20840dda978d3d58d0e9f108a97a16 
>    src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
> 8df7f3ac03b40e4e4cff1a8480fc01c8ca9612c9 
>    src/LMI_NetworkRemoteServiceAccessPointProvider.c
> cb42e0cf8b63787b681a029b63394fa0eb9f2d40 
>    src/LMI_NetworkSAPSAPDependencyProvider.c 23898d06dfa88677b6bb669cef81f0c9a16821be 
>    src/LMI_NetworkSystemDeviceProvider.c 410810d2dfa94606c34162e7de8b5a429ecd7f85 
>    src/LMI_OrderedIPAssignmentComponentProvider.c 1f3ddb92462e07f4bca7a1141a12cba702936cd5
>
>    src/activeconnection.c 648c23fa2fdf616950758b6d1e58e78e3f6b20e4 
>    src/activeconnection_nm.h c60d5da01cbe0254adb5272ff89b61d2c7737ef0 
>    src/activeconnection_nm.c caef0042839b520f430f5676e88d52392962e93e 
>    src/connection.h 49c4b85f07a8c09acff6bd3530c045580847f4cc 
>    src/connection.c 58c7b8d9b9ea6a95094368da853d89fa178d6c64 
>    src/connection_nm.h 8a43bd068717a4961ba986705c277fecf518aec3 
>    src/connection_nm.c 2c6eab8926012089b8364dce6652c571686f473d 
>    src/connection_private.h 821e9fd765ab24e9262665540d03a28c91d6c2ab 
>    src/dbus_wrapper.c a2d1e98a7cba16036d02a39bf314511b90d4f816 
>    src/errors.h bbeec9b4fc7959f23209a6807527a2f86dbc00c8 
>    src/globals.h e06b5f4fd595c277370e5ef98ac37dfd69023550 
>    src/globals.c f7ce75d47d139910e13b0eec51ec537b1bca37f4 
>    src/ipassignmentsettingdata.c 1a9501e04fcf8791b54deb719fd8c3c1d32f4633 
>    src/ipconfig.c 575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2 
>    src/network.h 9a70c28ffec537e9fdb441ea96d27e32f0da5ea3 
>    src/network.c 8b64c0f06704d5a5644215f6a9af125c8ca0c598 
>    src/network_nm.c 24455f3b0d0002424449bde12c854d19ad6591fe 
>    src/network_private.h 27fe247e6bfc6a0381d93f23c8e0953571461cbc 
>    src/nm_support.h 7f8b6cabb504ee88a6e5af16eade7e4aeddb004f 
>    src/nm_support.c 272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94 
>    src/port.h a249c8b34ce629f7539d562926928f7a44031fc9 
>    src/port.c 4b5cd96b94b4448acb3f0498b17d74b5133f3d39 
>    src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9 
>    src/ref_factory.c 641e387374e00a296e155194e5a468414998625d 
>    src/setting.h 1f678c3a6c96fc26184c90089539bfaffc433e3e 
>    src/setting.c e05ed50ac3b2a13806f6abe032a0e588d81e39c9 
>    src/setting_nm.h 6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28 
>    src/setting_nm.c c005917c0d4bb72d715a32eabfb132a06c8983bc 
>    src/unittest/mock_nm.c 7509b493418bbacd5294a1a16a0da19147a7087e 
>    src/unittest/test.h 4997906c65f646a785ccdb4e9bb90ecc1f549ac7 
>    src/unittest/test_connection.c 5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4 
>    src/unittest/test_network.c 75ef1d602fb09353cb5da871012615ac68bb3968 
>    src/unittest/test_setting.c a03b51b45df266372212ab6d925434b2daec6bcc 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/279/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/279/
-----------------------------------------------------------

(Updated May 10, 2013, 3:45 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Add lots of error checking

Now most of the errors should be handled properly. The error codes still
needs to be converted to error messages and presented to users.


Diffs
-----

  src/LMI_BindsToLANEndpointProvider.c 39b4186ab3702a797b9b9c153179f5a02351fd96 
  src/LMI_DNSProtocolEndpointProvider.c 017eb11aa3444cd7c2a96188a53a8f006d2a3e8d 
  src/LMI_DNSSettingDataProvider.c 6f0cbaf1b3aa6ce557c8b0f6975a29fee4feac11 
  src/LMI_EndpointForIPNetworkConnectionProvider.c
00ef28d4851d6e896bfdddd9c600a07ce330cdc1 
  src/LMI_EthernetPortProvider.c 0fa56f12881481d63834c7159c5534e5d8955e24 
  src/LMI_EthernetPortStatisticsProvider.c ffae836683d4a442d4be8b851a3b36453ac65f37 
  src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
731760368218c190f08cd6ebc2d5b2cb1174b8cc 
  src/LMI_IPAssignmentSettingDataProvider.c be1b866f4794d4d72c1784132f68005b3000422f 
  src/LMI_IPConfigurationServiceAffectsElementProvider.c
874ab1dd6896267d7cadc4955224ed174ea72426 
  src/LMI_IPConfigurationServiceProvider.c 364360b6509be87527bbbeca553e93cb55854053 
  src/LMI_IPElementSettingDataProvider.c 5a26bc45f3dbe20b8fb42fe71001b45f31722813 
  src/LMI_IPNetworkConnectionCapabilitiesProvider.c
3a1dfc4550f0b64fbd0515a5339c84c91f46e331 
  src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c
06ac9f33f3ae1a485ef615f83161fadb953024ac 
  src/LMI_IPNetworkConnectionProvider.c 995fe9da4db24305ab09ea5b59d6db2867156347 
  src/LMI_IPProtocolEndpointProvider.c 2df0131ec3b538d68b82a62e347ece6e399694e8 
  src/LMI_IPVersionElementSettingDataProvider.c 5fdc5aa8637833aadeb962eaf4abfb09cef51ee7 
  src/LMI_IPVersionSettingDataProvider.c 35d3525fb846cf1de5aa26421c7eeb49efb571ed 
  src/LMI_LAGPort8023adProvider.c b3d29bd37310cda7a3482fd9bdedcd594b6de2e5 
  src/LMI_LANEndpointProvider.c 89a12931051e753cbd54c956f073719029500b46 
  src/LMI_LinkAggregationBindsToProvider.c 836f581937e37638d082b117c3e015e386b0134a 
  src/LMI_LinkAggregationConcreteIdentityProvider.c
6ad051049bd1f6df1d194245814a0f88e3809eef 
  src/LMI_LinkAggregator8023adProvider.c 0f02ac8ff71575edcd4853dcc7ac26e3187c8a5a 
  src/LMI_NetworkDeviceSAPImplementationProvider.c
9a4254331b8249e8ed26871fbd7ae97e72ee8721 
  src/LMI_NetworkElementCapabilitiesProvider.c df6768f7d19b4e869113d59112993a4078d0f444 
  src/LMI_NetworkHostedAccessPointProvider.c 6c8829be9e20840dda978d3d58d0e9f108a97a16 
  src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
8df7f3ac03b40e4e4cff1a8480fc01c8ca9612c9 
  src/LMI_NetworkRemoteServiceAccessPointProvider.c
cb42e0cf8b63787b681a029b63394fa0eb9f2d40 
  src/LMI_NetworkSAPSAPDependencyProvider.c 23898d06dfa88677b6bb669cef81f0c9a16821be 
  src/LMI_NetworkSystemDeviceProvider.c 410810d2dfa94606c34162e7de8b5a429ecd7f85 
  src/LMI_OrderedIPAssignmentComponentProvider.c 1f3ddb92462e07f4bca7a1141a12cba702936cd5

  src/activeconnection.c 648c23fa2fdf616950758b6d1e58e78e3f6b20e4 
  src/activeconnection_nm.h c60d5da01cbe0254adb5272ff89b61d2c7737ef0 
  src/activeconnection_nm.c caef0042839b520f430f5676e88d52392962e93e 
  src/connection.h 49c4b85f07a8c09acff6bd3530c045580847f4cc 
  src/connection.c 58c7b8d9b9ea6a95094368da853d89fa178d6c64 
  src/connection_nm.h 8a43bd068717a4961ba986705c277fecf518aec3 
  src/connection_nm.c 2c6eab8926012089b8364dce6652c571686f473d 
  src/connection_private.h 821e9fd765ab24e9262665540d03a28c91d6c2ab 
  src/dbus_wrapper.c a2d1e98a7cba16036d02a39bf314511b90d4f816 
  src/errors.h bbeec9b4fc7959f23209a6807527a2f86dbc00c8 
  src/globals.h e06b5f4fd595c277370e5ef98ac37dfd69023550 
  src/globals.c f7ce75d47d139910e13b0eec51ec537b1bca37f4 
  src/ipassignmentsettingdata.c 1a9501e04fcf8791b54deb719fd8c3c1d32f4633 
  src/ipconfig.c 575a37ce0f17aa1928d3bcd686bdccaaafbfa5a2 
  src/network.h 9a70c28ffec537e9fdb441ea96d27e32f0da5ea3 
  src/network.c 8b64c0f06704d5a5644215f6a9af125c8ca0c598 
  src/network_nm.c 24455f3b0d0002424449bde12c854d19ad6591fe 
  src/network_private.h 27fe247e6bfc6a0381d93f23c8e0953571461cbc 
  src/nm_support.h 7f8b6cabb504ee88a6e5af16eade7e4aeddb004f 
  src/nm_support.c 272bd3ebef44b5b0a2b40ee0cba31b42cc7e9f94 
  src/port.h a249c8b34ce629f7539d562926928f7a44031fc9 
  src/port.c 4b5cd96b94b4448acb3f0498b17d74b5133f3d39 
  src/port_nm.c d3d123788d673dc40491e58a23001e8d16370ff9 
  src/ref_factory.c 641e387374e00a296e155194e5a468414998625d 
  src/setting.h 1f678c3a6c96fc26184c90089539bfaffc433e3e 
  src/setting.c e05ed50ac3b2a13806f6abe032a0e588d81e39c9 
  src/setting_nm.h 6f626b83a2c2b70ba0a4ce9ff233be54fc7ebe28 
  src/setting_nm.c c005917c0d4bb72d715a32eabfb132a06c8983bc 
  src/unittest/mock_nm.c 7509b493418bbacd5294a1a16a0da19147a7087e 
  src/unittest/test.h 4997906c65f646a785ccdb4e9bb90ecc1f549ac7 
  src/unittest/test_connection.c 5d4c9bdb4590e8181aa8d70f96f24162be0bd8c4 
  src/unittest/test_network.c 75ef1d602fb09353cb5da871012615ac68bb3968 
  src/unittest/test_setting.c a03b51b45df266372212ab6d925434b2daec6bcc 

Diff: http://reviewboard-openlmi.rhcloud.com/r/279/diff/


Testing
-------


Thanks,

Radek Novacek