----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Account: Added associative thread locking.
Diffs -----
src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48 src/account/lock.h PRE-CREATION src/account/LMI_AccountProvider.c c7c16bb2beb1ef37e804e7cc7dce6bd182e6d55b src/account/lock.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/846/diff/
Testing -------
Thanks,
Robin Hack
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/#review1146 -----------------------------------------------------------
src/account/LMI_AccountProvider.c http://reviewboard-openlmi.rhcloud.com/r/846/#comment678
Ok. I don't know how to return error in this function.
- Robin Hack
On Sept. 10, 2013, 1:27 p.m., Robin Hack wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/
(Updated Sept. 10, 2013, 1:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Added associative thread locking.
Diffs
src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48 src/account/lock.h PRE-CREATION src/account/LMI_AccountProvider.c c7c16bb2beb1ef37e804e7cc7dce6bd182e6d55b src/account/lock.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/846/diff/
Testing
Thanks,
Robin Hack
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/#review1147 -----------------------------------------------------------
Ship it!
I don't see any issue.
- Roman Rakus
On Sept. 10, 2013, 1:27 p.m., Robin Hack wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/
(Updated Sept. 10, 2013, 1:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Added associative thread locking.
Diffs
src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48 src/account/lock.h PRE-CREATION src/account/LMI_AccountProvider.c c7c16bb2beb1ef37e804e7cc7dce6bd182e6d55b src/account/lock.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/846/diff/
Testing
Thanks,
Robin Hack
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/#review1148 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On Sept. 10, 2013, 3:27 p.m., Robin Hack wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/
(Updated Sept. 10, 2013, 3:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Added associative thread locking.
Diffs
src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48 src/account/lock.h PRE-CREATION src/account/LMI_AccountProvider.c c7c16bb2beb1ef37e804e7cc7dce6bd182e6d55b src/account/lock.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/846/diff/
Testing
Thanks,
Robin Hack
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/#review1150 -----------------------------------------------------------
Ship it!
src/account/lock.c http://reviewboard-openlmi.rhcloud.com/r/846/#comment680
Why undefine???
- Jan Safranek
On Sept. 10, 2013, 3:27 p.m., Robin Hack wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/
(Updated Sept. 10, 2013, 3:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Added associative thread locking.
Diffs
src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48 src/account/lock.h PRE-CREATION src/account/LMI_AccountProvider.c c7c16bb2beb1ef37e804e7cc7dce6bd182e6d55b src/account/lock.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/846/diff/
Testing
Thanks,
Robin Hack
On Sept. 10, 2013, 2:03 p.m., Jan Safranek wrote:
src/account/lock.c, lines 184-187 http://reviewboard-openlmi.rhcloud.com/r/846/diff/1/?file=4649#file4649line184
Why undefine???
Fixed in review #850. https://reviewboard-openlmi.rhcloud.com/r/850/
- Robin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/#review1150 -----------------------------------------------------------
On Sept. 10, 2013, 1:27 p.m., Robin Hack wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/
(Updated Sept. 10, 2013, 1:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Added associative thread locking.
Diffs
src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48 src/account/lock.h PRE-CREATION src/account/LMI_AccountProvider.c c7c16bb2beb1ef37e804e7cc7dce6bd182e6d55b src/account/lock.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/846/diff/
Testing
Thanks,
Robin Hack
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/846/ -----------------------------------------------------------
(Updated Sept. 11, 2013, 7:49 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Account: Added associative thread locking.
Diffs -----
src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48 src/account/lock.h PRE-CREATION src/account/LMI_AccountProvider.c c7c16bb2beb1ef37e804e7cc7dce6bd182e6d55b src/account/lock.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/846/diff/
Testing -------
Thanks,
Robin Hack
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher