Review Request 1147: [1/1] software - tests: software test suite with basic tests
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1147/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
Diffs
-----
src/software/test/lmi-test.repo PRE-CREATION
src/software/test/testSoftware.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1147/diff/
Testing
-------
Thanks,
Jan Grec
9 years, 5 months
Review Request 1699: OpenLMI SSSD provider
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1699/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
This is the OpenLMI SSSD provider.
It is yet dependent on an unreleased version of SSSD and even on patches that are not present in SSSD master branch. We are slowly reviewing and push these patches to the master. In the mean time, please use the SSSD from my repository, branch #openlmi:
http://fedorapeople.org/cgit/pbrezina/public_git/sssd.git/log/?h=openlmi
The IFP service has to be enabled in SSSD for the provider to be able to communicate with the daemon.
Diffs
-----
CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b
README 3466aee84a57e142256fd77188aa5c87ee3167f5
doc/admin/CMakeLists.txt 96e7616e2af807d99b4afe7af81571367e15f286
doc/admin/sssd/index.rst PRE-CREATION
mof/60_LMI_SSSD.mof PRE-CREATION
mof/CMakeLists.txt 0c020a18517ecc469c70a93a6b7b824e0bca3117
openlmi-providers.spec 624ba7711a0836f37143cb16187ff548a647328f
src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1
src/sssd/90_LMI_SSSD_Profile.mof.skel PRE-CREATION
src/sssd/CMakeLists.txt PRE-CREATION
src/sssd/LMI_HostedSSSDServiceProvider.c PRE-CREATION
src/sssd/LMI_SSSDAvailableComponentProvider.c PRE-CREATION
src/sssd/LMI_SSSDAvailableDomainProvider.c PRE-CREATION
src/sssd/LMI_SSSDBackendDomainProvider.c PRE-CREATION
src/sssd/LMI_SSSDBackendProvider.c PRE-CREATION
src/sssd/LMI_SSSDBackendProviderProvider.c PRE-CREATION
src/sssd/LMI_SSSDComponentProvider.c PRE-CREATION
src/sssd/LMI_SSSDDomainProvider.c PRE-CREATION
src/sssd/LMI_SSSDDomainSubdomainProvider.c PRE-CREATION
src/sssd/LMI_SSSDMonitorProvider.c PRE-CREATION
src/sssd/LMI_SSSDProviderProvider.c PRE-CREATION
src/sssd/LMI_SSSDResponderProvider.c PRE-CREATION
src/sssd/LMI_SSSDServiceProvider.c PRE-CREATION
src/sssd/cmpiLMI_SSSD-cimprovagt PRE-CREATION
src/sssd/sssd_components.h PRE-CREATION
src/sssd/sssd_components.c PRE-CREATION
src/sssd/sssd_domains.h PRE-CREATION
src/sssd/sssd_domains.c PRE-CREATION
src/sssd/utils.h PRE-CREATION
src/sssd/utils.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1699/diff/
Testing
-------
Thanks,
Pavel Březina
9 years, 9 months
Review Request 1506: lmishell, convert strings to unicode when working with LMIInstance(Name)s
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1506/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
When creating new LMIInstanceName via LMIClass.new_instance_name(), all the string key-bindings are converted into unicode strings.
Similar operations are performed, when assigning a new value to LMIInstanceNames' key-binding and LMIInstances' property.
Diffs
-----
cli/lmi/shell/LMIClass.py 67c21c1a4431d2b98faa04a6281c27012632e478
cli/lmi/shell/LMIInstanceName.py 01b0e332b65e459477f2e02fadba3e3f725161ad
cli/lmi/shell/LMIUtil.py 69cbf75fdf73d57d3b6e5067edf72100962b6df7
Diff: http://reviewboard-openlmi.rhcloud.com/r/1506/diff/
Testing
-------
Thanks,
Peter Hatina
9 years, 10 months
Review Request 1759: Add event-based tests for indications (basic set)
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1759/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Basic set of tests with focus on this flow:
1. add set of subscriptions
2. add set of handlers
3. trigger sequence of "interesting" events
4. collect indications
5. and make assertions as needed
Currently the assertions are mostly that correct classes have been
delivered, reporting the events in correct order.
~~
This is followup to request #1741.
Since then:
* Rewrote old and added missing docstrings
* `TestIndicationEventStream` now inherits from
`IndicationStreamTestCase` instead using it as mixin
* fixed typos
* removed unnecessary CLASS_NAME and NEEDS_INDICATIONS
* made `handlers` option explicit instead of using
`default_driver_args`
* fixed `xtest*` typos
Diffs
-----
src/account/test/TestIndicationEventStream.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/1759/diff/
Testing
-------
Thanks,
Alois Mahdal
9 years, 10 months
Review Request 430: openlmi-locale [1/1] New provider: Locale
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
New provider: Locale
Diffs
-----
CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e
README a80a1d2624c80367ed53e06f50804ed39b3103da
mof/60_LMI_Locale.mof PRE-CREATION
openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89
src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b
src/locale/CMakeLists.txt PRE-CREATION
src/locale/LMI_LocaleProvider.c PRE-CREATION
src/locale/localed.h PRE-CREATION
src/locale/localed.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
Testing
-------
Thanks,
Vitezslav Crhonek
9 years, 10 months