May 2014 - openlmi-reviews - Fedora Mailing-Lists

Review Request 1737: PEP8, Flake8, readability improvements

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1737/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- PEP8, Flake8, readability improvements Diffs ----- src/python/lmi/test/util.py 699507c2340e9a50ff22ce08b67fe3e0a3f9eef8 Diff: http://reviewboard-openlmi.rhcloud.com/r/1737/diff/ Testing ------- Thanks, Alois Mahdal

9 years, 11 months

1
3
0 / 0

Review Request 1747: providers [1/2] Software: don't fail when logging.config doesn't have dictConfig

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1747/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Software: don't fail when logging.config doesn't have dictConfig python 2.6 doesn't have logging.config.dictConfig, skip the logging configuration in that case. Diffs ----- src/software/lmi/software/yumdb/util.py 2c67a15847a1dcc42b94c40f4d4e0660c1a751d8 Diff: http://reviewboard-openlmi.rhcloud.com/r/1747/diff/ Testing ------- Thanks, Radek Novacek

9 years, 11 months

1
2
0 / 0

Review Request 1746: providers [2/2] test base: use service instead of systemctl command

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1746/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- test base: use service instead of systemctl command service command is compatible even with non-systemd distribution and still works with systemd. Diffs ----- src/python/lmi/test/cimbase.py 4582d8eb03a059bd8a15c5787c8a8fc794c72d58 Diff: http://reviewboard-openlmi.rhcloud.com/r/1746/diff/ Testing ------- Thanks, Radek Novacek

9 years, 11 months

1
2
0 / 0

Review Request 1748: providers [2/2] spec: use proper python sitelib in LMI_Software.reg file

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1748/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- spec: use proper python sitelib in LMI_Software.reg file Diffs ----- openlmi-providers.spec 624ba7711a0836f37143cb16187ff548a647328f Diff: http://reviewboard-openlmi.rhcloud.com/r/1748/diff/ Testing ------- Thanks, Radek Novacek

9 years, 11 months

1
2
0 / 0

Review Request 1745: providers [1/2] LogicalFile: simulate subprocess check_output on python 2.6

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1745/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- LogicalFile: simulate subprocess check_output on python 2.6 Python 2.6 doesn't have subprocess.check_output function, we'll simulate it using subprocess.Popen. Diffs ----- src/logicalfile/test/test_basic.py 3577ee29db0a58ebd30e980f9084bec255c31e65 Diff: http://reviewboard-openlmi.rhcloud.com/r/1745/diff/ Testing ------- Thanks, Radek Novacek

9 years, 11 months

1
2
0 / 0

Review Request 1512: Account: Race conditions fixes (like: bz#1061150)

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1512/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- This patch solves: * Avoid race conditions with shadow-utils. * Avoid race condition with libuser: uid/gid "sharing" amoung users/groups. * Fix deadlock in lock.c code. This patch introduces giant lock which is held for all write operations. Diffs ----- src/account/LMI_AccountManagementServiceProvider.c d4e51d55e259c582c4e145fcd45191aec6e484b1 src/account/LMI_AccountProvider.c fa2e3165f79844d4fac908ce344a69d735f6150d src/account/LMI_GroupProvider.c efdbad53c57c102a9c6e760da968773e9aa2bf60 src/account/lock.h ab5827bb543ad35e4ab25e7e3edc84f5c416e1fc src/account/lock.c b18b87dd11c42923699d53e409460aeb7b4a996a Diff: http://reviewboard-openlmi.rhcloud.com/r/1512/diff/ Testing ------- Thanks, Robin Hack

9 years, 11 months

1
9
0 / 0

Review Request 1736: Clean up imports in common

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1736/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Clean up imports in common Just some leftover imports and comments not needed anymore Diffs ----- src/account/test/common.py 95abd381089506c3f9b4d6632f2303da322fa585 Diff: http://reviewboard-openlmi.rhcloud.com/r/1736/diff/ Testing ------- Thanks, Alois Mahdal

9 years, 11 months

1
2
0 / 0

Review Request 1735: Add utility classes for indication testing

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1735/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Add utility classes for indication testing Diffs ----- src/account/test/common.py 95abd381089506c3f9b4d6632f2303da322fa585 src/python/lmi/test/util.py 699507c2340e9a50ff22ce08b67fe3e0a3f9eef8 Diff: http://reviewboard-openlmi.rhcloud.com/r/1735/diff/ Testing ------- Thanks, Alois Mahdal

9 years, 11 months

1
2
0 / 0

Review Request 1684: Move dangling functions to common.UserOps

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1684/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Since they have much in common, I am moving them under UserOps static class. This allows for better flexibility and readability. Diffs ----- src/account/test/TestAccount.py 31c3a96a2e31262904afec092baa30a839340776 src/account/test/TestAccountRaceConditions.py cd13d6179125f4f73ff87198743c6d59af517ef9 src/account/test/TestGroup.py 4a7fc6d1e3b2fb4ce966d08d462f08b0b86c9d8e src/account/test/TestIndications.py 7861eede69433662c4b178671ff53b2e2346a54e src/account/test/TestMemberOfGroup.py 0c74dff7f2e85da553b879971f8e44c1079766d0 src/account/test/TestService.py f62d1cf0c850c60f5d12a9b0a2acc4cbffddb1d1 src/account/test/common.py 639fb6113991a6c9e37e3985da335345ce5b313f src/account/test/methods.py 9659d4f91f69a38194ebdf1dd367ae36c64e96a7 Diff: http://reviewboard-openlmi.rhcloud.com/r/1684/diff/ Testing ------- Thanks, Alois Mahdal

9 years, 11 months

1
2
0 / 0

Review Request 1700: account: Make LMI_MemberOfGroup.CreateInstance() more robust

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1700/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- Return proper error when required properties are not set. https://fedorahosted.org/openlmi/ticket/270 Diffs ----- src/account/LMI_MemberOfGroupProvider.c 4928f4d0e3d085f7d4387838803918fd32a50b17 Diff: http://reviewboard-openlmi.rhcloud.com/r/1700/diff/ Testing ------- Thanks, Tomáš Bžatek

9 years, 11 months

1
4
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

openlmi-reviews May 2014