Review Request 1528: Added tests for race conditions
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1528/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Added tests for race conditions. Based on bug 1061153, these tests attempt to create, modify or delete users from a number of threads. Tests clean up by reverting backup of /etc/passwd, /etc/groups, /etc/shadow and /etc/gshadow.
New classes are added that might be useful in future (maybe even elsewhere): BackupStorage to backup system files, Passwd to assess if /etc/passwd is corrupted.
Diffs
-----
src/account/test/TestAccountRaceConditions.py PRE-CREATION
src/account/test/common.py 1476d107a916e9ee47595e4bd39041445b9d8450
src/account/test/methods.py ffb9f7d9335e8082bba4ee65baa103a9651682a3
Diff: http://reviewboard-openlmi.rhcloud.com/r/1528/diff/
Testing
-------
Thanks,
Alois Mahdal
10 years
Review Request 1692: Hardware: spring cleanup & refactor
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1692/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
* use openlmi common library where possible
* get rid of LMI_Hardware.h file
* some other cosmetic changes
Diffs
-----
src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c 23cf5cd34d2cf92918b6f9ef16464f52a3a2d0ca
src/hardware/LMI_BaseboardContainerProvider.c 1ac1ff21f002c1721d67302f30b1001e0e07d14e
src/hardware/LMI_BaseboardProvider.c cb3622f938f98b476ef7fb4a29f1e420c7270b8b
src/hardware/LMI_BatteryPhysicalPackageProvider.c 7ff67da1a49bed77a2a8b3b44598610bc2e95f4b
src/hardware/LMI_BatteryProvider.c 0907bbc9702358d1ec9ce56472f02ec85e200070
src/hardware/LMI_BatterySystemDeviceProvider.c c3d465cc8203f109ae69892e15a39773b05e3330
src/hardware/LMI_ChassisComputerSystemPackageProvider.c e95dc83ff888e3228be28381818191bf61bc85e8
src/hardware/LMI_ChassisProvider.c d5ad7890925d3ada0f1a3641428caab74ac9f4b0
src/hardware/LMI_DiskDriveATAPortProvider.c 626d5f27d9255a924fad6cb1a2972da579b03e4d
src/hardware/LMI_DiskDriveATAProtocolEndpointProvider.c c7525d46e6cb6be93924b62c226e00d673b8e918
src/hardware/LMI_DiskDriveDeviceSAPImplementationProvider.c 5b2c186d031cacee3b3bc597ec5ac16e652c82f6
src/hardware/LMI_DiskDriveElementSoftwareIdentityProvider.c cf599be073d3abbd1af11bfbf9b7767b2bd7407e
src/hardware/LMI_DiskDriveProvider.c 21e5b18e330d7026e46c12b384ffff5ce7296e17
src/hardware/LMI_DiskDriveRealizesProvider.c 5d184e92ceb66906c8c95d30d347296bfd80ac1e
src/hardware/LMI_DiskDriveSAPAvailableForElementProvider.c be68c872434712afb6d847717ec7bb5a43c5f79c
src/hardware/LMI_DiskDriveSoftwareIdentityProvider.c 34043fa24d9738f00110edc7e6820fa5640a8d62
src/hardware/LMI_DiskDriveSystemDeviceProvider.c fd27b911001f83dc8e8845f2e673935f844ea1d3
src/hardware/LMI_DiskPhysicalPackageContainerProvider.c 48e390a9912869bd1355622b15f5fa487bde2f13
src/hardware/LMI_DiskPhysicalPackageProvider.c f619e0b98ccb423e2527f50c890001ac5313d243
src/hardware/LMI_Hardware.h db4d5898806b2620e4b4b911823d3550fbad5c3e
src/hardware/LMI_MemoryPhysicalPackageInConnectorProvider.c 04d4384e40c75fc1c3d59ad4485ebfd0ac4009c6
src/hardware/LMI_MemoryPhysicalPackageProvider.c e277fc1235f22ab578b2f9957e37234f04d2a1b1
src/hardware/LMI_MemoryProvider.c bea9bf24a18d2c886d620f057bdab9f2cacc2602
src/hardware/LMI_MemorySlotContainerProvider.c 885295485c5469749e59d2fc43a7e8c8252cc59f
src/hardware/LMI_MemorySlotProvider.c 2c8116f7ac8e7ed5532e2cb4f9ab315ab7285da9
src/hardware/LMI_MemorySystemDeviceProvider.c 0f79ab75263493ee4f216fe5045d6f56b9a6b445
src/hardware/LMI_PCIBridgeProvider.c 98631869fe76109e4be46053a99d2d7ab1951cce
src/hardware/LMI_PCIBridgeSystemDeviceProvider.c 6618d08064b713d4f56d683f47dc7c25ac9a7bae
src/hardware/LMI_PCIDeviceProvider.c edb15280ca6f2013eacb146144f83c851b8bec56
src/hardware/LMI_PCIDeviceSystemDeviceProvider.c 84279c8142ef076c10d251a16fdb07464804c374
src/hardware/LMI_PhysicalBatteryContainerProvider.c 57985e92f773315a5120819482b7a60ad220eb6c
src/hardware/LMI_PhysicalBatteryRealizesProvider.c a9d1f1638bd233ae43af9b38490a3d2a38824162
src/hardware/LMI_PhysicalMemoryContainerProvider.c bff9955fab9d0782f427abe3ca7dcec2fa56ffc8
src/hardware/LMI_PhysicalMemoryProvider.c b7dc9a77ddffa429f7dbafbc90f242418c7d9910
src/hardware/LMI_PhysicalMemoryRealizesProvider.c 4f44db77da849bd266120488e962ab882e588930
src/hardware/LMI_PointingDeviceProvider.c 1999a004b0967b135339a4c2ecdaecd78adbaf42
src/hardware/LMI_PortPhysicalConnectorContainerProvider.c 591fdcc6b0d05192430f311b5c43ae2a686def55
src/hardware/LMI_PortPhysicalConnectorProvider.c 9f2cac2c3130bf1dc463a64503edf06430de5ded
src/hardware/LMI_ProcessorCacheMemoryProvider.c 92c3a91047ad90e4f907855b8c9af24dc9ce1d91
src/hardware/LMI_ProcessorCapabilitiesProvider.c c1255418459000972438bf4d736621e5b56b623f
src/hardware/LMI_ProcessorChipContainerProvider.c 0c2f646eacbd9e4bb249e806c0587db7f5093d78
src/hardware/LMI_ProcessorChipProvider.c d3a2d14352982c9d93b5eab2a1624108eef214b0
src/hardware/LMI_ProcessorChipRealizesProvider.c dc50b8dc9765a3c2bc521385540afc935e575be5
src/hardware/LMI_ProcessorElementCapabilitiesProvider.c aa8ed68a997b01382aa53593a4bd8db9891e1fb0
src/hardware/LMI_ProcessorProvider.c a2a0dc722b07076fc989fd17dd7227c60d2c0b3e
src/hardware/LMI_ProcessorSystemDeviceProvider.c 8bf8e3d719aabc6a5db6d29baeefd0773d809707
src/hardware/LMI_SystemSlotContainerProvider.c 16139cb0c5a938c7f87d912de1d32d06cd98449f
src/hardware/LMI_SystemSlotProvider.c 730c24218771ae0033db4fa17c190ddaf295d590
src/hardware/PCIDev.h 7a7f93693ebbeabb505f72fca3ee1fbd653c3503
src/hardware/dmidecode.h 5e7cb4a6e1f3c9520482367003cc7e264f1d29ff
src/hardware/dmidecode.c 69afbc43eb7edc0894c8c5251345232201867cd3
src/hardware/lsblk.h bb5cccfcd58b29fc2b8cc038fe96039709298778
src/hardware/lscpu.h 5526e885c191c74219202170b6621a558d77426d
src/hardware/lscpu.c 3407ceacee39b472fbe1471a975d6dea064ba7b3
src/hardware/procfs.h b0a71748517e1a01a9e864b5e9a8dcd0af2ac11d
src/hardware/procfs.c 71c3c633ebf649eba0e31bc623d4104b5dfb822e
src/hardware/smartctl.h 594f218cd4f5b614106755d06a1e82a5d132b6bd
src/hardware/sysfs.h 2714e2bed4bdf43521a6ec8c5d85ae7a283fc2e6
src/hardware/sysfs.c 1e8de8439baaaa4ccd501faa5cc656bc21893299
src/hardware/test/test.sh PRE-CREATION
src/hardware/utils.h 91dfdf55095d45a7b3f5d4a2fc1b38b77758b09b
src/hardware/utils.c 1fa65948155aa4c17f398913b4aa253d5893be3f
src/hardware/virt_what.h b133136cc6a48aa501c62477231f2a723df04f17
src/hardware/virt_what.c 83fc3d8889c6cd773f91dccc39fe340d987e83d5
Diff: http://reviewboard-openlmi.rhcloud.com/r/1692/diff/
Testing
-------
Thanks,
Peter Schiffer
10 years
Re: Review Request 1692: Hardware: spring cleanup & refactor
by Stephen Gallagher
> On May 12, 2014, 2:43 p.m., Jan Synacek wrote:
> > src/hardware/test/test.sh, lines 1-12
> > <http://reviewboard-openlmi.rhcloud.com/r/1692/diff/1/?file=9698#file9698l...>
> >
> > Was this change intentional? If yes, I would substitute the hardcoded paths with something like "$(pwd)/<tests>".
Thanks! This file shouldn't be there...
- Peter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1692/#review2605
-----------------------------------------------------------
On May 12, 2014, 7:25 p.m., Peter Schiffer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1692/
> -----------------------------------------------------------
>
> (Updated May 12, 2014, 7:25 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> * use openlmi common library where possible
> * get rid of LMI_Hardware.h file
> * some other cosmetic changes
>
>
> Diffs
> -----
>
> src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c 23cf5cd34d2cf92918b6f9ef16464f52a3a2d0ca
> src/hardware/LMI_BaseboardContainerProvider.c 1ac1ff21f002c1721d67302f30b1001e0e07d14e
> src/hardware/LMI_BaseboardProvider.c cb3622f938f98b476ef7fb4a29f1e420c7270b8b
> src/hardware/LMI_BatteryPhysicalPackageProvider.c 7ff67da1a49bed77a2a8b3b44598610bc2e95f4b
> src/hardware/LMI_BatteryProvider.c 0907bbc9702358d1ec9ce56472f02ec85e200070
> src/hardware/LMI_BatterySystemDeviceProvider.c c3d465cc8203f109ae69892e15a39773b05e3330
> src/hardware/LMI_ChassisComputerSystemPackageProvider.c e95dc83ff888e3228be28381818191bf61bc85e8
> src/hardware/LMI_ChassisProvider.c d5ad7890925d3ada0f1a3641428caab74ac9f4b0
> src/hardware/LMI_DiskDriveATAPortProvider.c 626d5f27d9255a924fad6cb1a2972da579b03e4d
> src/hardware/LMI_DiskDriveATAProtocolEndpointProvider.c c7525d46e6cb6be93924b62c226e00d673b8e918
> src/hardware/LMI_DiskDriveDeviceSAPImplementationProvider.c 5b2c186d031cacee3b3bc597ec5ac16e652c82f6
> src/hardware/LMI_DiskDriveElementSoftwareIdentityProvider.c cf599be073d3abbd1af11bfbf9b7767b2bd7407e
> src/hardware/LMI_DiskDriveProvider.c 21e5b18e330d7026e46c12b384ffff5ce7296e17
> src/hardware/LMI_DiskDriveRealizesProvider.c 5d184e92ceb66906c8c95d30d347296bfd80ac1e
> src/hardware/LMI_DiskDriveSAPAvailableForElementProvider.c be68c872434712afb6d847717ec7bb5a43c5f79c
> src/hardware/LMI_DiskDriveSoftwareIdentityProvider.c 34043fa24d9738f00110edc7e6820fa5640a8d62
> src/hardware/LMI_DiskDriveSystemDeviceProvider.c fd27b911001f83dc8e8845f2e673935f844ea1d3
> src/hardware/LMI_DiskPhysicalPackageContainerProvider.c 48e390a9912869bd1355622b15f5fa487bde2f13
> src/hardware/LMI_DiskPhysicalPackageProvider.c f619e0b98ccb423e2527f50c890001ac5313d243
> src/hardware/LMI_Hardware.h db4d5898806b2620e4b4b911823d3550fbad5c3e
> src/hardware/LMI_MemoryPhysicalPackageInConnectorProvider.c 04d4384e40c75fc1c3d59ad4485ebfd0ac4009c6
> src/hardware/LMI_MemoryPhysicalPackageProvider.c e277fc1235f22ab578b2f9957e37234f04d2a1b1
> src/hardware/LMI_MemoryProvider.c bea9bf24a18d2c886d620f057bdab9f2cacc2602
> src/hardware/LMI_MemorySlotContainerProvider.c 885295485c5469749e59d2fc43a7e8c8252cc59f
> src/hardware/LMI_MemorySlotProvider.c 2c8116f7ac8e7ed5532e2cb4f9ab315ab7285da9
> src/hardware/LMI_MemorySystemDeviceProvider.c 0f79ab75263493ee4f216fe5045d6f56b9a6b445
> src/hardware/LMI_PCIBridgeProvider.c 98631869fe76109e4be46053a99d2d7ab1951cce
> src/hardware/LMI_PCIBridgeSystemDeviceProvider.c 6618d08064b713d4f56d683f47dc7c25ac9a7bae
> src/hardware/LMI_PCIDeviceProvider.c edb15280ca6f2013eacb146144f83c851b8bec56
> src/hardware/LMI_PCIDeviceSystemDeviceProvider.c 84279c8142ef076c10d251a16fdb07464804c374
> src/hardware/LMI_PhysicalBatteryContainerProvider.c 57985e92f773315a5120819482b7a60ad220eb6c
> src/hardware/LMI_PhysicalBatteryRealizesProvider.c a9d1f1638bd233ae43af9b38490a3d2a38824162
> src/hardware/LMI_PhysicalMemoryContainerProvider.c bff9955fab9d0782f427abe3ca7dcec2fa56ffc8
> src/hardware/LMI_PhysicalMemoryProvider.c b7dc9a77ddffa429f7dbafbc90f242418c7d9910
> src/hardware/LMI_PhysicalMemoryRealizesProvider.c 4f44db77da849bd266120488e962ab882e588930
> src/hardware/LMI_PointingDeviceProvider.c 1999a004b0967b135339a4c2ecdaecd78adbaf42
> src/hardware/LMI_PortPhysicalConnectorContainerProvider.c 591fdcc6b0d05192430f311b5c43ae2a686def55
> src/hardware/LMI_PortPhysicalConnectorProvider.c 9f2cac2c3130bf1dc463a64503edf06430de5ded
> src/hardware/LMI_ProcessorCacheMemoryProvider.c 92c3a91047ad90e4f907855b8c9af24dc9ce1d91
> src/hardware/LMI_ProcessorCapabilitiesProvider.c c1255418459000972438bf4d736621e5b56b623f
> src/hardware/LMI_ProcessorChipContainerProvider.c 0c2f646eacbd9e4bb249e806c0587db7f5093d78
> src/hardware/LMI_ProcessorChipProvider.c d3a2d14352982c9d93b5eab2a1624108eef214b0
> src/hardware/LMI_ProcessorChipRealizesProvider.c dc50b8dc9765a3c2bc521385540afc935e575be5
> src/hardware/LMI_ProcessorElementCapabilitiesProvider.c aa8ed68a997b01382aa53593a4bd8db9891e1fb0
> src/hardware/LMI_ProcessorProvider.c a2a0dc722b07076fc989fd17dd7227c60d2c0b3e
> src/hardware/LMI_ProcessorSystemDeviceProvider.c 8bf8e3d719aabc6a5db6d29baeefd0773d809707
> src/hardware/LMI_SystemSlotContainerProvider.c 16139cb0c5a938c7f87d912de1d32d06cd98449f
> src/hardware/LMI_SystemSlotProvider.c 730c24218771ae0033db4fa17c190ddaf295d590
> src/hardware/PCIDev.h 7a7f93693ebbeabb505f72fca3ee1fbd653c3503
> src/hardware/dmidecode.h 5e7cb4a6e1f3c9520482367003cc7e264f1d29ff
> src/hardware/dmidecode.c 69afbc43eb7edc0894c8c5251345232201867cd3
> src/hardware/lsblk.h bb5cccfcd58b29fc2b8cc038fe96039709298778
> src/hardware/lscpu.h 5526e885c191c74219202170b6621a558d77426d
> src/hardware/lscpu.c 3407ceacee39b472fbe1471a975d6dea064ba7b3
> src/hardware/procfs.h b0a71748517e1a01a9e864b5e9a8dcd0af2ac11d
> src/hardware/procfs.c 71c3c633ebf649eba0e31bc623d4104b5dfb822e
> src/hardware/smartctl.h 594f218cd4f5b614106755d06a1e82a5d132b6bd
> src/hardware/sysfs.h 2714e2bed4bdf43521a6ec8c5d85ae7a283fc2e6
> src/hardware/sysfs.c 1e8de8439baaaa4ccd501faa5cc656bc21893299
> src/hardware/utils.h 91dfdf55095d45a7b3f5d4a2fc1b38b77758b09b
> src/hardware/utils.c 1fa65948155aa4c17f398913b4aa253d5893be3f
> src/hardware/virt_what.h b133136cc6a48aa501c62477231f2a723df04f17
> src/hardware/virt_what.c 83fc3d8889c6cd773f91dccc39fe340d987e83d5
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1692/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Peter Schiffer
>
>
10 years