Review Request 1689: providers [1/1] account: use defaultdict instead of Counter

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1689/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

account: use defaultdict instead of Counter

Counter is not present in python <= 2.6, so replace it with defaultdict.


Diffs
-----

  src/account/test/common.py 639fb6113991a6c9e37e3985da335345ce5b313f 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1689/diff/


Testing
-------


Thanks,

Radek Novacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1689/#review2599
-----------------------------------------------------------

Ship it!


Not a Python expert but it seems it's running fine.

- Tomáš Bžatek


On May 9, 2014, 12:27 p.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1689/
>  -----------------------------------------------------------
>  
>  (Updated May 9, 2014, 12:27 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  account: use defaultdict instead of Counter
>  
>  Counter is not present in python <= 2.6, so replace it with defaultdict.
>  
>  
>  Diffs
>  -----
>  
>    src/account/test/common.py 639fb6113991a6c9e37e3985da335345ce5b313f 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1689/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1689/
-----------------------------------------------------------

(Updated May 13, 2014, 8:36 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

account: use defaultdict instead of Counter

Counter is not present in python <= 2.6, so replace it with defaultdict.


Diffs
-----

  src/account/test/common.py 639fb6113991a6c9e37e3985da335345ce5b313f 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1689/diff/


Testing
-------


Thanks,

Radek Novacek