Review Request 1745: providers [1/2] LogicalFile: simulate subprocess check_output on python 2.6

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1745/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

LogicalFile: simulate subprocess check_output on python 2.6

Python 2.6 doesn't have subprocess.check_output function, we'll simulate
it using subprocess.Popen.


Diffs
-----

  src/logicalfile/test/test_basic.py 3577ee29db0a58ebd30e980f9084bec255c31e65 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1745/diff/


Testing
-------


Thanks,

Radek Novacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1745/#review2636
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Synacek


On May 15, 2014, 10:58 a.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1745/
>  -----------------------------------------------------------
>  
>  (Updated May 15, 2014, 10:58 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  LogicalFile: simulate subprocess check_output on python 2.6
>  
>  Python 2.6 doesn't have subprocess.check_output function, we'll simulate
>  it using subprocess.Popen.
>  
>  
>  Diffs
>  -----
>  
>    src/logicalfile/test/test_basic.py 3577ee29db0a58ebd30e980f9084bec255c31e65 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1745/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1745/
-----------------------------------------------------------

(Updated May 19, 2014, 10:18 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

LogicalFile: simulate subprocess check_output on python 2.6

Python 2.6 doesn't have subprocess.check_output function, we'll simulate
it using subprocess.Popen.


Diffs
-----

  src/logicalfile/test/test_basic.py 3577ee29db0a58ebd30e980f9084bec255c31e65 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1745/diff/


Testing
-------


Thanks,

Radek Novacek