Review Request 1571: [1/1] Explicitly add LVM devices to list of blivet devices.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1571/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Explicitly add LVM devices to list of blivet devices.

Blivet doesn't contain VGs or LVs anymore. Work around that issue.


Diffs
-----

  src/lmi/storage/util/storage.py ff6da1be1eaf2c0098bb465ac711d1e8454dc77a 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1571/diff/


Testing
-------


Thanks,

Jan Synacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1571/#review2429
-----------------------------------------------------------


I would wait if blivet fixes this behavior, have you talked to dlehman if he's going
to do something about it?

- Jan Safranek


On April 2, 2014, 10:15 a.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1571/
>  -----------------------------------------------------------
>  
>  (Updated April 2, 2014, 10:15 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Explicitly add LVM devices to list of blivet devices.
>  
>  Blivet doesn't contain VGs or LVs anymore. Work around that issue.
>  
>  
>  Diffs
>  -----
>  
>    src/lmi/storage/util/storage.py ff6da1be1eaf2c0098bb465ac711d1e8454dc77a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1571/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On April 4, 2014, 9:51 a.m., Jan Safranek wrote:
>  > I would wait if blivet fixes this behavior, have you talked to dlehman if he's
> going to do something about it? 
I agree to wait. I only filed https://bugzilla.redhat.com/show_bug.cgi?id=1083403.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1571/#review2429
-----------------------------------------------------------


On April 2, 2014, 10:15 a.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1571/
>  -----------------------------------------------------------
>  
>  (Updated April 2, 2014, 10:15 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Explicitly add LVM devices to list of blivet devices.
>  
>  Blivet doesn't contain VGs or LVs anymore. Work around that issue.
>  
>  
>  Diffs
>  -----
>  
>    src/lmi/storage/util/storage.py ff6da1be1eaf2c0098bb465ac711d1e8454dc77a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1571/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

>  On April 4, 2014, 9:51 a.m., Jan Safranek wrote:
>  > I would wait if blivet fixes this behavior, have you talked to dlehman if he's
> going to do something about it?
>  
>  Jan Synacek wrote:
>      I agree to wait. I only filed https://bugzilla.redhat.com/show_bug.cgi?id=1083403.
Bug 1083403 appears to be fixed now. Discarding this review.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1571/#review2429
-----------------------------------------------------------


On April 2, 2014, 10:15 a.m., Jan Synacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1571/
>  -----------------------------------------------------------
>  
>  (Updated April 2, 2014, 10:15 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-storage
>  
>  
>  Description
>  -------
>  
>  Explicitly add LVM devices to list of blivet devices.
>  
>  Blivet doesn't contain VGs or LVs anymore. Work around that issue.
>  
>  
>  Diffs
>  -----
>  
>    src/lmi/storage/util/storage.py ff6da1be1eaf2c0098bb465ac711d1e8454dc77a 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1571/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Jan Synacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1571/
-----------------------------------------------------------

(Updated Sept. 1, 2014, 9:31 a.m.)


Status
------

This change has been discarded.


Review request for OpenLMI Developers.


Repository: openlmi-storage


Description
-------

Explicitly add LVM devices to list of blivet devices.

Blivet doesn't contain VGs or LVs anymore. Work around that issue.


Diffs
-----

  src/lmi/storage/util/storage.py ff6da1be1eaf2c0098bb465ac711d1e8454dc77a 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1571/diff/


Testing
-------


Thanks,

Jan Synacek