Review Request 430: openlmi-locale [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

New provider: Locale


Diffs
-----

  CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e 
  README a80a1d2624c80367ed53e06f50804ed39b3103da 
  mof/60_LMI_Locale.mof PRE-CREATION 
  openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89 
  src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b 
  src/locale/CMakeLists.txt PRE-CREATION 
  src/locale/LMI_LocaleProvider.c PRE-CREATION 
  src/locale/localed.h PRE-CREATION 
  src/locale/localed.c PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/


Testing
-------


Thanks,

Vitezslav Crhonek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review513
-----------------------------------------------------------



src/locale/localed.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment308>

    It's not necessary to check for NULL. free(NULL) is NOP. Maybe rather check
if(clock), if clock isn't NULL.


- Roman Rakus


On June 3, 2013, 12:01 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 3, 2013, 12:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e 
>    README a80a1d2624c80367ed53e06f50804ed39b3103da 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89 
>    src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review514
-----------------------------------------------------------



mof/60_LMI_Locale.mof
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment311>

    I don't like this API much, wouldn't it be better to have this values as
properties of the object and let user modify them via ModifyInstance method?
    



mof/60_LMI_Locale.mof
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment310>

    Why is this comment here if it's not used?



src/locale/LMI_LocaleProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment309>

    Why is this line here twice?


- Radek Novacek


On June 3, 2013, 2:01 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 3, 2013, 2:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e 
>    README a80a1d2624c80367ed53e06f50804ed39b3103da 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89 
>    src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

>  On June 6, 2013, 9:02 a.m., Radek Novacek wrote:
>  > mof/60_LMI_Locale.mof, lines 64-71
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/430/diff/1/?file=2559#file2559li...
>  >
>  >     I don't like this API much, wouldn't it be better to have this values as
> properties of the object and let user modify them via ModifyInstance method?
>  > 
+1 to wrong API. There should be Setting attached to something (Linux_OperatingSystem?)
and LMI_LocaleService, which would switch current setting with a new one. Also, is there a
possibility to get list of all supported locales? It would be nice to have
LocaleCapabilities, which would list valid settings.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review514
-----------------------------------------------------------


On June 3, 2013, 2:01 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 3, 2013, 2:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e 
>    README a80a1d2624c80367ed53e06f50804ed39b3103da 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89 
>    src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

>  On June 6, 2013, 9:02 a.m., Radek Novacek wrote:
>  > mof/60_LMI_Locale.mof, lines 64-71
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/430/diff/1/?file=2559#file2559li...
>  >
>  >     I don't like this API much, wouldn't it be better to have this values as
> properties of the object and let user modify them via ModifyInstance method?
>  >
>  
>  Jan Safranek wrote:
>      +1 to wrong API. There should be Setting attached to something
> (Linux_OperatingSystem?) and LMI_LocaleService, which would switch current setting with a
> new one. Also, is there a possibility to get list of all supported locales? It would be
> nice to have LocaleCapabilities, which would list valid settings.
>  
+1 to wrong API. There should be Setting attached to something (Linux_OperatingSystem?)
and LMI_LocaleService, which would switch current setting with a new one. Also, is there a
possibility to get list of all supported locales? It would be nice to have
LocaleCapabilities, which would list valid settings.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review514
-----------------------------------------------------------


On June 3, 2013, 2:01 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 3, 2013, 2:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e 
>    README a80a1d2624c80367ed53e06f50804ed39b3103da 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89 
>    src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

>  On June 6, 2013, 9:02 a.m., Radek Novacek wrote:
>  > mof/60_LMI_Locale.mof, lines 64-71
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/430/diff/1/?file=2559#file2559li...
>  >
>  >     I don't like this API much, wouldn't it be better to have this values as
> properties of the object and let user modify them via ModifyInstance method?
>  >
>  
>  Jan Safranek wrote:
>      +1 to wrong API. There should be Setting attached to something
> (Linux_OperatingSystem?) and LMI_LocaleService, which would switch current setting with a
> new one. Also, is there a possibility to get list of all supported locales? It would be
> nice to have LocaleCapabilities, which would list valid settings.
>
>  
>  Jan Safranek wrote:
>      +1 to wrong API. There should be Setting attached to something
> (Linux_OperatingSystem?) and LMI_LocaleService, which would switch current setting with a
> new one. Also, is there a possibility to get list of all supported locales? It would be
> nice to have LocaleCapabilities, which would list valid settings. 
Discard my comment here, modelling DBus service is a valid way to go. However, we should
explicitly describe all parameters and properties, as other review comments suggest.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review514
-----------------------------------------------------------


On Sept. 10, 2013, 12:34 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 12:34 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e 
>    README a80a1d2624c80367ed53e06f50804ed39b3103da 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89 
>    src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------

(Updated Sept. 10, 2013, 10:34 a.m.)


Status
------

This change has been discarded.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

New provider: Locale


Diffs
-----

  CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e 
  README a80a1d2624c80367ed53e06f50804ed39b3103da 
  mof/60_LMI_Locale.mof PRE-CREATION 
  openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89 
  src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b 
  src/locale/CMakeLists.txt PRE-CREATION 
  src/locale/LMI_LocaleProvider.c PRE-CREATION 
  src/locale/localed.h PRE-CREATION 
  src/locale/localed.c PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/


Testing
-------


Thanks,

Vitezslav Crhonek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2611
-----------------------------------------------------------


Ok, if we base the model on systemd-localed API, the API concept is not that bad.
Unfortunately, what may be good enough for DBus service is not good enough for supported
remote API. We need better descriptions of all properties and method parameters. Most of
them are just 'string', without any clue, what are possible/allowed values and
where to get more docs.

Link to authoritative documentation might be enough here, if there _is_ such documentation
in the first place.


mof/60_LMI_Locale.mof
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1425>

    I really don't like magic array of strings, individual properties would be much
better.



mof/60_LMI_Locale.mof
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1424>

    What values it can have? What is format of this string?
    
    (this applies to all string properties)



mof/60_LMI_Locale.mof
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1426>

    use individual parameters instead of list of list of strings.



mof/60_LMI_Locale.mof
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1427>

    What are expected values of the parameter?
    
    (this applies to all string parameters)


- Jan Safranek


On Sept. 10, 2013, 12:34 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 12:34 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e 
>    README a80a1d2624c80367ed53e06f50804ed39b3103da 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89 
>    src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] Locale: MOF

[Stephen Gallagher]

>  On May 13, 2014, 3:22 p.m., Jan Safranek wrote:
>  > mof/60_LMI_Locale.mof, line 38
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/430/diff/1/?file=2559#file2559li...
>  >
>  >     What values it can have? What is format of this string?
>  >     
>  >     (this applies to all string properties) 
I added few examples to Description of string properties/parameters. All possible values
are available through "localectl list- ..." commands. But there's still
option to add similar methods to the provider. Unfortunately, systemd-localed DBus API
doesn't export this functionality, so it probably has to call "localectl"
directly.


- Vitezslav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2611
-----------------------------------------------------------


On May 19, 2014, 11:23 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated May 19, 2014, 11:23 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Locale: MOF
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Locale.mof PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] Locale: MOF

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------

(Updated May 19, 2014, 11:23 a.m.)


Review request for OpenLMI Developers.


Summary (updated)
-----------------

 [1/1] Locale: MOF


Repository: openlmi-providers


Description (updated)
-------

Locale: MOF


Diffs (updated)
-----

  mof/60_LMI_Locale.mof PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/


Testing
-------


Thanks,

Vitezslav Crhonek

Review Request 430: [1/1] Locale: MOF

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2652
-----------------------------------------------------------


The MOF file is now much better, thanks. On the other hand, I think you forgot to update
the .c files appropriately :).


mof/60_LMI_Locale.mof
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1471>

    The name suggests there can be more than one option. How are they separated?



src/locale/LMI_LocaleProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1474>

    missing error check



src/locale/LMI_LocaleProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1472>

    This looks like it's for the older MOF file, we now have individual properties for
these.



src/locale/LMI_LocaleProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1473>

    I think the API is different in the new MOF file.


- Jan Safranek


On May 19, 2014, 1:23 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated May 19, 2014, 1:23 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Locale: MOF
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Locale.mof PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] Locale: MOF

[Stephen Gallagher]

>  On May 19, 2014, 2:06 p.m., Jan Safranek wrote:
>  > The MOF file is now much better, thanks. On the other hand, I think you forgot to
> update the .c files appropriately :). 
That's intentional - I want to be sure the model is 'correct' and
'final' before I start modifying .c files... Stay tuned:)


>  On May 19, 2014, 2:06 p.m., Jan Safranek wrote:
>  > mof/60_LMI_Locale.mof, line 165
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/430/diff/1-2/?file=2559#file2559...
>  >
>  >     The name suggests there can be more than one option. How are they separated?
Good point. They're comma separated. I'll update the description accordingly.
Actually, it's also possible to set more than one layout in the same way, so it makes
sense also renaming 'string X11Layout;' to 'string X11Layouts;' and
document that fact too.


- Vitezslav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2652
-----------------------------------------------------------


On May 19, 2014, 11:23 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated May 19, 2014, 11:23 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Locale: MOF
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Locale.mof PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] Locale: MOF

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------

(Updated May 20, 2014, 11:30 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Locale: MOF


Diffs (updated)
-----

  mof/60_LMI_Locale.mof PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/


Testing
-------


Thanks,

Vitezslav Crhonek

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------

(Updated May 29, 2014, 7:12 a.m.)


Review request for OpenLMI Developers.


Summary (updated)
-----------------

 [1/1] New provider: Locale


Repository: openlmi-providers


Description (updated)
-------

New provider: Locale


Diffs (updated)
-----

  CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
  README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
  mof/60_LMI_Locale.mof PRE-CREATION 
  mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
  openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
  src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
  src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
  src/locale/CMakeLists.txt PRE-CREATION 
  src/locale/LMI_LocaleProvider.c PRE-CREATION 
  src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
  src/locale/localed.h PRE-CREATION 
  src/locale/localed.c PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/


Testing
-------


Thanks,

Vitezslav Crhonek

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2682
-----------------------------------------------------------


Autoscan started for review(s) 430[4]

- scanbot


On May 29, 2014, 7:12 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated May 29, 2014, 7:12 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2683
-----------------------------------------------------------


Autoscan finished with errors:
Error: RESOURCE_LEAK (CWE-772):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:94: alloc_fn: Storage
is returned from allocation function "locale_get_properties(void)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60:5: alloc_fn: Storage is
returned from allocation function "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60:5: var_assign: Assigning:
"cloc" = "malloc(160UL)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:133:5: return_alloc: Returning
allocated memory "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:94: var_assign:
Assigning: "cloc" = storage returned from "locale_get_properties()".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:130: leaked_storage:
Variable "cloc" going out of scope leaks the storage it points to.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Layouts" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:153:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymapToggle" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:152:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Layouts" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:153:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized element of array "cloc->Locale" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:150:43: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymap" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:151:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymapToggle" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:152:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Layouts" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:153:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:53: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:60: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymap" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:151:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymapToggle" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:152:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Layouts" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:153:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:138: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a
parameter field.

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:151:9: warning: Branch condition
evaluates to a garbage value
#    if (cloc->VConsoleKeymap) free(cloc->VConsoleKeymap);
#        ^~~~~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:152:9: warning: Branch condition
evaluates to a garbage value
#    if (cloc->VConsoleKeymapToggle) free(cloc->VConsoleKeymapToggle);
#        ^~~~~~~~~~~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:153:9: warning: Branch condition
evaluates to a garbage value
#    if (cloc->X11Layouts) free(cloc->X11Layouts);
#        ^~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:154:9: warning: Branch condition
evaluates to a garbage value
#    if (cloc->X11Model) free(cloc->X11Model);
#        ^~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:155:9: warning: Branch condition
evaluates to a garbage value
#    if (cloc->X11Variant) free(cloc->X11Variant);
#        ^~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:9: warning: Branch condition
evaluates to a garbage value
#    if (cloc->X11Options) free(cloc->X11Options);
#        ^~~~~~~~~~~~~~~~

Scanned reviews: 430

- scanbot


On May 29, 2014, 7:12 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated May 29, 2014, 7:12 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2684
-----------------------------------------------------------



src/locale/LMI_LocaleProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1487>

    Couldn't this solve simple g_strdup_printf() call?



src/locale/localed.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1488>

    You're not using error anywhere, just setting and it freeing afterwards. You
should pass NULL instead and check for the return value (result == NULL or FALSE
automatically means error and the passed GError variable is set).



src/locale/localed.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1490>

    Doesn't g_dbus_proxy_get_cached_property() on the proxy constructed with
org.freedesktop.locale1 interface do the trick easier? I don't remember whether it
works with Lennart's interfaces...



src/locale/localed.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1491>

    If you remove the ampersand operator, you don't need to call strdup() in the next
step. Don't forget that you own the memory now and should take care of proper cleanup
(not this case though).
    
    See
https://developer.gnome.org/glib/unstable/gvariant-format-strings.html#gv...



src/locale/localed.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1489>

    Tip: Can use g_clear_error() without the check instead. Similar to g_clear_object().



src/locale/localed.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1492>

    Tip: or use g_free() that does NULL check for you.


Minor issues, overall it looks good.

- Tomáš Bžatek


On Kvě. 29, 2014, 7:12 dop., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated Kvě. 29, 2014, 7:12 dop.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------

(Updated June 3, 2014, 10:25 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

New provider: Locale


Diffs (updated)
-----

  CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
  README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
  mof/60_LMI_Locale.mof PRE-CREATION 
  mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
  openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
  src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
  src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
  src/locale/CMakeLists.txt PRE-CREATION 
  src/locale/LMI_LocaleProvider.c PRE-CREATION 
  src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
  src/locale/localed.h PRE-CREATION 
  src/locale/localed.c PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/


Testing
-------


Thanks,

Vitezslav Crhonek

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2688
-----------------------------------------------------------


Autoscan started for review(s) 430[5]

- scanbot


On June 3, 2014, 10:25 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 3, 2014, 10:25 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2689
-----------------------------------------------------------


Autoscan finished with errors:
Error: RESOURCE_LEAK (CWE-772):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:94: alloc_fn: Storage
is returned from allocation function "locale_get_properties(void)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59:5: alloc_fn: Storage is
returned from allocation function "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59:5: var_assign: Assigning:
"cloc" = "malloc(160UL)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:125:5: return_alloc: Returning
allocated memory "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:94: var_assign:
Assigning: "cloc" = storage returned from "locale_get_properties()".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:130: leaked_storage:
Variable "cloc" going out of scope leaks the storage it points to.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:147:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:146:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:147:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:145:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:146:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:147:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Layouts" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:144:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:145:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:146:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:147:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymapToggle" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Layouts" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:144:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:145:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:146:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:147:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymap" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:142:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymapToggle" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Layouts" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:144:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:145:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:146:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:129: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:147:5: read_parm_fld: Reading a
parameter field.

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:142:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->VConsoleKeymap);
#    ^      ~~~~~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->VConsoleKeymapToggle);
#    ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:144:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->X11Layouts);
#    ^      ~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:145:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->X11Model);
#    ^      ~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:146:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->X11Variant);
#    ^      ~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:147:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->X11Options);
#    ^      ~~~~~~~~~~~~~~~~

Scanned reviews: 430

- scanbot


On June 3, 2014, 10:25 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 3, 2014, 10:25 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2691
-----------------------------------------------------------



src/locale/localed.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1495>

    Leaking result, use g_variant_unref() to free it (according to documentation).



src/locale/localed.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1496>

    result2 should be also freed explicitly (see
https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvar...)



src/locale/localed.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1494>

    Just realized there's a leak: using Gvariant format string "s" dups
memory and you're strdup()-ing it again.


- Tomáš Bžatek


On June 3, 2014, 10:25 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 3, 2014, 10:25 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

>  On June 3, 2014, 1:06 p.m., Tomáš Bžatek wrote:
>  > src/locale/localed.c, line 80
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/430/diff/5/?file=10022#file10022...
>  >
>  >     Just realized there's a leak: using Gvariant format string "s"
> dups memory and you're strdup()-ing it again. 
I removed the strdup().


- Vitezslav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2691
-----------------------------------------------------------


On June 4, 2014, 10:38 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 4, 2014, 10:38 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2692
-----------------------------------------------------------



src/locale/localed.c
<http://reviewboard-openlmi.rhcloud.com/r/430/#comment1497>

    Looks like GVariantBuilder needs to be explicitly free'd using
g_variant_builder_unref() as well.


- Tomáš Bžatek


On Čer. 3, 2014, 10:25 dop., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated Čer. 3, 2014, 10:25 dop.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------

(Updated June 4, 2014, 10:38 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

New provider: Locale


Diffs (updated)
-----

  CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
  README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
  mof/60_LMI_Locale.mof PRE-CREATION 
  mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
  openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
  src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
  src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
  src/locale/CMakeLists.txt PRE-CREATION 
  src/locale/LMI_LocaleProvider.c PRE-CREATION 
  src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
  src/locale/localed.h PRE-CREATION 
  src/locale/localed.c PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/


Testing
-------


Thanks,

Vitezslav Crhonek

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2694
-----------------------------------------------------------


Autoscan started for review(s) 430[6]

- scanbot


On June 4, 2014, 10:38 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 4, 2014, 10:38 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2695
-----------------------------------------------------------

Ship it!


Ship It!

- Tomáš Bžatek


On Čer. 4, 2014, 10:38 dop., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated Čer. 4, 2014, 10:38 dop.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2696
-----------------------------------------------------------


Autoscan finished with errors:
Error: RESOURCE_LEAK (CWE-772):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:94: alloc_fn: Storage
is returned from allocation function "locale_get_properties(void)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59:5: alloc_fn: Storage is
returned from allocation function "malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59:5: var_assign: Assigning:
"cloc" = "malloc(160UL)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:139:5: return_alloc: Returning
allocated memory "cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:94: var_assign:
Assigning: "cloc" = storage returned from "locale_get_properties()".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/LMI_LocaleProvider.c:130: leaked_storage:
Variable "cloc" going out of scope leaks the storage it points to.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:161:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:160:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:161:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:159:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:160:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:161:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Layouts" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:158:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:159:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:160:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:161:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymapToggle" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:157:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Layouts" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:158:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:159:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:160:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:161:5: read_parm_fld: Reading a
parameter field.

Error: UNINIT (CWE-457):
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:52: var_decl: Declaring variable
"cloc".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: alloc_fn: Calling allocator
"malloc(size_t)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:59: assign: Assigning:
"cloc" = "malloc(160UL)", which is allocated but not initialized.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymap" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->VConsoleKeymapToggle" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:157:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Layouts" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:158:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Model" when calling "locale_free(CimLocale
*)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:159:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Variant" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:160:5: read_parm_fld: Reading a
parameter field.
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:143: uninit_use_in_call: Using
uninitialized value "cloc->X11Options" when calling
"locale_free(CimLocale *)".
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:161:5: read_parm_fld: Reading a
parameter field.

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:156:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->VConsoleKeymap);
#    ^      ~~~~~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:157:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->VConsoleKeymapToggle);
#    ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:158:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->X11Layouts);
#    ^      ~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:159:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->X11Model);
#    ^      ~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:160:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->X11Variant);
#    ^      ~~~~~~~~~~~~~~~~

Error: CLANG_WARNING:
openlmi-providers-0.4.1_314_gb904d5b/src/locale/localed.c:161:5: warning: Function call
argument is an uninitialized value
#    g_free(cloc->X11Options);
#    ^      ~~~~~~~~~~~~~~~~

Scanned reviews: 430

- scanbot


On June 4, 2014, 10:38 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 4, 2014, 10:38 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
>    README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
>    openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
>    src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
>    src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

Review Request 430: [1/1] New provider: Locale

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------

(Updated June 4, 2014, 12:48 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

New provider: Locale


Diffs
-----

  CMakeLists.txt bcea09707d1d87db374cf6561d00a19258b54b3b 
  README 9e7a7abce940c3dea55e0d2a6cf6daed315e8361 
  mof/60_LMI_Locale.mof PRE-CREATION 
  mof/CMakeLists.txt cbc971b1baa3b9400c644f7abdfc0c272bbabf65 
  openlmi-providers.spec dc975d5f0fd169d49227b3749e0fa3f96e5184f9 
  src/CMakeLists.txt e0fbb4e05236fc10164f359b5a13f6406aacbda1 
  src/locale/90_LMI_Locale_Profile.mof.skel PRE-CREATION 
  src/locale/CMakeLists.txt PRE-CREATION 
  src/locale/LMI_LocaleProvider.c PRE-CREATION 
  src/locale/cmpiLMI_Locale-cimprovagt PRE-CREATION 
  src/locale/localed.h PRE-CREATION 
  src/locale/localed.c PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/


Testing
-------


Thanks,

Vitezslav Crhonek