Re: Review Request 430: openlmi-locale [1/1] New provider: Locale

[Stephen Gallagher]

>  On June 6, 2013, 9:02 a.m., Radek Novacek wrote:
>  > mof/60_LMI_Locale.mof, lines 64-71
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/430/diff/1/?file=2559#file2559li...
>  >
>  >     I don't like this API much, wouldn't it be better to have this values as
> properties of the object and let user modify them via ModifyInstance method?
>  >
>  
>  Jan Safranek wrote:
>      +1 to wrong API. There should be Setting attached to something
> (Linux_OperatingSystem?) and LMI_LocaleService, which would switch current setting with a
> new one. Also, is there a possibility to get list of all supported locales? It would be
> nice to have LocaleCapabilities, which would list valid settings.
>  
+1 to wrong API. There should be Setting attached to something (Linux_OperatingSystem?)
and LMI_LocaleService, which would switch current setting with a new one. Also, is there a
possibility to get list of all supported locales? It would be nice to have
LocaleCapabilities, which would list valid settings.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review514
-----------------------------------------------------------


On June 3, 2013, 2:01 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/430/
>  -----------------------------------------------------------
>  
>  (Updated June 3, 2013, 2:01 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  New provider: Locale
>  
>  
>  Diffs
>  -----
>  
>    CMakeLists.txt c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e 
>    README a80a1d2624c80367ed53e06f50804ed39b3103da 
>    mof/60_LMI_Locale.mof PRE-CREATION 
>    openlmi-providers.spec 6e75e6f8332df807be4c2c5260211fce3339db89 
>    src/CMakeLists.txt 27bd416e1545725af0975e806975ca2119b4388b 
>    src/locale/CMakeLists.txt PRE-CREATION 
>    src/locale/LMI_LocaleProvider.c PRE-CREATION 
>    src/locale/localed.h PRE-CREATION 
>    src/locale/localed.c PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/430/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>