-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/#review2652
-----------------------------------------------------------
The MOF file is now much better, thanks. On the other hand, I think you forgot to update
the .c files appropriately :).
mof/60_LMI_Locale.mof
<
http://reviewboard-openlmi.rhcloud.com/r/430/#comment1471>
The name suggests there can be more than one option. How are they separated?
src/locale/LMI_LocaleProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/430/#comment1474>
missing error check
src/locale/LMI_LocaleProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/430/#comment1472>
This looks like it's for the older MOF file, we now have individual properties for
these.
src/locale/LMI_LocaleProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/430/#comment1473>
I think the API is different in the new MOF file.
- Jan Safranek
On May 19, 2014, 1:23 p.m., Vitezslav Crhonek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/430/
-----------------------------------------------------------
(Updated May 19, 2014, 1:23 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Locale: MOF
Diffs
-----
mof/60_LMI_Locale.mof PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/430/diff/
Testing
-------
Thanks,
Vitezslav Crhonek