----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
prototype CIM<->PCP (performance co-pilot) bridge, for review/comment
Diffs -----
src/pcp/PCP_Metric.mof PRE-CREATION src/pcp/PCP_Metric_PMNS.mof PRE-CREATION src/pcp/PCP_Metric_PMNS.reg PRE-CREATION src/pcp/PCP_pmns2mofreg.sh PRE-CREATION src/pcp/README PRE-CREATION src/pcp/pcp-metric.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/458/diff/
Testing -------
smoke-testing via YAWN web gui
Thanks,
Frank Eigler
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/#review549 -----------------------------------------------------------
The mof and reg files are generated, right? We are trying to automate build as much as possible. It would be better to not include generated files in the source.
- Roman Rakus
On June 15, 2013, 3:41 a.m., Frank Eigler wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/
(Updated June 15, 2013, 3:41 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
prototype CIM<->PCP (performance co-pilot) bridge, for review/comment
Diffs
src/pcp/PCP_Metric.mof PRE-CREATION src/pcp/PCP_Metric_PMNS.mof PRE-CREATION src/pcp/PCP_Metric_PMNS.reg PRE-CREATION src/pcp/PCP_pmns2mofreg.sh PRE-CREATION src/pcp/README PRE-CREATION src/pcp/pcp-metric.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/458/diff/
Testing
smoke-testing via YAWN web gui
Thanks,
Frank Eigler
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/#review550 -----------------------------------------------------------
Please see mof/README file in git, we have to prefix file names with numbers. Rather ship mof files with (in this case) 60_ prefix.
- Roman Rakus
On June 15, 2013, 3:41 a.m., Frank Eigler wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/
(Updated June 15, 2013, 3:41 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
prototype CIM<->PCP (performance co-pilot) bridge, for review/comment
Diffs
src/pcp/PCP_Metric.mof PRE-CREATION src/pcp/PCP_Metric_PMNS.mof PRE-CREATION src/pcp/PCP_Metric_PMNS.reg PRE-CREATION src/pcp/PCP_pmns2mofreg.sh PRE-CREATION src/pcp/README PRE-CREATION src/pcp/pcp-metric.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/458/diff/
Testing
smoke-testing via YAWN web gui
Thanks,
Frank Eigler
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/ -----------------------------------------------------------
(Updated July 9, 2013, 2:09 a.m.)
Review request for OpenLMI Developers.
Changes -------
rebased on git openlmi-providers; now with integrated build/regeneration scripts
Repository: openlmi-providers
Description -------
prototype CIM<->PCP (performance co-pilot) bridge, for review/comment
Diffs (updated) -----
README 1962f17ac7a2b20fd6f5dca06ef9a9b9ef740fdc mof/60_LMI_PCP.mof PRE-CREATION openlmi-providers.spec 8ba03301bac9d246b19bbb275dc70c0dd760fa9b src/pcp/README PRE-CREATION src/pcp/lmi/pcp/__init__.py PRE-CREATION src/pcp/lmi/pcp/metric.py PRE-CREATION src/pcp/openlmi-pcp-generate PRE-CREATION src/pcp/openlmi-pcp.cron PRE-CREATION src/pcp/setup.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/458/diff/
Testing -------
smoke-testing via YAWN web gui
Thanks,
Frank Eigler
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/#review628 -----------------------------------------------------------
src/pcp/lmi/pcp/metric.py http://reviewboard-openlmi.rhcloud.com/r/458/#comment350
Please add also description of the error, something like:
raise pywbem.CIMError(pywbem.CIM_ERR_FAILED, "Unable to fetch data from PCP")
src/pcp/lmi/pcp/metric.py http://reviewboard-openlmi.rhcloud.com/r/458/#comment351
"except" without defining the exception is considered bad habit in Python. It can easily hide programming mistakes and it even catches calling exit().
Please, specify which exceptions can occur
I don't consider these issues blockers, feel free to commit. Ask for the commit rights (gitcura group in fedora) if you don't have them. Or we can commit it for you.
- Radek Novacek
On July 9, 2013, 4:09 a.m., Frank Eigler wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/
(Updated July 9, 2013, 4:09 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
prototype CIM<->PCP (performance co-pilot) bridge, for review/comment
Diffs
README 1962f17ac7a2b20fd6f5dca06ef9a9b9ef740fdc mof/60_LMI_PCP.mof PRE-CREATION openlmi-providers.spec 8ba03301bac9d246b19bbb275dc70c0dd760fa9b src/pcp/README PRE-CREATION src/pcp/lmi/pcp/__init__.py PRE-CREATION src/pcp/lmi/pcp/metric.py PRE-CREATION src/pcp/openlmi-pcp-generate PRE-CREATION src/pcp/openlmi-pcp.cron PRE-CREATION src/pcp/setup.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/458/diff/
Testing
smoke-testing via YAWN web gui
Thanks,
Frank Eigler
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/#review629 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On July 9, 2013, 4:09 a.m., Frank Eigler wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/
(Updated July 9, 2013, 4:09 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
prototype CIM<->PCP (performance co-pilot) bridge, for review/comment
Diffs
README 1962f17ac7a2b20fd6f5dca06ef9a9b9ef740fdc mof/60_LMI_PCP.mof PRE-CREATION openlmi-providers.spec 8ba03301bac9d246b19bbb275dc70c0dd760fa9b src/pcp/README PRE-CREATION src/pcp/lmi/pcp/__init__.py PRE-CREATION src/pcp/lmi/pcp/metric.py PRE-CREATION src/pcp/openlmi-pcp-generate PRE-CREATION src/pcp/openlmi-pcp.cron PRE-CREATION src/pcp/setup.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/458/diff/
Testing
smoke-testing via YAWN web gui
Thanks,
Frank Eigler
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/ -----------------------------------------------------------
(Updated July 10, 2013, 2:53 a.m.)
Review request for OpenLMI Developers.
Changes -------
v3, with python suggestions included, and /usr/bin/openlmi-pcp-generate reworked. I don't have commit privileges (yet?); would appreciate you committing it for me this time if appropriate.
Repository: openlmi-providers
Description -------
prototype CIM<->PCP (performance co-pilot) bridge, for review/comment
Diffs (updated) -----
README 1962f17ac7a2b20fd6f5dca06ef9a9b9ef740fdc mof/60_LMI_PCP.mof PRE-CREATION openlmi-providers.spec 8ba03301bac9d246b19bbb275dc70c0dd760fa9b src/pcp/README PRE-CREATION src/pcp/lmi/pcp/__init__.py PRE-CREATION src/pcp/lmi/pcp/metric.py PRE-CREATION src/pcp/openlmi-pcp-generate PRE-CREATION src/pcp/openlmi-pcp.cron PRE-CREATION src/pcp/setup.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/458/diff/
Testing -------
smoke-testing via YAWN web gui
Thanks,
Frank Eigler
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/ -----------------------------------------------------------
(Updated July 18, 2013, 1:40 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
prototype CIM<->PCP (performance co-pilot) bridge, for review/comment
Diffs -----
README 1962f17ac7a2b20fd6f5dca06ef9a9b9ef740fdc mof/60_LMI_PCP.mof PRE-CREATION openlmi-providers.spec 8ba03301bac9d246b19bbb275dc70c0dd760fa9b src/pcp/README PRE-CREATION src/pcp/lmi/pcp/__init__.py PRE-CREATION src/pcp/lmi/pcp/metric.py PRE-CREATION src/pcp/openlmi-pcp-generate PRE-CREATION src/pcp/openlmi-pcp.cron PRE-CREATION src/pcp/setup.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/458/diff/
Testing -------
smoke-testing via YAWN web gui
Thanks,
Frank Eigler
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher