August 2013 - openlmi-reviews - Fedora Mailing-Lists

Review Request 740: software(fixes) [3/3] software: properly search for packages filtered by repoid

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/740/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- software: properly search for packages filtered by repoid If repoid is given, only 'available' packages need to be searched, otherwise the package is not found if installed. Let's just enable particular repository instead of comparing repoid attribute. Diffs ----- src/software/lmi/software/yumdb/process.py 1a9e1c0218af2d208a25db806b4ac9c9e20865ba Diff: http://reviewboard-openlmi.rhcloud.com/r/740/diff/ Testing ------- Thanks, Michal Minar

10 years, 9 months

1
2
0 / 0

Review Request 741: software(api-change) [1/2] software: added FindIdentity() function

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/741/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- software: added FindIdentity() function Since disablement of SoftwareIdentity enumeration, there has been no way to search for particular package (using [WC]QL query for example). This serious limitation is now treated by this addition to LMI_SoftwareInstallationService. Diffs ----- mof/60_LMI_Software.mof bb02e3f17f52c6c76cb62868fc0f7613d52dbcf6 src/software/lmi/software/LMI_SoftwareInstallationService.py f4cb326aa0ccd0d96771ec1b3a92e9b80f08de99 src/software/lmi/software/core/InstallationService.py 1df368f62feb903a640d0ba4b58cfeef5e0807b5 Diff: http://reviewboard-openlmi.rhcloud.com/r/741/diff/ Testing ------- Thanks, Michal Minar

10 years, 9 months

1
2
0 / 0

Review Request 737: openlmi-tools: properly handle redirected std(out|err) when prompting

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/737/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-tools Description ------- properly handle redirected std(out|err) when prompting Detect, which of stdout and stderr is attached to terminal and use it for prompt when asking for credentials. Stdout is preferred. When stdout is redirected, readline won't have any history records. It needs to be checked before trying to modify it. Diffs ----- cli/lmi/shell/LMIConnection.py ef3d37fbd08e004e48aa35048eb56872c4b81339 Diff: http://reviewboard-openlmi.rhcloud.com/r/737/diff/ Testing ------- Thanks, Michal Minar

10 years, 9 months

1
2
0 / 0

Review Request 744: openlmi-doc-class2rst [1/1] tools: Create correct reference for arrays

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/744/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- tools: Create correct reference for arrays Signed-off-by: Roman Rakus <rrakus(a)redhat.com> Diffs ----- tools/openlmi-doc-class2rst 81a0e23348cdf43bce486d3ecaf7f2d06648179d Diff: http://reviewboard-openlmi.rhcloud.com/r/744/diff/ Testing ------- Thanks, Roman Rakus

10 years, 9 months

1
2
0 / 0

Review Request 729: openlmi-tools: allow to customize the prompt, when asking for credentials

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/729/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-tools Description ------- allow to customize the prompt, when asking for credentials The user can be now presented with additional information regarding a host he tries to connect to. This can be used be lmi metacommand to prefix the promt with hostname when connecting to multiple hosts: $ lmi -h host1 -h host2 service start svnserve.service $ [host1] username: **** $ [host1] password: **** $ [host2] username: ***** $ [host2] password: ***** Diffs ----- cli/lmi/shell/LMIConnection.py ef3d37fbd08e004e48aa35048eb56872c4b81339 Diff: http://reviewboard-openlmi.rhcloud.com/r/729/diff/ Testing ------- Thanks, Michal Minar

10 years, 9 months

1
4
0 / 0

Question on Review Request 729: openlmi-tools: allow to customize the prompt, when asking for credentials

by Russell Doty

I have a few questions on review request 729, lmi commands against multiple hosts, described below. First, I was under the impression that commands were against a single server. Is there a design document covering multiple servers? Second, what is the scope of this capability? Does it apply to LIM API (the CIM calls), scriptons, or just meta-commands? Third, how are errors handled? For example, if you issue the service start command to 10 hosts and get 5 different failures, how do you determine what happened on each host? Review request for OpenLMI Developers. By Michal Minar. Updated Aug. 19, 2013, 1:23 p.m. Repository: openlmi-tools Description allow to customize the prompt, when asking for credentials The user can be now presented with additional information regarding a host he tries to connect to. This can be used be lmi metacommand to prefix the promt with hostname when connecting to multiple hosts: $ lmi -h host1 -h host2 service start svnserve.service $ [host1] username: **** $ [host1] password: **** $ [host2] username: ***** $ [host2] password: *****

10 years, 9 months

2
1
0 / 0

Review Request 743: indmanager: Use CMTraceMessage() instead of CMLogMessage()

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/743/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- indmanager: Use CMTraceMessage() instead of CMLogMessage() As per https://fedorahosted.org/openlmi/wiki/CodingConventions any debugging message that shouldn't go to user should be using CMTraceMessage(). Doing this change to minimize output to syslog, making journald indications nearly impossible to debug due to constant logging, generating more and more indications, resulting in endless loop. Diffs ----- src/indmanager/ind_manager.c c60b1f4d3161b3f21762186b1ec8df3f2f28224c Diff: http://reviewboard-openlmi.rhcloud.com/r/743/diff/ Testing ------- Thanks, Tomáš Bžatek

10 years, 9 months

1
2
0 / 0

Review Request 726: indmanager: Force thread cancellation on im_stop_ind()

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/726/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-providers Description ------- indmanager: Force thread cancellation on im_stop_ind() This fixes thread leak due to im_stop_ind() not cleaning up running thread. This change also brings some guarantees, see README for details. -- TODO: a cleanup of mutex usage is advised, I sense a chance for deadlocks in the air... Diffs ----- src/indmanager/README ddc5569216b721e629416fd4480dfb60bb39eac4 src/indmanager/ind_manager.c c60b1f4d3161b3f21762186b1ec8df3f2f28224c Diff: http://reviewboard-openlmi.rhcloud.com/r/726/diff/ Testing ------- Thanks, Tomáš Bžatek

10 years, 9 months

1
6
0 / 0

Review Request 728: [2/2] Improve mounting tests.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/728/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Improve mounting tests. Added checks that actually check if the partition was mounted or unmounted. Also added a simple test for mount options (settings). Diffs ----- test/test_mounting.py 4d663d1a99d5278e3291b5c56f7e83dc49ec23fc Diff: http://reviewboard-openlmi.rhcloud.com/r/728/diff/ Testing ------- Thanks, Jan Synacek

10 years, 9 months

1
6
0 / 0

Review Request 727: [1/2] Allow mounting with specified mount options.

by Stephen Gallagher

----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/727/ ----------------------------------------------------------- Review request for OpenLMI Developers. Repository: openlmi-storage Description ------- Allow mounting with specified mount options. Diffs ----- src/lmi/storage/LMI_MountConfigurationService.py 64caf1a22ae076c4df88a0fcee762ce417095018 src/lmi/storage/LMI_MountedFileSystem.py c5f333945871d3fe958d18657341c7f7e0a4d6b7 Diff: http://reviewboard-openlmi.rhcloud.com/r/727/diff/ Testing ------- Thanks, Jan Synacek

10 years, 9 months

1
2
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

openlmi-reviews August 2013