Review Request 1935: software-dbus [3/3] software-dbus: optimalized FindIdentity() function
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1935/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software-dbus: optimalized FindIdentity() function
Added utility function `get_repo_dets_for_pk_pkgs()` associating
PkPackages with PkRepoDetails that provides them. With this function
enumeration of LMI_ResourceForSoftwareIdentity could be simplified and
FindIdentity() method speeded up.
Old FindIdentity() was very slow when listing packages of particular
repository without any additional filter. Provider queried PackageKit
once for each installed package to test whether it is provided by
particular repository or not. This patch limits number of queries to
minimum. Many packages can be resolved in one query.
Diffs
-----
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c 731c5c902e033cc3ec91acf652e739d1b6c26c85
src/software-dbus/LMI_SoftwareInstallationServiceProvider.c b629f5f92d3611c97425144bed444886cb1c3482
src/software-dbus/sw-utils.h 8ce90ba240097c05db8f9b083aae01147ab21c5f
src/software-dbus/sw-utils.c 211f669539e1086fa8235d7dac3d6f3df26b4034
Diff: http://reviewboard-openlmi.rhcloud.com/r/1935/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 10 months
Review Request 1934: software-dbus [2/3] software-dbus: enhanced repository listing functions
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1934/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software-dbus: enhanced repository listing functions
Allow to filter repositories by their state (enabled/disabled).
Diffs
-----
src/software-dbus/LMI_HostedSoftwareIdentityResourceProvider.c ed0a44f8c24ba26211fbf4aa0d420852967bb011
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c 731c5c902e033cc3ec91acf652e739d1b6c26c85
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c 607660e80ba3b27a2d28be61a8aee8ebea6cbea6
src/software-dbus/sw-utils.h 8ce90ba240097c05db8f9b083aae01147ab21c5f
src/software-dbus/sw-utils.c 211f669539e1086fa8235d7dac3d6f3df26b4034
Diff: http://reviewboard-openlmi.rhcloud.com/r/1934/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 10 months