On June 10, 2013, 4:36 p.m., Roman Rakus wrote:
Just 2 minor things: 1) You can use CMReturn or CMReturnWithChars. 2) You can use switch instead of set of if (i==enum_value).
1) Thanks for tip, I'll rework it later (maybe :) )
2) I though about it but I think its easier to read this way because the condition is usually more complex.
- Radek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/437/#review530 -----------------------------------------------------------
On June 10, 2013, 1:45 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/437/
(Updated June 10, 2013, 1:45 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
IPAssignmentSettingDataEnumInstances cleanup
- Move conversion from internal data structures to CIM into separate functions and make them public
- Use enum instead of classname for getting instances of given class
Diffs
src/LMI_DHCPSettingDataProvider.c 597240126af4906f0d72b2b18dd04c04d4d1a1db src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c2563e421cd02493358d075529e70365fcbcdeeb src/LMI_IPAssignmentSettingDataProvider.c 21567e6246c97bc17cf080024c7eca24442643bb src/LMI_IPRouteSettingDataProvider.c 9122084e717c41718468cb13e8ca3824345ffbea src/ipassignmentsettingdata.h 30a280803264fffc3f754d832544a8fc2a23d763 src/ipassignmentsettingdata.c dd6208228b700f3663569f81e88eb07cee39fba7
Diff: http://reviewboard-openlmi.rhcloud.com/r/437/diff/
Testing
Thanks,
Radek Novacek