----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/842/#review1140 -----------------------------------------------------------
src/account/lock.c http://reviewboard-openlmi.rhcloud.com/r/842/#comment674
Why GQuark? Looking at its documentation, it copies all strings somewhere and never releases them, so we end up with provider with all user names in memory.
IMHO hash table with full user name as key and g_str_hash() would do the same and we could control where the user name is freed (in free_lock).
Just one issue, otherwise the patch looks good to me.
- Jan Safranek
On Sept. 10, 2013, 9:29 a.m., Robin Hack wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/842/
(Updated Sept. 10, 2013, 9:29 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Added associative thread locking.
Diffs
src/account/lock.c PRE-CREATION src/account/lock.h PRE-CREATION src/account/LMI_AccountProvider.c c7c16bb2beb1ef37e804e7cc7dce6bd182e6d55b src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48
Diff: http://reviewboard-openlmi.rhcloud.com/r/842/diff/
Testing
Thanks,
Robin Hack