----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/473/#review570 -----------------------------------------------------------
src/hardware/dmidecode.c http://reviewboard-openlmi.rhcloud.com/r/473/#comment330
What is this magic number? Better use some enum.
src/hardware/dmidecode.c http://reviewboard-openlmi.rhcloud.com/r/473/#comment331
Use enum rather than magic numbers.
src/hardware/dmidecode.c http://reviewboard-openlmi.rhcloud.com/r/473/#comment332
Use enum.
- Roman Rakus
On June 27, 2013, 9:58 a.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/473/
(Updated June 27, 2013, 9:58 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Hardware: Added battery providers
New providers:
- LMI_BatteryProvider
- LMI_BatteryPhysicalPackageProvider
- LMI_PhysicalBatteryContainerProvider
- LMI_PhysicalBatteryRealizesProvider
Diffs
mof/60_LMI_Hardware.mof e22da2cb866c6a678efa1547ff896f29896dbc2e src/hardware/LMI_BatteryPhysicalPackageProvider.c PRE-CREATION src/hardware/LMI_BatteryProvider.c PRE-CREATION src/hardware/LMI_Hardware.h f88e6b6bb5074cab3cc9f079898b86bb1f3a56cf src/hardware/LMI_PhysicalBatteryContainerProvider.c PRE-CREATION src/hardware/LMI_PhysicalBatteryRealizesProvider.c PRE-CREATION src/hardware/LMI_PointingDeviceProvider.c f3c89d6284c6b3a33d2a8a7c0456731d3b86c04c src/hardware/dmidecode.h 34bfd473b9939c3b73c3932f463288b7d85f4ea2 src/hardware/dmidecode.c d989a094e59ffa60db06846624aadc6560887520
Diff: http://reviewboard-openlmi.rhcloud.com/r/473/diff/
Testing
Thanks,
Peter Schiffer