On Sept. 9, 2013, 10:24 a.m., Roman Rakus wrote:
src/account/lock.c, line 161 http://reviewboard-openlmi.rhcloud.com/r/795/diff/2/?file=4521#file4521line161
Is it good to abort here? It should return some error indication rather.
Maybe I'm too nazi here... Hm.. Nop. Why i will call release_lock before pool intialization? If do that I'm mad or drunk. I think that is good place to catch bugs.
On Sept. 9, 2013, 10:24 a.m., Roman Rakus wrote:
src/account/LMI_AccountProvider.c, lines 57-62 http://reviewboard-openlmi.rhcloud.com/r/795/diff/2/?file=4519#file4519line57
Does this work? The function returns void, but CMReturn is returning CMPIStatus. I'm not sure if it is possible to do any checks here.
I don't know :(. I'm not able to find way, how I can check error in this function.
- Robin
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/795/#review1116 -----------------------------------------------------------
On Sept. 9, 2013, 9:53 a.m., Robin Hack wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/795/
(Updated Sept. 9, 2013, 9:53 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Added associative thread locking.
Diffs
src/account/CMakeLists.txt 495d7c6e3e1e083541d3ed004518dc4539f61d48 src/account/LMI_AccountProvider.c c7c16bb2beb1ef37e804e7cc7dce6bd182e6d55b src/account/lock.h PRE-CREATION src/account/lock.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/795/diff/
Testing
Thanks,
Robin Hack