On Aug. 30, 2013, 12:08 p.m., Radek Novacek wrote:
src/account/LMI_AccountProvider.c, line 480 http://reviewboard-openlmi.rhcloud.com/r/791/diff/2/?file=4413#file4413line480
Don't use exit(1) in the provider, IMHO it might cause the caller to hang. Rather return some error message.
Created ticket for it: https://fedorahosted.org/openlmi/ticket/146 Will do fix for all of this issues.
- Roman
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/#review1034 -----------------------------------------------------------
On Aug. 30, 2013, 3:27 p.m., Roman Rakus wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/791/
(Updated Aug. 30, 2013, 3:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: New delete method
This method should be used insted of intrinsic DeleteInstace.
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs
mof/60_LMI_Account.mof 0a79f59b222b75ca8e0e3ce8f1e4249e50052251 src/account/LMI_AccountProvider.c 97279234f7da4866d48bf8effee8edb5b59cfa1c
Diff: http://reviewboard-openlmi.rhcloud.com/r/791/diff/
Testing
Thanks,
Roman Rakus