----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/#review628 -----------------------------------------------------------
src/pcp/lmi/pcp/metric.py http://reviewboard-openlmi.rhcloud.com/r/458/#comment350
Please add also description of the error, something like:
raise pywbem.CIMError(pywbem.CIM_ERR_FAILED, "Unable to fetch data from PCP")
src/pcp/lmi/pcp/metric.py http://reviewboard-openlmi.rhcloud.com/r/458/#comment351
"except" without defining the exception is considered bad habit in Python. It can easily hide programming mistakes and it even catches calling exit().
Please, specify which exceptions can occur
I don't consider these issues blockers, feel free to commit. Ask for the commit rights (gitcura group in fedora) if you don't have them. Or we can commit it for you.
- Radek Novacek
On July 9, 2013, 4:09 a.m., Frank Eigler wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/458/
(Updated July 9, 2013, 4:09 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
prototype CIM<->PCP (performance co-pilot) bridge, for review/comment
Diffs
README 1962f17ac7a2b20fd6f5dca06ef9a9b9ef740fdc mof/60_LMI_PCP.mof PRE-CREATION openlmi-providers.spec 8ba03301bac9d246b19bbb275dc70c0dd760fa9b src/pcp/README PRE-CREATION src/pcp/lmi/pcp/__init__.py PRE-CREATION src/pcp/lmi/pcp/metric.py PRE-CREATION src/pcp/openlmi-pcp-generate PRE-CREATION src/pcp/openlmi-pcp.cron PRE-CREATION src/pcp/setup.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/458/diff/
Testing
smoke-testing via YAWN web gui
Thanks,
Frank Eigler