Review Request 902: journald: Add tests for new records writing

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/902/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

journald: Add tests for new records writing


Diffs
-----

  src/journald/test/TestWriting.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/902/diff/


Testing
-------


Thanks,

Tomáš Bžatek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/902/#review1317
-----------------------------------------------------------


Please, add path to the test directory to the nosetests.cfg config file. Otherwise the
test won't be found by nosetests.

- Radek Novacek


On Sept. 30, 2013, 4:45 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/902/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 30, 2013, 4:45 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  journald: Add tests for new records writing
>  
>  
>  Diffs
>  -----
>  
>    src/journald/test/TestWriting.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/902/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

>  On Oct. 4, 2013, 7:23 a.m., Radek Novacek wrote:
>  > Please, add path to the test directory to the nosetests.cfg config file. Otherwise
> the test won't be found by nosetests. 
Thanks for the heads-up, filed separate request #956


- Tomáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/902/#review1317
-----------------------------------------------------------


On Sept. 30, 2013, 2:45 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/902/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 30, 2013, 2:45 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  journald: Add tests for new records writing
>  
>  
>  Diffs
>  -----
>  
>    src/journald/test/TestWriting.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/902/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/902/#review1337
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On Sept. 30, 2013, 4:45 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/902/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 30, 2013, 4:45 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  journald: Add tests for new records writing
>  
>  
>  Diffs
>  -----
>  
>    src/journald/test/TestWriting.py PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/902/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/902/
-----------------------------------------------------------

(Updated Oct. 9, 2013, 10:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

journald: Add tests for new records writing


Diffs
-----

  src/journald/test/TestWriting.py PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/902/diff/


Testing
-------


Thanks,

Tomáš Bžatek