Review Request 1562: Software-dbus: Implemented SoftwareIdentity Provider

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/
-----------------------------------------------------------

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description
-------

Software-dbus: Implemented SoftwareIdentity Provider

Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.

Diffs
-----

src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
  src/software-dbus/LMI_Software.h PRE-CREATION 
  src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
  src/software-dbus/sw-utils.h PRE-CREATION 
  src/software-dbus/sw-utils.c PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/

Testing
-------

Thanks,

Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2363
-----------------------------------------------------------

Autoscan started for review(s) 1562[1]

- scanbot

On March 24, 2014, 4:53 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 24, 2014, 4:53 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2364
-----------------------------------------------------------

src/software-dbus/LMI_SoftwareIdentityProvider.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1264

I can see that the python version did not support EnumInstanceNames nor EnumInstances. Is supporting EnumInstanceNames intentional? Does it perform well / well enogh?

src/software-dbus/LMI_SoftwareIdentityProvider.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1261

if (error_msg[0])
    or if (*error_msg)
    might be slightly faster

src/software-dbus/sw-utils.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1263

It would be nice to have comment about the format you are parsing, like name-epoch:version-release.arch

src/software-dbus/sw-utils.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1262

this looks awkward, perhaps delim[0] = '\0'?

- Jan Safranek

On March 24, 2014, 5:53 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 24, 2014, 5:53 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

> On March 24, 2014, 5:23 p.m., Jan Safranek wrote:
> > src/software-dbus/LMI_SoftwareIdentityProvider.c, line 46
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8637#file8637line46
> > I can see that the python version did not support EnumInstanceNames nor EnumInstances. Is supporting EnumInstanceNames intentional? Does it perform well / well enogh?

Peter has shown me, that EnumInstanceNames is usable even with 10000+ packages - it still takes a lot of time but it's useful to have. EnumInstances won't be enabled though.

- Michal

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2364
-----------------------------------------------------------

On March 24, 2014, 4:53 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 24, 2014, 4:53 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

> On March 24, 2014, 6:23 p.m., Jan Safranek wrote:
> > src/software-dbus/LMI_SoftwareIdentityProvider.c, line 46
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8637#file8637line46
> > I can see that the python version did not support EnumInstanceNames nor EnumInstances. Is supporting EnumInstanceNames intentional? Does it perform well / well enogh?
>
> Michal Minar wrote:
>     Peter has shown me, that EnumInstanceNames is usable even with 10000+ packages - it still takes a lot of time but it's useful to have. EnumInstances won't be enabled though.

On my notebook, it takes 2 minutes to list all 52 000 instance names in yawn with firefox. As Michal mentioned, it's really useful at least for development. We can disable it later if needed.
> On March 24, 2014, 6:23 p.m., Jan Safranek wrote:
> > src/software-dbus/LMI_SoftwareIdentityProvider.c, line 223
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8637#file8637line223
> >    if (error_msg[0])
> > or if (*error_msg)
> > might be slightly faster

fixed
> On March 24, 2014, 6:23 p.m., Jan Safranek wrote:
> > src/software-dbus/sw-utils.c, line 126
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8639#file8639line126
> > It would be nice to have comment about the format you are parsing, like name-epoch:version-release.arch

fixed

- Peter

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2364
-----------------------------------------------------------

On March 25, 2014, 4:54 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 25, 2014, 4:54 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2365
-----------------------------------------------------------

Autoscan finished OK

Scanned reviews: 1562

- scanbot

On March 24, 2014, 4:53 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 24, 2014, 4:53 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2366
-----------------------------------------------------------

src/software-dbus/LMI_SoftwareIdentityProvider.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1272

Why not terminate the loop completely?

src/software-dbus/LMI_SoftwareIdentityProvider.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1271

Let's make this a utility function.

src/software-dbus/LMI_SoftwareIdentityProvider.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1273

Another piece of code that would be useful to have in utilities.

src/software-dbus/LMI_SoftwareIdentityProvider.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1274

Is this check really necessary? IMHO other pkg ids could appear in this array only if they were in pk_task_get_details_sync().

src/software-dbus/sw-utils.h
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1267

Redundant information. Let's compute it when needed.

src/software-dbus/sw-utils.h
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1266

This is redundant information. I'd rather compute it when needed.

src/software-dbus/sw-utils.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1269

What about *clean_sw_package*? Free prefix suggests that *pkg* pointer will be released.

src/software-dbus/sw-utils.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1270

Either initialize en to NULL or use:
      return ret;

src/software-dbus/sw-utils.c
http://reviewboard-openlmi.rhcloud.com/r/1562/#comment1268

I'd not expect the Epoch to be present. In original python implementation, 0 is assumed when epoch part is omitted.

- Michal Minar

On March 24, 2014, 4:53 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 24, 2014, 4:53 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

> On March 25, 2014, 9:08 a.m., Michal Minar wrote:
> > src/software-dbus/LMI_SoftwareIdentityProvider.c, line 67
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8637#file8637line67
> > Why not terminate the loop completely?

In case when one package has invalid package ID, why not just skip it and continue with the rest of the packages?
> On March 25, 2014, 9:08 a.m., Michal Minar wrote:
> > src/software-dbus/LMI_SoftwareIdentityProvider.c, lines 152-165
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8637#file8637line152
> > Another piece of code that would be useful to have in utilities.

Let's wait until it will be needed on another place, and create the function according that need.
> On March 25, 2014, 9:08 a.m., Michal Minar wrote:
> > src/software-dbus/LMI_SoftwareIdentityProvider.c, lines 195-196
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8637#file8637line195
> > Is this check really necessary? IMHO other pkg ids could appear in this array only if they were in pk_task_get_details_sync().

I would rather not trust PackageKit. What if it returns more items in the array?
> On March 25, 2014, 9:08 a.m., Michal Minar wrote:
> > src/software-dbus/sw-utils.h, line 39
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8638#file8638line39
> > Redundant information. Let's compute it when needed.

Element name is used in both functions, enumInstanceNames and getInstance. Why compute it twice, when it doesn't take that much space?
> On March 25, 2014, 9:08 a.m., Michal Minar wrote:
> > src/software-dbus/sw-utils.h, line 44
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8638#file8638line44
> > This is redundant information. I'd rather compute it when needed.

Although ver_str is not used in both functions, I would still prefer to keep it stored, as it's more convenient to compute it on lower level then in provider. Again, the saved space wouldn't help much I guess.
> On March 25, 2014, 9:08 a.m., Michal Minar wrote:
> > src/software-dbus/sw-utils.c, lines 132-133
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8639#file8639line132
> > Either initialize en to NULL or use:
> >   return ret;

strdup returns null on failure, initialization should be pointless

- Peter

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2366
-----------------------------------------------------------

On March 25, 2014, 4:54 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 25, 2014, 4:54 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

> On March 25, 2014, 8:08 a.m., Michal Minar wrote:
> > src/software-dbus/LMI_SoftwareIdentityProvider.c, line 67
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8637#file8637line67
> > Why not terminate the loop completely?
>
> Peter Schiffer wrote:
>     In case when one package has invalid package ID, why not just skip it and continue with the rest of the packages?

Good point, but what about allocation error? In that case it's meaningless to continue. I'd prefer using some sort of enum like networking does (openlmi-networking/src/errors.h). That would allow us to differentiate error cases. -1 does not say such much.

I'm missing exception handling :-(.
> On March 25, 2014, 8:08 a.m., Michal Minar wrote:
> > src/software-dbus/LMI_SoftwareIdentityProvider.c, lines 152-165
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8637#file8637line152
> > Another piece of code that would be useful to have in utilities.
>
> Peter Schiffer wrote:
>     Let's wait until it will be needed on another place, and create the function according that need.

OK
> On March 25, 2014, 8:08 a.m., Michal Minar wrote:
> > src/software-dbus/LMI_SoftwareIdentityProvider.c, lines 195-196
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8637#file8637line195
> > Is this check really necessary? IMHO other pkg ids could appear in this array only if they were in pk_task_get_details_sync().
>
> Peter Schiffer wrote:
>     I would rather not trust PackageKit. What if it returns more items in the array?

Your code certainly does handle that case :). Ok, let's be cautious.
> On March 25, 2014, 8:08 a.m., Michal Minar wrote:
> > src/software-dbus/sw-utils.h, line 39
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8638#file8638line39
> > Redundant information. Let's compute it when needed.
>
> Peter Schiffer wrote:
>     Element name is used in both functions, enumInstanceNames and getInstance. Why compute it twice, when it doesn't take that much space?

Computation is cheap. Having 50000 entries for the same number of packages really makes a difference (malloc adds a lot of padding for each small allocation). We may need to cache these pkg objects later on. I'd rather stick to the smallest structures possible.
> On March 25, 2014, 8:08 a.m., Michal Minar wrote:
> > src/software-dbus/sw-utils.c, lines 132-133
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8639#file8639line132
> > Either initialize en to NULL or use:
> >   return ret;
>
> Peter Schiffer wrote:
>     strdup returns null on failure, initialization should be pointless

Oops, my bad. I should have read it more carefully. Sorry for false alert.

- Michal

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2366
-----------------------------------------------------------

On March 25, 2014, 3:54 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 25, 2014, 3:54 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

> On March 25, 2014, 9:08 a.m., Michal Minar wrote:
> > src/software-dbus/LMI_SoftwareIdentityProvider.c, line 67
> > http://reviewboard-openlmi.rhcloud.com/r/1562/diff/1/?file=8637#file8637line67
> > Why not terminate the loop completely?
>
> Peter Schiffer wrote:
>     In case when one package has invalid package ID, why not just skip it and continue with the rest of the packages?
>
> Michal Minar wrote:
>     Good point, but what about allocation error? In that case it's meaningless to continue. I'd prefer using some sort of enum like networking does (openlmi-networking/src/errors.h). That would allow us to differentiate error cases. -1 does not say such much.
> I'm missing exception handling :-(.

I understand what you mean, however, networking has plenty of errors and we now have like two of them. For now, lets keep it simple and upgrade it when needed.

- Peter

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2366
-----------------------------------------------------------

On March 26, 2014, 3:02 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 26, 2014, 3:02 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/
-----------------------------------------------------------

(Updated March 25, 2014, 4:54 p.m.)

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description
-------

Software-dbus: Implemented SoftwareIdentity Provider

Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.

Diffs (updated)
-----

src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
  src/software-dbus/LMI_Software.h PRE-CREATION 
  src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
  src/software-dbus/sw-utils.h PRE-CREATION 
  src/software-dbus/sw-utils.c PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/

Testing
-------

Thanks,

Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2374
-----------------------------------------------------------

Autoscan started for review(s) 1562[2]

- scanbot

On March 25, 2014, 3:54 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 25, 2014, 3:54 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2375
-----------------------------------------------------------

Autoscan finished OK

Scanned reviews: 1562

- scanbot

On March 25, 2014, 3:54 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 25, 2014, 3:54 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/
-----------------------------------------------------------

(Updated March 26, 2014, 3:02 p.m.)

Review request for OpenLMI Developers.

Changes
-------

Compute version string and element name when needed.

Repository: openlmi-providers

Description
-------

Software-dbus: Implemented SoftwareIdentity Provider

Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.

Diffs (updated)
-----

src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
  src/software-dbus/LMI_Software.h PRE-CREATION 
  src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
  src/software-dbus/sw-utils.h PRE-CREATION 
  src/software-dbus/sw-utils.c PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/

Testing
-------

Thanks,

Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2378
-----------------------------------------------------------

Autoscan started for review(s) 1562[3]

- scanbot

On March 26, 2014, 2:02 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 26, 2014, 2:02 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2379
-----------------------------------------------------------

Ship it!

Ship It!

- Michal Minar

On March 26, 2014, 2:02 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 26, 2014, 2:02 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/
-----------------------------------------------------------

(Updated March 26, 2014, 3:32 p.m.)

Status
------

This change has been marked as submitted.

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description
-------

Software-dbus: Implemented SoftwareIdentity Provider

Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.

Diffs
-----

src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
  src/software-dbus/LMI_Software.h PRE-CREATION 
  src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
  src/software-dbus/sw-utils.h PRE-CREATION 
  src/software-dbus/sw-utils.c PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/

Testing
-------

Thanks,

Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1562/#review2380
-----------------------------------------------------------

Autoscan finished OK

Scanned reviews: 1562

- scanbot

On March 26, 2014, 2:32 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1562/
>
> (Updated March 26, 2014, 2:32 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Software-dbus: Implemented SoftwareIdentity Provider
>
> Implemented SoftwareIdentity Provider in Software-dbus using PackageKit.
> Diffs
>
> src/software-dbus/CMakeLists.txt 5febab2ba3f86371ddc844cd82d0c9a86d7d4b05 
>   src/software-dbus/LMI_Software.h PRE-CREATION 
>   src/software-dbus/LMI_SoftwareIdentityProvider.c a2f6b1bc227def9710f3d3505b45a91fb2770317 
>   src/software-dbus/sw-utils.h PRE-CREATION 
>   src/software-dbus/sw-utils.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1562/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer