Review Request 746: python-providers(logging) [2/3] python: redone cmpi_logging

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/746/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

python: redone cmpi_logging

Module now contains enhanced tracing function decorators providing more
details. There is no global logger, each provider module should obtain
its own logger via get_logger() function.

Usage of LogManager is optional. It allows for logging's
reconfiguration, when config file is changed.

Exceptions logged with error(), exception() or critical() methods are
now logged twice:
  * First time for specified level with error message only.
  * Second time for TRACE_WARNING level with traceback.
This prevents the polution of syslog.


Diffs
-----

  src/python/lmi/providers/IndicationManager.py 0b0e132284ed443a4c13ef3f9076f9d0b8563bd3 
  src/python/lmi/providers/JobManager.py a0283fbc130eae5b13eacb353a562331dd4f57f6 
  src/python/lmi/providers/TimerManager.py 76b2f5b72b8db1bf1a9150b3d6387025f7942b9b 
  src/python/lmi/providers/cmpi_logging.py a97e4abd45135cdebfcd3cbdcc54e3707757a03d 

Diff: http://reviewboard-openlmi.rhcloud.com/r/746/diff/


Testing
-------


Thanks,

Michal Minar

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/746/#review952
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Safranek


On Aug. 22, 2013, 3:29 p.m., Michal Minar wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/746/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 22, 2013, 3:29 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  python: redone cmpi_logging
>  
>  Module now contains enhanced tracing function decorators providing more
>  details. There is no global logger, each provider module should obtain
>  its own logger via get_logger() function.
>  
>  Usage of LogManager is optional. It allows for logging's
>  reconfiguration, when config file is changed.
>  
>  Exceptions logged with error(), exception() or critical() methods are
>  now logged twice:
>    * First time for specified level with error message only.
>    * Second time for TRACE_WARNING level with traceback.
>  This prevents the polution of syslog.
>  
>  
>  Diffs
>  -----
>  
>    src/python/lmi/providers/IndicationManager.py 0b0e132284ed443a4c13ef3f9076f9d0b8563bd3
>
>    src/python/lmi/providers/JobManager.py a0283fbc130eae5b13eacb353a562331dd4f57f6 
>    src/python/lmi/providers/TimerManager.py 76b2f5b72b8db1bf1a9150b3d6387025f7942b9b 
>    src/python/lmi/providers/cmpi_logging.py a97e4abd45135cdebfcd3cbdcc54e3707757a03d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/746/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Michal Minar
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/746/
-----------------------------------------------------------

(Updated Aug. 28, 2013, 7:15 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

python: redone cmpi_logging

Module now contains enhanced tracing function decorators providing more
details. There is no global logger, each provider module should obtain
its own logger via get_logger() function.

Usage of LogManager is optional. It allows for logging's
reconfiguration, when config file is changed.

Exceptions logged with error(), exception() or critical() methods are
now logged twice:
  * First time for specified level with error message only.
  * Second time for TRACE_WARNING level with traceback.
This prevents the polution of syslog.


Diffs
-----

  src/python/lmi/providers/IndicationManager.py 0b0e132284ed443a4c13ef3f9076f9d0b8563bd3 
  src/python/lmi/providers/JobManager.py a0283fbc130eae5b13eacb353a562331dd4f57f6 
  src/python/lmi/providers/TimerManager.py 76b2f5b72b8db1bf1a9150b3d6387025f7942b9b 
  src/python/lmi/providers/cmpi_logging.py a97e4abd45135cdebfcd3cbdcc54e3707757a03d 

Diff: http://reviewboard-openlmi.rhcloud.com/r/746/diff/


Testing
-------


Thanks,

Michal Minar