----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1925/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Add LMI_StorageExtent.DeviceBusType property.
The property indicates source of the block device, like 'ATA', 'SCSI', 'USB' or so. It is empty for all non-primordial devices (like partitions, LVs, ...).
udev does not distinguish between various remote devices (FC, FCoE, iSCSI, ...) and reports everyting as SCSI.
Resolves: #68
Diffs -----
mof/LMI_Storage-Base.mof dc4f1f570c0e11c4dba49e68b7916e3b21961996 mof/LMI_Storage-Partitions.mof 9f6acbfcdf0419424e132d4985240860267c388b src/lmi/storage/ExtentProvider.py eb90a1ffd28941af90bd27c4f5e20f3d51934f4a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1925/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1925/#review3152 -----------------------------------------------------------
mof/LMI_Storage-Base.mof http://reviewboard-openlmi.rhcloud.com/r/1925/#comment1757
s/may not complete/may not be complete/ ?
mof/LMI_Storage-Partitions.mof http://reviewboard-openlmi.rhcloud.com/r/1925/#comment1758
s/may not complete/may not be complete/ ?
mof/LMI_Storage-Partitions.mof http://reviewboard-openlmi.rhcloud.com/r/1925/#comment1759
s/may not complete/may not be complete/ ?
- Jan Synacek
On July 24, 2014, 9:22 a.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1925/
(Updated July 24, 2014, 9:22 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add LMI_StorageExtent.DeviceBusType property.
The property indicates source of the block device, like 'ATA', 'SCSI', 'USB' or so. It is empty for all non-primordial devices (like partitions, LVs, ...).
udev does not distinguish between various remote devices (FC, FCoE, iSCSI, ...) and reports everyting as SCSI.
Resolves: #68
Diffs
mof/LMI_Storage-Base.mof dc4f1f570c0e11c4dba49e68b7916e3b21961996 mof/LMI_Storage-Partitions.mof 9f6acbfcdf0419424e132d4985240860267c388b src/lmi/storage/ExtentProvider.py eb90a1ffd28941af90bd27c4f5e20f3d51934f4a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1925/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1925/ -----------------------------------------------------------
(Updated Čec. 24, 2014, 3:44 odp.)
Review request for OpenLMI Developers.
Summary (updated) -----------------
Add LMI_StorageExtent.DeviceBusType property.
Repository: openlmi-storage
Description (updated) -------
Add LMI_StorageExtent.DeviceBusType property.
The property indicates source of the block device, like 'ATA', 'SCSI', 'USB' or so. It is empty for all non-primordial devices (like partitions, LVs, ...).
udev does not distinguish between various remote devices (FC, FCoE, iSCSI, ...) and reports everyting as SCSI.
Resolves: #68
Diffs (updated) -----
mof/LMI_Storage-Base.mof dc4f1f570c0e11c4dba49e68b7916e3b21961996 mof/LMI_Storage-Partitions.mof 9f6acbfcdf0419424e132d4985240860267c388b src/lmi/storage/ExtentProvider.py eb90a1ffd28941af90bd27c4f5e20f3d51934f4a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1925/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1925/#review3153 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Synacek
On July 24, 2014, 3:44 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1925/
(Updated July 24, 2014, 3:44 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
Add LMI_StorageExtent.DeviceBusType property.
The property indicates source of the block device, like 'ATA', 'SCSI', 'USB' or so. It is empty for all non-primordial devices (like partitions, LVs, ...).
udev does not distinguish between various remote devices (FC, FCoE, iSCSI, ...) and reports everyting as SCSI.
Resolves: #68
Diffs
mof/LMI_Storage-Base.mof dc4f1f570c0e11c4dba49e68b7916e3b21961996 mof/LMI_Storage-Partitions.mof 9f6acbfcdf0419424e132d4985240860267c388b src/lmi/storage/ExtentProvider.py eb90a1ffd28941af90bd27c4f5e20f3d51934f4a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1925/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1925/ -----------------------------------------------------------
(Updated Čec. 25, 2014, 10:59 dop.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description -------
Add LMI_StorageExtent.DeviceBusType property.
The property indicates source of the block device, like 'ATA', 'SCSI', 'USB' or so. It is empty for all non-primordial devices (like partitions, LVs, ...).
udev does not distinguish between various remote devices (FC, FCoE, iSCSI, ...) and reports everyting as SCSI.
Resolves: #68
Diffs -----
mof/LMI_Storage-Base.mof dc4f1f570c0e11c4dba49e68b7916e3b21961996 mof/LMI_Storage-Partitions.mof 9f6acbfcdf0419424e132d4985240860267c388b src/lmi/storage/ExtentProvider.py eb90a1ffd28941af90bd27c4f5e20f3d51934f4a
Diff: http://reviewboard-openlmi.rhcloud.com/r/1925/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher