----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/457/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Fix memory issues, missing unlocks, etc.
Fix errors found by clang-analyzer and coverity.
Diffs -----
src/LMI_EndpointIdentityProvider.c d1ed4247c028086f3700d6c5208b67a25d7867e1 src/LMI_IPAssignmentSettingDataProvider.c 66bdd2e14c632deef5dd1405ae94d5951a4813db src/LMI_IPNetworkConnectionCapabilitiesProvider.c 3057f20914a783504cbb63e990e2d6907c5093f1 src/LMI_NetworkInstCreationProvider.c d5ac0bd8a4222143526a622f5451b690e8c869ec src/LMI_NetworkInstDeletionProvider.c 95ab72f61efa4481e060ea41b804ead754a054ae src/LMI_NetworkInstModificationProvider.c 314e12be6e9ce659f86a48d4c09e214f184a7752 src/LMI_SwitchPortProvider.c d85b4b8c160285c014b244e6eedcc42d1e69cc43 src/LMI_SwitchesAmongProvider.c 83acb72f05507ffcb18b5424e6557b2f779b8ea8 src/network.c 1adcc8054c749bd7efa5713983b4a0c9ddbb3d3c src/setting_nm.c cf2ef72d45143209dc6a03f038d6655dcc5c01b6 src/unittest/test_network.c c7504993442359b63588b893e6b59dd57204ec11 src/unittest/test_setting.c cf867dd42a08590f6adf684d04d8c9cc79e8bbd1
Diff: http://reviewboard-openlmi.rhcloud.com/r/457/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/457/#review547 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Synacek
On June 13, 2013, 3:42 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/457/
(Updated June 13, 2013, 3:42 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Fix memory issues, missing unlocks, etc.
Fix errors found by clang-analyzer and coverity.
Diffs
src/LMI_EndpointIdentityProvider.c d1ed4247c028086f3700d6c5208b67a25d7867e1 src/LMI_IPAssignmentSettingDataProvider.c 66bdd2e14c632deef5dd1405ae94d5951a4813db src/LMI_IPNetworkConnectionCapabilitiesProvider.c 3057f20914a783504cbb63e990e2d6907c5093f1 src/LMI_NetworkInstCreationProvider.c d5ac0bd8a4222143526a622f5451b690e8c869ec src/LMI_NetworkInstDeletionProvider.c 95ab72f61efa4481e060ea41b804ead754a054ae src/LMI_NetworkInstModificationProvider.c 314e12be6e9ce659f86a48d4c09e214f184a7752 src/LMI_SwitchPortProvider.c d85b4b8c160285c014b244e6eedcc42d1e69cc43 src/LMI_SwitchesAmongProvider.c 83acb72f05507ffcb18b5424e6557b2f779b8ea8 src/network.c 1adcc8054c749bd7efa5713983b4a0c9ddbb3d3c src/setting_nm.c cf2ef72d45143209dc6a03f038d6655dcc5c01b6 src/unittest/test_network.c c7504993442359b63588b893e6b59dd57204ec11 src/unittest/test_setting.c cf867dd42a08590f6adf684d04d8c9cc79e8bbd1
Diff: http://reviewboard-openlmi.rhcloud.com/r/457/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/457/ -----------------------------------------------------------
(Updated June 14, 2013, 3:44 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Fix memory issues, missing unlocks, etc.
Fix errors found by clang-analyzer and coverity.
Diffs -----
src/LMI_EndpointIdentityProvider.c d1ed4247c028086f3700d6c5208b67a25d7867e1 src/LMI_IPAssignmentSettingDataProvider.c 66bdd2e14c632deef5dd1405ae94d5951a4813db src/LMI_IPNetworkConnectionCapabilitiesProvider.c 3057f20914a783504cbb63e990e2d6907c5093f1 src/LMI_NetworkInstCreationProvider.c d5ac0bd8a4222143526a622f5451b690e8c869ec src/LMI_NetworkInstDeletionProvider.c 95ab72f61efa4481e060ea41b804ead754a054ae src/LMI_NetworkInstModificationProvider.c 314e12be6e9ce659f86a48d4c09e214f184a7752 src/LMI_SwitchPortProvider.c d85b4b8c160285c014b244e6eedcc42d1e69cc43 src/LMI_SwitchesAmongProvider.c 83acb72f05507ffcb18b5424e6557b2f779b8ea8 src/network.c 1adcc8054c749bd7efa5713983b4a0c9ddbb3d3c src/setting_nm.c cf2ef72d45143209dc6a03f038d6655dcc5c01b6 src/unittest/test_network.c c7504993442359b63588b893e6b59dd57204ec11 src/unittest/test_setting.c cf867dd42a08590f6adf684d04d8c9cc79e8bbd1
Diff: http://reviewboard-openlmi.rhcloud.com/r/457/diff/
Testing -------
Thanks,
Radek Novacek
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher