Review Request 1978: networking [1/2] Use safe version of lmi_get_system_name

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1978/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Use safe version of lmi_get_system_name

lmi_get_system_name_safe doesn't suffer race condition in pegasus when
provider is starting with active indication subscriptions.


Diffs
-----

  src/LMI_AffectedNetworkJobElementProvider.c 04328d057fc14d8d078952bf3feda2da3609e077 
  src/LMI_DNSProtocolEndpointProvider.c f6a86c8bf3c2f32a9ced9dfc321a3b8ab1d81382 
  src/LMI_EthernetPortProvider.c 2324d5c7f2289995be0879edfc7663ee36b9b286 
  src/LMI_HostedIPConfigurationServiceProvider.c b3f7017de5ef9226c95b5b2ca166b414bf61c7db

  src/LMI_IPConfigurationServiceProvider.c 32f9858314d51e69d2c2eff97b13d0a6eaf3225f 
  src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c
cc5eab501d36da0669d922f96b758c3459517d8e 
  src/LMI_IPNetworkConnectionProvider.c 2915af3afc343c11abda2119a9e4d165fa4039d2 
  src/LMI_IPProtocolEndpointProvider.c d93a2b3bf91a5641e6fe6597b91815167a133130 
  src/LMI_IPVersionElementSettingDataProvider.c c6f8f0cd0962829ea4e750dd1bcc9244c777ffd0 
  src/LMI_LAGPort8023adProvider.c 263f6dbcf3cb01b8d6d39b43f46fc055b49d57a6 
  src/LMI_LANEndpointProvider.c a57c5eae9b4506417f6acbab62e79c367577ba12 
  src/LMI_LinkAggregator8023adProvider.c 03432f0d5a066582ca430a63142a6024dd407158 
  src/LMI_NetworkHostedAccessPointProvider.c ef9427dfdceaf7036038d38caa0a05c54da95183 
  src/LMI_NetworkInstCreationProvider.c 72aa9efe8247eb16c6b39ec46501713695079265 
  src/LMI_NetworkInstDeletionProvider.c 5875b40860d3b7480ab24e1df7d68a91a4bd5a4f 
  src/LMI_NetworkInstModificationProvider.c 3d2be7f2a1a1a354b88623c11c0c09267e35e73e 
  src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
8ba2a42258a91fc8435dc71fe02e10909cc41a47 
  src/LMI_NetworkRemoteServiceAccessPointProvider.c
312b6765bdaba300d12b9672042d3b97e0bbeb7c 
  src/LMI_NetworkSystemDeviceProvider.c fcffdc559e8697232a63f8d2af0ea9d75168df42 
  src/LMI_OwningNetworkJobElementProvider.c edb8f78b3fd53becbc2bf0c1a736eda723745178 
  src/LMI_RouteUsesEndpointProvider.c ff30e46ec52e1bef952eed237d4a48a03ef24bdc 
  src/LMI_SwitchPortProvider.c 8bb7212a55e37c53affe58069e07f1bb25ab3a16 
  src/LMI_SwitchServiceProvider.c 6820f3d267dcab0188970cf41671112dfffcd054 
  src/LMI_SwitchesAmongProvider.c a35773b656d7d0c4ffdf8f83f0ead928e7e131b4 
  src/ipnetworkconnection.h 0b6fb85a9401e9ad4996b69937f5b628cf1963d6 
  src/ipnetworkconnection.c 614129d0aafcef8c6e44b0ed8a620738069c17cf 
  src/ref_factory.c 2c98b3ee8c8eb728ef19e745dde187a3b9fb1ce8 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1978/diff/


Testing
-------


Thanks,

Radek Novacek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1978/#review3244
-----------------------------------------------------------


Autoscan failed: FAILED
This can indicate any failure like broken buildroot to patch failed to apply. Manual
investigation of scan log is needed.
Scanned reviews: 1978,1979

- scanbot


On Aug. 27, 2014, 12:53 p.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1978/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 27, 2014, 12:53 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Use safe version of lmi_get_system_name
>  
>  lmi_get_system_name_safe doesn't suffer race condition in pegasus when
>  provider is starting with active indication subscriptions.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_AffectedNetworkJobElementProvider.c 04328d057fc14d8d078952bf3feda2da3609e077 
>    src/LMI_DNSProtocolEndpointProvider.c f6a86c8bf3c2f32a9ced9dfc321a3b8ab1d81382 
>    src/LMI_EthernetPortProvider.c 2324d5c7f2289995be0879edfc7663ee36b9b286 
>    src/LMI_HostedIPConfigurationServiceProvider.c b3f7017de5ef9226c95b5b2ca166b414bf61c7db
>
>    src/LMI_IPConfigurationServiceProvider.c 32f9858314d51e69d2c2eff97b13d0a6eaf3225f 
>    src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c
> cc5eab501d36da0669d922f96b758c3459517d8e 
>    src/LMI_IPNetworkConnectionProvider.c 2915af3afc343c11abda2119a9e4d165fa4039d2 
>    src/LMI_IPProtocolEndpointProvider.c d93a2b3bf91a5641e6fe6597b91815167a133130 
>    src/LMI_IPVersionElementSettingDataProvider.c c6f8f0cd0962829ea4e750dd1bcc9244c777ffd0
>
>    src/LMI_LAGPort8023adProvider.c 263f6dbcf3cb01b8d6d39b43f46fc055b49d57a6 
>    src/LMI_LANEndpointProvider.c a57c5eae9b4506417f6acbab62e79c367577ba12 
>    src/LMI_LinkAggregator8023adProvider.c 03432f0d5a066582ca430a63142a6024dd407158 
>    src/LMI_NetworkHostedAccessPointProvider.c ef9427dfdceaf7036038d38caa0a05c54da95183 
>    src/LMI_NetworkInstCreationProvider.c 72aa9efe8247eb16c6b39ec46501713695079265 
>    src/LMI_NetworkInstDeletionProvider.c 5875b40860d3b7480ab24e1df7d68a91a4bd5a4f 
>    src/LMI_NetworkInstModificationProvider.c 3d2be7f2a1a1a354b88623c11c0c09267e35e73e 
>    src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
> 8ba2a42258a91fc8435dc71fe02e10909cc41a47 
>    src/LMI_NetworkRemoteServiceAccessPointProvider.c
> 312b6765bdaba300d12b9672042d3b97e0bbeb7c 
>    src/LMI_NetworkSystemDeviceProvider.c fcffdc559e8697232a63f8d2af0ea9d75168df42 
>    src/LMI_OwningNetworkJobElementProvider.c edb8f78b3fd53becbc2bf0c1a736eda723745178 
>    src/LMI_RouteUsesEndpointProvider.c ff30e46ec52e1bef952eed237d4a48a03ef24bdc 
>    src/LMI_SwitchPortProvider.c 8bb7212a55e37c53affe58069e07f1bb25ab3a16 
>    src/LMI_SwitchServiceProvider.c 6820f3d267dcab0188970cf41671112dfffcd054 
>    src/LMI_SwitchesAmongProvider.c a35773b656d7d0c4ffdf8f83f0ead928e7e131b4 
>    src/ipnetworkconnection.h 0b6fb85a9401e9ad4996b69937f5b628cf1963d6 
>    src/ipnetworkconnection.c 614129d0aafcef8c6e44b0ed8a620738069c17cf 
>    src/ref_factory.c 2c98b3ee8c8eb728ef19e745dde187a3b9fb1ce8 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1978/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1978/#review3250
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Synacek


On Aug. 27, 2014, 2:53 p.m., Radek Novacek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1978/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 27, 2014, 2:53 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-networking
>  
>  
>  Description
>  -------
>  
>  Use safe version of lmi_get_system_name
>  
>  lmi_get_system_name_safe doesn't suffer race condition in pegasus when
>  provider is starting with active indication subscriptions.
>  
>  
>  Diffs
>  -----
>  
>    src/LMI_AffectedNetworkJobElementProvider.c 04328d057fc14d8d078952bf3feda2da3609e077 
>    src/LMI_DNSProtocolEndpointProvider.c f6a86c8bf3c2f32a9ced9dfc321a3b8ab1d81382 
>    src/LMI_EthernetPortProvider.c 2324d5c7f2289995be0879edfc7663ee36b9b286 
>    src/LMI_HostedIPConfigurationServiceProvider.c b3f7017de5ef9226c95b5b2ca166b414bf61c7db
>
>    src/LMI_IPConfigurationServiceProvider.c 32f9858314d51e69d2c2eff97b13d0a6eaf3225f 
>    src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c
> cc5eab501d36da0669d922f96b758c3459517d8e 
>    src/LMI_IPNetworkConnectionProvider.c 2915af3afc343c11abda2119a9e4d165fa4039d2 
>    src/LMI_IPProtocolEndpointProvider.c d93a2b3bf91a5641e6fe6597b91815167a133130 
>    src/LMI_IPVersionElementSettingDataProvider.c c6f8f0cd0962829ea4e750dd1bcc9244c777ffd0
>
>    src/LMI_LAGPort8023adProvider.c 263f6dbcf3cb01b8d6d39b43f46fc055b49d57a6 
>    src/LMI_LANEndpointProvider.c a57c5eae9b4506417f6acbab62e79c367577ba12 
>    src/LMI_LinkAggregator8023adProvider.c 03432f0d5a066582ca430a63142a6024dd407158 
>    src/LMI_NetworkHostedAccessPointProvider.c ef9427dfdceaf7036038d38caa0a05c54da95183 
>    src/LMI_NetworkInstCreationProvider.c 72aa9efe8247eb16c6b39ec46501713695079265 
>    src/LMI_NetworkInstDeletionProvider.c 5875b40860d3b7480ab24e1df7d68a91a4bd5a4f 
>    src/LMI_NetworkInstModificationProvider.c 3d2be7f2a1a1a354b88623c11c0c09267e35e73e 
>    src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
> 8ba2a42258a91fc8435dc71fe02e10909cc41a47 
>    src/LMI_NetworkRemoteServiceAccessPointProvider.c
> 312b6765bdaba300d12b9672042d3b97e0bbeb7c 
>    src/LMI_NetworkSystemDeviceProvider.c fcffdc559e8697232a63f8d2af0ea9d75168df42 
>    src/LMI_OwningNetworkJobElementProvider.c edb8f78b3fd53becbc2bf0c1a736eda723745178 
>    src/LMI_RouteUsesEndpointProvider.c ff30e46ec52e1bef952eed237d4a48a03ef24bdc 
>    src/LMI_SwitchPortProvider.c 8bb7212a55e37c53affe58069e07f1bb25ab3a16 
>    src/LMI_SwitchServiceProvider.c 6820f3d267dcab0188970cf41671112dfffcd054 
>    src/LMI_SwitchesAmongProvider.c a35773b656d7d0c4ffdf8f83f0ead928e7e131b4 
>    src/ipnetworkconnection.h 0b6fb85a9401e9ad4996b69937f5b628cf1963d6 
>    src/ipnetworkconnection.c 614129d0aafcef8c6e44b0ed8a620738069c17cf 
>    src/ref_factory.c 2c98b3ee8c8eb728ef19e745dde187a3b9fb1ce8 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1978/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Radek Novacek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1978/
-----------------------------------------------------------

(Updated Aug. 29, 2014, 8:10 a.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-networking


Description
-------

Use safe version of lmi_get_system_name

lmi_get_system_name_safe doesn't suffer race condition in pegasus when
provider is starting with active indication subscriptions.


Diffs
-----

  src/LMI_AffectedNetworkJobElementProvider.c 04328d057fc14d8d078952bf3feda2da3609e077 
  src/LMI_DNSProtocolEndpointProvider.c f6a86c8bf3c2f32a9ced9dfc321a3b8ab1d81382 
  src/LMI_EthernetPortProvider.c 2324d5c7f2289995be0879edfc7663ee36b9b286 
  src/LMI_HostedIPConfigurationServiceProvider.c b3f7017de5ef9226c95b5b2ca166b414bf61c7db

  src/LMI_IPConfigurationServiceProvider.c 32f9858314d51e69d2c2eff97b13d0a6eaf3225f 
  src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c
cc5eab501d36da0669d922f96b758c3459517d8e 
  src/LMI_IPNetworkConnectionProvider.c 2915af3afc343c11abda2119a9e4d165fa4039d2 
  src/LMI_IPProtocolEndpointProvider.c d93a2b3bf91a5641e6fe6597b91815167a133130 
  src/LMI_IPVersionElementSettingDataProvider.c c6f8f0cd0962829ea4e750dd1bcc9244c777ffd0 
  src/LMI_LAGPort8023adProvider.c 263f6dbcf3cb01b8d6d39b43f46fc055b49d57a6 
  src/LMI_LANEndpointProvider.c a57c5eae9b4506417f6acbab62e79c367577ba12 
  src/LMI_LinkAggregator8023adProvider.c 03432f0d5a066582ca430a63142a6024dd407158 
  src/LMI_NetworkHostedAccessPointProvider.c ef9427dfdceaf7036038d38caa0a05c54da95183 
  src/LMI_NetworkInstCreationProvider.c 72aa9efe8247eb16c6b39ec46501713695079265 
  src/LMI_NetworkInstDeletionProvider.c 5875b40860d3b7480ab24e1df7d68a91a4bd5a4f 
  src/LMI_NetworkInstModificationProvider.c 3d2be7f2a1a1a354b88623c11c0c09267e35e73e 
  src/LMI_NetworkRemoteAccessAvailableToElementProvider.c
8ba2a42258a91fc8435dc71fe02e10909cc41a47 
  src/LMI_NetworkRemoteServiceAccessPointProvider.c
312b6765bdaba300d12b9672042d3b97e0bbeb7c 
  src/LMI_NetworkSystemDeviceProvider.c fcffdc559e8697232a63f8d2af0ea9d75168df42 
  src/LMI_OwningNetworkJobElementProvider.c edb8f78b3fd53becbc2bf0c1a736eda723745178 
  src/LMI_RouteUsesEndpointProvider.c ff30e46ec52e1bef952eed237d4a48a03ef24bdc 
  src/LMI_SwitchPortProvider.c 8bb7212a55e37c53affe58069e07f1bb25ab3a16 
  src/LMI_SwitchServiceProvider.c 6820f3d267dcab0188970cf41671112dfffcd054 
  src/LMI_SwitchesAmongProvider.c a35773b656d7d0c4ffdf8f83f0ead928e7e131b4 
  src/ipnetworkconnection.h 0b6fb85a9401e9ad4996b69937f5b628cf1963d6 
  src/ipnetworkconnection.c 614129d0aafcef8c6e44b0ed8a620738069c17cf 
  src/ref_factory.c 2c98b3ee8c8eb728ef19e745dde187a3b9fb1ce8 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1978/diff/


Testing
-------


Thanks,

Radek Novacek