Review Request 734: journald: Use lmi logging infrastructure for error messages

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/734/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

journald: Use lmi logging infrastructure for error messages

--
This is an addendum to review #731


Diffs
-----

  src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c PRE-CREATION 
  src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION 
  src/journald/LMI_JournalMessageLogProvider.c PRE-CREATION 
  src/journald/LMI_JournalRecordInLogProvider.c PRE-CREATION 
  src/journald/instutil.c PRE-CREATION 
  src/journald/journal.h PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/734/diff/


Testing
-------


Thanks,

Tomáš Bžatek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/734/#review937
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On Aug. 20, 2013, 5:28 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/734/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 20, 2013, 5:28 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  journald: Use lmi logging infrastructure for error messages
>  
>  --
>  This is an addendum to review #731
>  
>  
>  Diffs
>  -----
>  
>    src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c PRE-CREATION 
>    src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION 
>    src/journald/LMI_JournalMessageLogProvider.c PRE-CREATION 
>    src/journald/LMI_JournalRecordInLogProvider.c PRE-CREATION 
>    src/journald/instutil.c PRE-CREATION 
>    src/journald/journal.h PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/734/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/734/#review942
-----------------------------------------------------------

Ship it!


Ship It!

- Michal Minar


On Aug. 20, 2013, 3:28 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/734/
>  -----------------------------------------------------------
>  
>  (Updated Aug. 20, 2013, 3:28 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  journald: Use lmi logging infrastructure for error messages
>  
>  --
>  This is an addendum to review #731
>  
>  
>  Diffs
>  -----
>  
>    src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c PRE-CREATION 
>    src/journald/LMI_JournalLogRecordProvider.c PRE-CREATION 
>    src/journald/LMI_JournalMessageLogProvider.c PRE-CREATION 
>    src/journald/LMI_JournalRecordInLogProvider.c PRE-CREATION 
>    src/journald/instutil.c PRE-CREATION 
>    src/journald/journal.h PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/734/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/734/
-----------------------------------------------------------

(Updated Aug. 23, 2013, 12:56 p.m.)


Review request for OpenLMI Developers.


Changes
-------

Published updated patch.
Pushed to the wip-journald branch, keeping it there until we agree for merging.


Repository: openlmi-providers


Description
-------

journald: Use lmi logging infrastructure for error messages

--
This is an addendum to review #731


Diffs (updated)
-----

  src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c
580424eba12e9d2a949dc38c8b565ca2d6fed85e 
  src/journald/LMI_JournalLogRecordProvider.c 812b4d23c1ab09a00fdd79afc1f76af0e2d4ec74 
  src/journald/LMI_JournalMessageLogProvider.c 1a1ab02214e4c3b182fa67f9a2925d553f20af14 
  src/journald/LMI_JournalRecordInLogProvider.c 2e5241f985db81cf80925efefefcc1a2ea7a3d1a 
  src/journald/instutil.c c93a91ecf09620fad45803e57f3d8393aecb2fc9 
  src/journald/journal.h 6f999ec326121388a468bb6ea187888cded83383 

Diff: http://reviewboard-openlmi.rhcloud.com/r/734/diff/


Testing
-------


Thanks,

Tomáš Bžatek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/734/
-----------------------------------------------------------

(Updated Sept. 2, 2013, 12:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

journald: Use lmi logging infrastructure for error messages

--
This is an addendum to review #731


Diffs
-----

  src/journald/LMI_JournalLogRecordInstanceCreationIndicationProvider.c
580424eba12e9d2a949dc38c8b565ca2d6fed85e 
  src/journald/LMI_JournalLogRecordProvider.c 812b4d23c1ab09a00fdd79afc1f76af0e2d4ec74 
  src/journald/LMI_JournalMessageLogProvider.c 1a1ab02214e4c3b182fa67f9a2925d553f20af14 
  src/journald/LMI_JournalRecordInLogProvider.c 2e5241f985db81cf80925efefefcc1a2ea7a3d1a 
  src/journald/instutil.c c93a91ecf09620fad45803e57f3d8393aecb2fc9 
  src/journald/journal.h 6f999ec326121388a468bb6ea187888cded83383 

Diff: http://reviewboard-openlmi.rhcloud.com/r/734/diff/


Testing
-------


Thanks,

Tomáš Bžatek