Review Request 440: openlmi-networking <indications> [5/5] test: test for lifetime indications
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/440/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
test: test for lifetime indications
This commit also adds indication infrastructure to the test_base in order to simplify its usage.
Diffs -----
test/test_base.py af75041038d3dc185772959e678a409518ca4423 test/test_indications.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/440/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/440/ -----------------------------------------------------------
(Updated June 10, 2013, 2:03 p.m.)
Review request for OpenLMI Developers.
Changes -------
Fix creation of the HTTP server for retrieving the indications.
Repository: openlmi-networking
Description -------
test: test for lifetime indications
This commit also adds indication infrastructure to the test_base in order to simplify its usage.
Diffs (updated) -----
test/test_base.py af75041038d3dc185772959e678a409518ca4423 test/test_indications.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/440/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/440/#review525 -----------------------------------------------------------
Ship it!
Look good. In future it would be good to check also for invalid queries.
- Roman Rakus
On June 10, 2013, 12:03 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/440/
(Updated June 10, 2013, 12:03 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
test: test for lifetime indications
This commit also adds indication infrastructure to the test_base in order to simplify its usage.
Diffs
test/test_base.py af75041038d3dc185772959e678a409518ca4423 test/test_indications.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/440/diff/
Testing
Thanks,
Radek Novacek
On June 10, 2013, 4:05 p.m., Roman Rakus wrote:
Look good. In future it would be good to check also for invalid queries.
Yes, checking the queries should be added, but I'll have to think about how to do it correctly.
- Radek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/440/#review525 -----------------------------------------------------------
On June 10, 2013, 2:03 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/440/
(Updated June 10, 2013, 2:03 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
test: test for lifetime indications
This commit also adds indication infrastructure to the test_base in order to simplify its usage.
Diffs
test/test_base.py af75041038d3dc185772959e678a409518ca4423 test/test_indications.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/440/diff/
Testing
Thanks,
Radek Novacek
On June 10, 2013, 2:05 p.m., Roman Rakus wrote:
Look good. In future it would be good to check also for invalid queries.
Radek Novacek wrote: Yes, checking the queries should be added, but I'll have to think about how to do it correctly.
The logic for checking queries should be in the provider - when the query (or filter) is not valid, the provider will return not OK result. The test could test if provider do it like this. So it will be test to check if provider is correctly checking.
- Roman
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/440/#review525 -----------------------------------------------------------
On June 11, 2013, 11:05 a.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/440/
(Updated June 11, 2013, 11:05 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
test: test for lifetime indications
This commit also adds indication infrastructure to the test_base in order to simplify its usage.
Diffs
test/test_base.py af75041038d3dc185772959e678a409518ca4423 test/test_indications.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/440/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/440/ -----------------------------------------------------------
(Updated June 11, 2013, 1:05 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
test: test for lifetime indications
This commit also adds indication infrastructure to the test_base in order to simplify its usage.
Diffs -----
test/test_base.py af75041038d3dc185772959e678a409518ca4423 test/test_indications.py PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/440/diff/
Testing -------
Thanks,
Radek Novacek
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher