Review Request 1289: [1/1] Service: Support indications on instance property modification.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Service: Support indications on instance property modification.


Diffs
-----

  mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
  src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
  src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
  src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
  src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/


Testing
-------


Thanks,

Vitezslav Crhonek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1796
-----------------------------------------------------------


Autoscan started for review(s) 1289

- scanbot


On Nov. 26, 2013, 9:58 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1289/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 26, 2013, 9:58 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Service: Support indications on instance property modification.
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
>    src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
>    src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
>    src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
>    src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1800
-----------------------------------------------------------


Autoscan finished with errors:
Error: SIZEOF_MISMATCH (CWE-398):
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:402:
suspicious_sizeof: Passing argument "output" of type "char *" and
argument "8 /* sizeof (output) */" to function "service_find_all(char *,
int)" is suspicious.

Error: CLANG_WARNING:
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416:24: warning:
Call to 'malloc' has an allocation size of 0 bytes
#    si->signal_proxy = malloc(si->slist->cnt * sizeof(GDBusProxy *));
#                       ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:430: dereference:
Dereferencing a null pointer "si->signal_proxy".

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:453: dereference:
Dereferencing a pointer that might be null "si->signal_proxy" when calling
"ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:529:9: deref_parm:
Directly dereferencing parameter "si->signal_proxy".

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:448: dereference:
Dereferencing a pointer that might be null "si->signal_proxy" when calling
"ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:529:9: deref_parm:
Directly dereferencing parameter "si->signal_proxy".

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:424: dereference:
Dereferencing a pointer that might be null "si->signal_proxy" when calling
"ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:529:9: deref_parm:
Directly dereferencing parameter "si->signal_proxy".

Scanned reviews: 1289

- scanbot


On Nov. 26, 2013, 9:58 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1289/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 26, 2013, 9:58 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Service: Support indications on instance property modification.
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
>    src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
>    src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
>    src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
>    src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1799
-----------------------------------------------------------



src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/1289/#comment1032>

    Preferably destroy local data after indications have been stopped, this is rather racy
as long as the thread may be still using the memory.
    
    (This is wrong also in account, will fix that right away. Thanks for pointing this out
:-))



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/1289/#comment1033>

    This is a little racy with ind_destroy() destroying the mainloop. Mainloop creating
does not need to be here, should be fine in ind_init() before the thread creation.



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/1289/#comment1034>

    Useless assignment.



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/1289/#comment1035>

    Leaking si->context, also on some more returns below.



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/1289/#comment1036>

    Also not needed here as every (error != NULL) case ends with return and error is thus
still NULL.
    
    Generally, this is a way for memleaks. g_error_set() can handle non-NULL error just
fine, printing an assert and continuing further. That way you can easily discover
programming errors.



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/1289/#comment1038>

    Free the result with g_variant_unref().



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/1289/#comment1037>

    I think the tmps would need to be free'd. Alternatively, changing the GVariant
format string could give you const gchar* instead (see the "&" modifier:
https://developer.gnome.org/glib/stable/gvariant-format-strings.html#gvar...
)



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/1289/#comment1031>

    This is no longer needed, see recently introduced im_register_filter_classes() method:
https://git.fedorahosted.org/cgit/openlmi-providers.git/commit/?id=cb1ffc...



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/1289/#comment1039>

    Hint: Preferably wait for the thread to end gracefully before unrefing the mainloop
(see pthread_join())



src/service-dbus/util/serviceutil.c
<http://reviewboard-openlmi.rhcloud.com/r/1289/#comment1040>

    Testing for si->manager_proxy to exist but using it for a call before...


Several minor issues found, otherwise the code looks good.

- Tomáš Bžatek


On Nov. 26, 2013, 9:58 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1289/
>  -----------------------------------------------------------
>  
>  (Updated Nov. 26, 2013, 9:58 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Service: Support indications on instance property modification.
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
>    src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
>    src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
>    src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
>    src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/
-----------------------------------------------------------

(Updated Dec. 2, 2013, 11:34 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Service: Support indications on instance property modification.


Diffs (updated)
-----

  mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
  src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
  src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
  src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
  src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/


Testing
-------


Thanks,

Vitezslav Crhonek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1856
-----------------------------------------------------------


Autoscan failed:
~/project/system-management/scanbot/openlmi-providers ~/project/system-management/scanbot
> From ssh://git.fedorahosted.org/git/openlmi-providers 
  
381f403..0917b98  master     -> origin/master
   ecb9a91..38139da  0.4-fixes  -> origin/0.4-fixes
Updating 381f403..0917b98
Fast-forward
 ...LMI_AccountInstanceCreationIndicationProvider.c |   8 +-
 ...LMI_AccountInstanceDeletionIndicationProvider.c |   8 +-
 src/indmanager/ind_manager.c                       |   1 +
 src/python/lmi/test/base.py                        |   2 +
 .../lmi/software/LMI_MemberOfSoftwareCollection.py |  60 +-
 .../lmi/software/LMI_SoftwareIdentityResource.py   |  37 +-
 .../software/LMI_SoftwareInstallationService.py    |   2 +-
 ...MI_SoftwareInstallationServiceAffectsElement.py |  70 +-
 src/software/test/README                           |  49 +-
 src/software/test/base.py                          | 191 -----
 src/software/test/package.py                       | 210 ++++--
 src/software/test/reposetup.py                     | 659 +++++++++++++++++
 src/software/test/repository.py                    | 277 ++++++-
 src/software/test/rpmcache.py                      | 541 --------------
 src/software/test/run.py                           | 132 ++--
 src/software/test/swbase.py                        | 288 ++++++++
 .../test/test_hosted_software_collection.py        |  30 +-
 .../test/test_hosted_software_identity_resource.py | 194 +++--
 .../test/test_installed_software_identity.py       | 332 +++++----
 .../test/test_member_of_software_collection.py     | 240 +++++-
 .../test/test_resource_for_software_identity.py    | 298 +++++---
 src/software/test/test_software_identity.py        | 273 +++++--
 src/software/test/test_software_identity_checks.py | 209 ++++--
 .../test/test_software_identity_file_check.py      | 806 ++++++++++++++++-----
 .../test/test_software_identity_resource.py        | 407 +++++++----
 ...oftware_installation_service_affects_element.py | 350 +++++++++
 .../test/test_system_software_collection.py        |  19 +-
 src/software/test/util.py                          |  10 +-
 28 files changed, 3932 insertions(+), 1771 deletions(-)
 delete mode 100644 src/software/test/base.py
 create mode 100644 src/software/test/reposetup.py
 delete mode 100644 src/software/test/rpmcache.py
 create mode 100644 src/software/test/swbase.py
 create mode 100644
src/software/test/test_software_installation_service_affects_element.py
openlmi-providers-0.4.1_74_g0917b98.tar.gz
--2013-12-02 12:49:36--  https://reviewboard-openlmi.rhcloud.com/r/1289/diff/raw/
Resolving reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)...
23.22.139.106
Connecting to reviewboard-openlmi.rhcloud.com
(reviewboard-openlmi.rhcloud.com)|23.22.139.106|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 12670 (12K) [text/x-patch]
Saving to: ‘/tmp/tmp.q2NUegAdr9/1289.patch’

     0K .......... ..                                         100% 14.2M=0.001s

2013-12-02 12:49:37 (14.2 MB/s) - ‘/tmp/tmp.q2NUegAdr9/1289.patch’ saved [12670/12670]

Wrote: /home/jsafrane/rpm/SRPMS/openlmi-providers-0.4.1_74_g0917b98-r1289.src.rpm
SRPM: /home/jsafrane/rpm/SRPMS/openlmi-providers-0.4.1_74_g0917b98-r1289.src.rpm
Usage: covscan diff-build [options] <args>

covscan: error: You are not authenticated. Please obtain Kerberos ticket or specify
username and password.


- scanbot


On Dec. 2, 2013, 11:34 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1289/
>  -----------------------------------------------------------
>  
>  (Updated Dec. 2, 2013, 11:34 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Service: Support indications on instance property modification.
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
>    src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
>    src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
>    src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
>    src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1859
-----------------------------------------------------------


Autoscan started for review(s) 1289

- scanbot


On Dec. 2, 2013, 11:34 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1289/
>  -----------------------------------------------------------
>  
>  (Updated Dec. 2, 2013, 11:34 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Service: Support indications on instance property modification.
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
>    src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
>    src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
>    src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
>    src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

>  On Dec. 2, 2013, 12:49 p.m., scanbot wrote:
>  > Autoscan failed:
>  > ~/project/system-management/scanbot/openlmi-providers
> ~/project/system-management/scanbot
>  > From ssh://git.fedorahosted.org/git/openlmi-providers
>  >    381f403..0917b98  master     -> origin/master
>  >    ecb9a91..38139da  0.4-fixes  -> origin/0.4-fixes
>  > Updating 381f403..0917b98
>  > Fast-forward
>  >  ...LMI_AccountInstanceCreationIndicationProvider.c |   8 +-
>  >  ...LMI_AccountInstanceDeletionIndicationProvider.c |   8 +-
>  >  src/indmanager/ind_manager.c                       |   1 +
>  >  src/python/lmi/test/base.py                        |   2 +
>  >  .../lmi/software/LMI_MemberOfSoftwareCollection.py |  60 +-
>  >  .../lmi/software/LMI_SoftwareIdentityResource.py   |  37 +-
>  >  .../software/LMI_SoftwareInstallationService.py    |   2 +-
>  >  ...MI_SoftwareInstallationServiceAffectsElement.py |  70 +-
>  >  src/software/test/README                           |  49 +-
>  >  src/software/test/base.py                          | 191 -----
>  >  src/software/test/package.py                       | 210 ++++--
>  >  src/software/test/reposetup.py                     | 659 +++++++++++++++++
>  >  src/software/test/repository.py                    | 277 ++++++-
>  >  src/software/test/rpmcache.py                      | 541 --------------
>  >  src/software/test/run.py                           | 132 ++--
>  >  src/software/test/swbase.py                        | 288 ++++++++
>  >  .../test/test_hosted_software_collection.py        |  30 +-
>  >  .../test/test_hosted_software_identity_resource.py | 194 +++--
>  >  .../test/test_installed_software_identity.py       | 332 +++++----
>  >  .../test/test_member_of_software_collection.py     | 240 +++++-
>  >  .../test/test_resource_for_software_identity.py    | 298 +++++---
>  >  src/software/test/test_software_identity.py        | 273 +++++--
>  >  src/software/test/test_software_identity_checks.py | 209 ++++--
>  >  .../test/test_software_identity_file_check.py      | 806 ++++++++++++++++-----
>  >  .../test/test_software_identity_resource.py        | 407 +++++++----
>  >  ...oftware_installation_service_affects_element.py | 350 +++++++++
>  >  .../test/test_system_software_collection.py        |  19 +-
>  >  src/software/test/util.py                          |  10 +-
>  >  28 files changed, 3932 insertions(+), 1771 deletions(-)
>  >  delete mode 100644 src/software/test/base.py
>  >  create mode 100644 src/software/test/reposetup.py
>  >  delete mode 100644 src/software/test/rpmcache.py
>  >  create mode 100644 src/software/test/swbase.py
>  >  create mode 100644
> src/software/test/test_software_installation_service_affects_element.py
>  > openlmi-providers-0.4.1_74_g0917b98.tar.gz
>  > --2013-12-02 12:49:36--  https://reviewboard-openlmi.rhcloud.com/r/1289/diff/raw/
>  > Resolving reviewboard-openlmi.rhcloud.com (reviewboard-openlmi.rhcloud.com)...
> 23.22.139.106
>  > Connecting to reviewboard-openlmi.rhcloud.com
> (reviewboard-openlmi.rhcloud.com)|23.22.139.106|:443... connected.
>  > HTTP request sent, awaiting response... 200 OK
>  > Length: 12670 (12K) [text/x-patch]
>  > Saving to: ‘/tmp/tmp.q2NUegAdr9/1289.patch’
>  > 
>  >      0K .......... ..                                         100% 14.2M=0.001s
>  > 
>  > 2013-12-02 12:49:37 (14.2 MB/s) - ‘/tmp/tmp.q2NUegAdr9/1289.patch’ saved
> [12670/12670]
>  > 
>  > Wrote: /home/jsafrane/rpm/SRPMS/openlmi-providers-0.4.1_74_g0917b98-r1289.src.rpm
>  > SRPM: /home/jsafrane/rpm/SRPMS/openlmi-providers-0.4.1_74_g0917b98-r1289.src.rpm
>  > Usage: covscan diff-build [options] <args>
>  > 
>  > covscan: error: You are not authenticated. Please obtain Kerberos ticket or specify
> username and password.
>  > 
oops, sorry about the error :)


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1856
-----------------------------------------------------------


On Dec. 2, 2013, 12:34 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1289/
>  -----------------------------------------------------------
>  
>  (Updated Dec. 2, 2013, 12:34 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Service: Support indications on instance property modification.
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
>    src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
>    src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
>    src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
>    src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1864
-----------------------------------------------------------


Autoscan finished with errors:
Error: SIZEOF_MISMATCH (CWE-398):
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:398:
suspicious_sizeof: Passing argument "output" of type "char *" and
argument "8 /* sizeof (output) */" to function "service_find_all(char *,
int)" is suspicious.

Error: CLANG_WARNING:
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414:24: warning:
Call to 'malloc' has an allocation size of 0 bytes
#    si->signal_proxy = malloc(si->slist->cnt * sizeof(GDBusProxy *));
#                       ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:427: dereference:
Dereferencing a null pointer "si->signal_proxy".

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:455: dereference:
Dereferencing a pointer that might be null "si->signal_proxy" when calling
"ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:509:9: deref_parm:
Directly dereferencing parameter "si->signal_proxy".

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:446: dereference:
Dereferencing a pointer that might be null "si->signal_proxy" when calling
"ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:509:9: deref_parm:
Directly dereferencing parameter "si->signal_proxy".

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:421: dereference:
Dereferencing a pointer that might be null "si->signal_proxy" when calling
"ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:509:9: deref_parm:
Directly dereferencing parameter "si->signal_proxy".

Error: PW.DECLARED_BUT_NOT_REFERENCED:
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.h:81:
declared_but_not_referenced: variable "service_allowed_classes" was declared but
never referenced
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.h:81: primary_file:
During compilation of file
'/builddir/build/BUILD/openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/LMI_ServiceProvider.c'
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.h:81: caretline:    
               ^

Error: COMPILER_WARNING:
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:30: included_from:
Included from here.
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.h:81:20: warning:
'service_allowed_classes' defined but not used [-Wunused-variable]
# static const char* service_allowed_classes[] = {
#                    ^

Scanned reviews: 1289

- scanbot


On Dec. 2, 2013, 11:34 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1289/
>  -----------------------------------------------------------
>  
>  (Updated Dec. 2, 2013, 11:34 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Service: Support indications on instance property modification.
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
>    src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
>    src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
>    src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
>    src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1868
-----------------------------------------------------------

Ship it!


Looks good, but please incorporate fixes for the issues found by scanbot first and
you're ready to go.

- Tomáš Bžatek


On Dec. 2, 2013, 11:34 a.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1289/
>  -----------------------------------------------------------
>  
>  (Updated Dec. 2, 2013, 11:34 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Service: Support indications on instance property modification.
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
>    src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
>    src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
>    src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
>    src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/
-----------------------------------------------------------

(Updated Dec. 2, 2013, 2:14 p.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Service: Support indications on instance property modification.


Diffs (updated)
-----

  mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
  src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
  src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
  src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
  src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/


Testing
-------


Thanks,

Vitezslav Crhonek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1872
-----------------------------------------------------------


Autoscan started for review(s) 1289

- scanbot


On Dec. 2, 2013, 2:14 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1289/
>  -----------------------------------------------------------
>  
>  (Updated Dec. 2, 2013, 2:14 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Service: Support indications on instance property modification.
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
>    src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
>    src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
>    src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
>    src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1876
-----------------------------------------------------------


Autoscan finished with errors:
Error: CLANG_WARNING:
openlmi-providers-0.4.1_75_gf47c906/src/service-dbus/util/serviceutil.c:414:24: warning:
Call to 'malloc' has an allocation size of 0 bytes
#    si->signal_proxy = malloc(si->slist->cnt * sizeof(GDBusProxy *));
#                       ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Scanned reviews: 1289

- scanbot


On Dec. 2, 2013, 2:14 p.m., Vitezslav Crhonek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1289/
>  -----------------------------------------------------------
>  
>  (Updated Dec. 2, 2013, 2:14 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Service: Support indications on instance property modification.
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
>    src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
>    src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
>    src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
>    src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Vitezslav Crhonek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/
-----------------------------------------------------------

(Updated Dec. 2, 2013, 3:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Service: Support indications on instance property modification.


Diffs
-----

  mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433 
  src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5 
  src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION 
  src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb 
  src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1289/diff/


Testing
-------


Thanks,

Vitezslav Crhonek