----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/438/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Move EnumInstances of port-based classes to common function
Move EnumerateInstances of IPNetworkConnection, LANEndpoint and EthernetPort to one common function in order to deduplicate code that is almost the same.
Also the creation of instances of above mentioned classes is moved to separate function. This will be needed for indication support.
Diffs -----
src/CMakeLists.txt 793d9547dcdb575070529296178ba9f81f3fc2ac src/LMI_EthernetPortProvider.c f02cb70df835cb70f4454fa86e2ff2d218673457 src/LMI_IPNetworkConnectionProvider.c 8eace4b6db6c4441c6f480c7d446c4c2b58abf78 src/LMI_LANEndpointProvider.c ea35f7ca2cc6185ae72d6bfdb5f22458922c28ce src/ipnetworkconnection.h PRE-CREATION src/ipnetworkconnection.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/438/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/438/#review531 -----------------------------------------------------------
Ship it!
Ship It!
- Roman Rakus
On June 10, 2013, 11:45 a.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/438/
(Updated June 10, 2013, 11:45 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Move EnumInstances of port-based classes to common function
Move EnumerateInstances of IPNetworkConnection, LANEndpoint and EthernetPort to one common function in order to deduplicate code that is almost the same.
Also the creation of instances of above mentioned classes is moved to separate function. This will be needed for indication support.
Diffs
src/CMakeLists.txt 793d9547dcdb575070529296178ba9f81f3fc2ac src/LMI_EthernetPortProvider.c f02cb70df835cb70f4454fa86e2ff2d218673457 src/LMI_IPNetworkConnectionProvider.c 8eace4b6db6c4441c6f480c7d446c4c2b58abf78 src/LMI_LANEndpointProvider.c ea35f7ca2cc6185ae72d6bfdb5f22458922c28ce src/ipnetworkconnection.h PRE-CREATION src/ipnetworkconnection.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/438/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/438/ -----------------------------------------------------------
(Updated June 11, 2013, 1:05 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Move EnumInstances of port-based classes to common function
Move EnumerateInstances of IPNetworkConnection, LANEndpoint and EthernetPort to one common function in order to deduplicate code that is almost the same.
Also the creation of instances of above mentioned classes is moved to separate function. This will be needed for indication support.
Diffs -----
src/CMakeLists.txt 793d9547dcdb575070529296178ba9f81f3fc2ac src/LMI_EthernetPortProvider.c f02cb70df835cb70f4454fa86e2ff2d218673457 src/LMI_IPNetworkConnectionProvider.c 8eace4b6db6c4441c6f480c7d446c4c2b58abf78 src/LMI_LANEndpointProvider.c ea35f7ca2cc6185ae72d6bfdb5f22458922c28ce src/ipnetworkconnection.h PRE-CREATION src/ipnetworkconnection.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/438/diff/
Testing -------
Thanks,
Radek Novacek
openlmi-reviews@lists.fedorahosted.org