Review Request 560: [openlmi-providers] Profiles: [2/2] Added -v option to opelmi-mof-register.
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/560/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Added -v option to opelmi-mof-register.
Diffs -----
openlmi-mof-register d327a1e996a954bd894e9464789430669c910b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/560/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/560/#review682 -----------------------------------------------------------
openlmi-mof-register http://reviewboard-openlmi.rhcloud.com/r/560/#comment384
I don't think it's a good idea to have a default value for version. What would happen if you registered version 1.0.0 and then accidentaly left out the version string in the next registration? I think it would be better to make the version argument mandatory.
- Jan Synacek
On July 16, 2013, 3:15 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/560/
(Updated July 16, 2013, 3:15 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Added -v option to opelmi-mof-register.
Diffs
openlmi-mof-register d327a1e996a954bd894e9464789430669c910b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/560/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/560/ -----------------------------------------------------------
(Updated July 17, 2013, 3:04 p.m.)
Review request for OpenLMI Developers.
Summary (updated) -----------------
[openlmi-providers] Profiles: [2/2] Added -v option to opelmi-mof-register.
Repository: openlmi-providers
Description -------
Added -v option to opelmi-mof-register.
Diffs (updated) -----
openlmi-mof-register d327a1e996a954bd894e9464789430669c910b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/560/diff/
Testing -------
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/560/#review703 -----------------------------------------------------------
Ship it!
openlmi-mof-register http://reviewboard-openlmi.rhcloud.com/r/560/#comment393
Add yourself?
- Jan Synacek
On July 17, 2013, 3:04 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/560/
(Updated July 17, 2013, 3:04 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Added -v option to opelmi-mof-register.
Diffs
openlmi-mof-register d327a1e996a954bd894e9464789430669c910b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/560/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/560/#review705 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On July 17, 2013, 1:04 p.m., Jan Safranek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/560/
(Updated July 17, 2013, 1:04 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Added -v option to opelmi-mof-register.
Diffs
openlmi-mof-register d327a1e996a954bd894e9464789430669c910b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/560/diff/
Testing
Thanks,
Jan Safranek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/560/ -----------------------------------------------------------
(Updated July 17, 2013, 3:22 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Added -v option to opelmi-mof-register.
Diffs -----
openlmi-mof-register d327a1e996a954bd894e9464789430669c910b13
Diff: http://reviewboard-openlmi.rhcloud.com/r/560/diff/
Testing -------
Thanks,
Jan Safranek
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher