Review Request 1920: [1/1] service: add LMI_HostedService association

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1920/
-----------------------------------------------------------

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description
-------

service: add LMI_HostedService association

Diffs
-----

mof/60_LMI_Service.mof 9166fc217374f1b58f21b5e4f1e1ae984ea94ce3 
  src/service-dbus/LMI_HostedServiceProvider.c PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/1920/diff/

Testing
-------

Thanks,

Vitezslav Crhonek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1920/#review3135
-----------------------------------------------------------

Autoscan started for review(s) 1920[1]

- scanbot

On July 22, 2014, 1:55 p.m., Vitezslav Crhonek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1920/
>
> (Updated July 22, 2014, 1:55 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> service: add LMI_HostedService association
> Diffs
>
> mof/60_LMI_Service.mof 9166fc217374f1b58f21b5e4f1e1ae984ea94ce3 
>   src/service-dbus/LMI_HostedServiceProvider.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1920/diff/
> Testing
>
> Thanks,
>
> Vitezslav Crhonek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1920/#review3136
-----------------------------------------------------------

Autoscan finished with errors:
Error: PW.DECLARED_BUT_NOT_REFERENCED:
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c:58: declared_but_not_referenced: variable "status" was declared but never referenced
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c:58: caretline:                ^

Error: COMPILER_WARNING:
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c: scope_hint: In function 'LMI_HostedServiceEnumInstances'
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c:58:16: warning: unused variable 'status' [-Wunused-variable]
#     CMPIStatus status;
#                ^

Error: PW.VAR_WITH_UNINITIALIZED_FIELD:
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c:69: var_with_uninitialized_field: variable "w" has an uninitialized const field
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c:69: caretline:                           ^

Error: PW.VAR_WITH_UNINITIALIZED_FIELD:
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c:74: var_with_uninitialized_field: variable "ref" has an uninitialized const field
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c:74: caretline:                        ^

Error: RESOURCE_LEAK (CWE-772):
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c:63: alloc_fn: Storage is returned from allocation function "service_find_all(char *, int)".
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/util/serviceutil.c:111:5: alloc_fn: Storage is returned from allocation function "malloc(size_t)".
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/util/serviceutil.c:111:5: var_assign: Assigning: "slist" = "malloc(16UL)".
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/util/serviceutil.c:158:5: return_alloc: Returning allocated memory "slist".
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c:63: var_assign: Assigning: "slist" = storage returned from "service_find_all(output, 1024)".
openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c:83: leaked_storage: Variable "slist" going out of scope leaks the storage it points to.

Error: PW.VAR_WITH_UNINITIALIZED_FIELD:
openlmi-providers-0.4.1_404_gf2b5c98/x86_64-redhat-linux-gnu/src/service-dbus/CIM_ComputerSystem.h:3114: var_with_uninitialized_field: variable "self" has an uninitialized const field
openlmi-providers-0.4.1_404_gf2b5c98/x86_64-redhat-linux-gnu/src/service-dbus/CIM_ComputerSystem.h:3114: primary_file: During compilation of file '/builddir/build/BUILD/openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c'
openlmi-providers-0.4.1_404_gf2b5c98/x86_64-redhat-linux-gnu/src/service-dbus/CIM_ComputerSystem.h:3114: caretline:                           ^

Error: PW.VAR_WITH_UNINITIALIZED_FIELD:
openlmi-providers-0.4.1_404_gf2b5c98/x86_64-redhat-linux-gnu/src/service-dbus/LMI_HostedService.h:380: var_with_uninitialized_field: variable "self" has an uninitialized const field
openlmi-providers-0.4.1_404_gf2b5c98/x86_64-redhat-linux-gnu/src/service-dbus/LMI_HostedService.h:380: primary_file: During compilation of file '/builddir/build/BUILD/openlmi-providers-0.4.1_404_gf2b5c98/src/service-dbus/LMI_HostedServiceProvider.c'
openlmi-providers-0.4.1_404_gf2b5c98/x86_64-redhat-linux-gnu/src/service-dbus/LMI_HostedService.h:380: caretline:                          ^

Scanned reviews: 1920

- scanbot

On July 22, 2014, 1:55 p.m., Vitezslav Crhonek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1920/
>
> (Updated July 22, 2014, 1:55 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> service: add LMI_HostedService association
> Diffs
>
> mof/60_LMI_Service.mof 9166fc217374f1b58f21b5e4f1e1ae984ea94ce3 
>   src/service-dbus/LMI_HostedServiceProvider.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1920/diff/
> Testing
>
> Thanks,
>
> Vitezslav Crhonek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1920/#review3137
-----------------------------------------------------------

Also our mighty scanbot found some valid points.

mof/60_LMI_Service.mof
http://reviewboard-openlmi.rhcloud.com/r/1920/#comment1752

Bump the version to current one (0.4.2 if I'm not mistaken).

- Michal Minar

On Čec. 22, 2014, 1:55 odp., Vitezslav Crhonek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1920/
>
> (Updated Čec. 22, 2014, 1:55 odp.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> service: add LMI_HostedService association
> Diffs
>
> mof/60_LMI_Service.mof 9166fc217374f1b58f21b5e4f1e1ae984ea94ce3 
>   src/service-dbus/LMI_HostedServiceProvider.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1920/diff/
> Testing
>
> Thanks,
>
> Vitezslav Crhonek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1920/#review3143
-----------------------------------------------------------

mof/60_LMI_Service.mof
http://reviewboard-openlmi.rhcloud.com/r/1920/#comment1756

Please rename the class to some "HostedSystemSevice" or so, we inherited CIM_HostedService several times and we have lot of "HostedXXXServices" already.

- Jan Safranek

On Čec. 22, 2014, 3:55 odp., Vitezslav Crhonek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1920/
>
> (Updated Čec. 22, 2014, 3:55 odp.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> service: add LMI_HostedService association
> Diffs
>
> mof/60_LMI_Service.mof 9166fc217374f1b58f21b5e4f1e1ae984ea94ce3 
>   src/service-dbus/LMI_HostedServiceProvider.c PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1920/diff/
> Testing
>
> Thanks,
>
> Vitezslav Crhonek

Review Request 1920: [1/1] service: added LMI_HostedSystemService association

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1920/
-----------------------------------------------------------

(Updated July 23, 2014, 1:21 p.m.)

Review request for OpenLMI Developers.

Summary (updated)
-----------------

[1/1] service: added LMI_HostedSystemService association

Repository: openlmi-providers

Description (updated)
-------

service: added LMI_HostedSystemService association

Diffs (updated)
-----

src/service-dbus/LMI_HostedSystemServiceProvider.c PRE-CREATION 
  mof/60_LMI_Service.mof 9166fc217374f1b58f21b5e4f1e1ae984ea94ce3

Diff: http://reviewboard-openlmi.rhcloud.com/r/1920/diff/

Testing
-------

Thanks,

Vitezslav Crhonek

Review Request 1920: [1/1] service: added LMI_HostedSystemService association

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1920/#review3146
-----------------------------------------------------------

Autoscan started for review(s) 1920[2]

- scanbot

On July 23, 2014, 1:21 p.m., Vitezslav Crhonek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1920/
>
> (Updated July 23, 2014, 1:21 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> service: added LMI_HostedSystemService association
> Diffs
>
> src/service-dbus/LMI_HostedSystemServiceProvider.c PRE-CREATION 
>   mof/60_LMI_Service.mof 9166fc217374f1b58f21b5e4f1e1ae984ea94ce3
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1920/diff/
> Testing
>
> Thanks,
>
> Vitezslav Crhonek

Review Request 1920: [1/1] service: added LMI_HostedSystemService association

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1920/#review3147
-----------------------------------------------------------

Autoscan finished with errors:
Error: PW.VAR_WITH_UNINITIALIZED_FIELD:
openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/LMI_HostedSystemServiceProvider.c:68: var_with_uninitialized_field: variable "w" has an uninitialized const field
openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/LMI_HostedSystemServiceProvider.c:68: caretline:                                 ^

Error: PW.VAR_WITH_UNINITIALIZED_FIELD:
openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/LMI_HostedSystemServiceProvider.c:73: var_with_uninitialized_field: variable "ref" has an uninitialized const field
openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/LMI_HostedSystemServiceProvider.c:73: caretline:                        ^

Error: RESOURCE_LEAK (CWE-772):
openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/LMI_HostedSystemServiceProvider.c:62: alloc_fn: Storage is returned from allocation function "service_find_all(char *, int)".
openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/util/serviceutil.c:111:5: alloc_fn: Storage is returned from allocation function "malloc(size_t)".
openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/util/serviceutil.c:111:5: var_assign: Assigning: "slist" = "malloc(16UL)".
openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/util/serviceutil.c:158:5: return_alloc: Returning allocated memory "slist".
openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/LMI_HostedSystemServiceProvider.c:62: var_assign: Assigning: "slist" = storage returned from "service_find_all(output, 1024)".
openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/LMI_HostedSystemServiceProvider.c:82: leaked_storage: Variable "slist" going out of scope leaks the storage it points to.

Error: PW.VAR_WITH_UNINITIALIZED_FIELD:
openlmi-providers-0.4.1_405_g24eb490/x86_64-redhat-linux-gnu/src/service-dbus/CIM_ComputerSystem.h:3114: var_with_uninitialized_field: variable "self" has an uninitialized const field
openlmi-providers-0.4.1_405_g24eb490/x86_64-redhat-linux-gnu/src/service-dbus/CIM_ComputerSystem.h:3114: primary_file: During compilation of file '/builddir/build/BUILD/openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/LMI_HostedSystemServiceProvider.c'
openlmi-providers-0.4.1_405_g24eb490/x86_64-redhat-linux-gnu/src/service-dbus/CIM_ComputerSystem.h:3114: caretline:                           ^

Error: PW.VAR_WITH_UNINITIALIZED_FIELD:
openlmi-providers-0.4.1_405_g24eb490/x86_64-redhat-linux-gnu/src/service-dbus/LMI_HostedSystemService.h:382: var_with_uninitialized_field: variable "self" has an uninitialized const field
openlmi-providers-0.4.1_405_g24eb490/x86_64-redhat-linux-gnu/src/service-dbus/LMI_HostedSystemService.h:382: primary_file: During compilation of file '/builddir/build/BUILD/openlmi-providers-0.4.1_405_g24eb490/src/service-dbus/LMI_HostedSystemServiceProvider.c'
openlmi-providers-0.4.1_405_g24eb490/x86_64-redhat-linux-gnu/src/service-dbus/LMI_HostedSystemService.h:382: caretline:                                ^

Scanned reviews: 1920

- scanbot

On July 23, 2014, 1:21 p.m., Vitezslav Crhonek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1920/
>
> (Updated July 23, 2014, 1:21 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> service: added LMI_HostedSystemService association
> Diffs
>
> src/service-dbus/LMI_HostedSystemServiceProvider.c PRE-CREATION 
>   mof/60_LMI_Service.mof 9166fc217374f1b58f21b5e4f1e1ae984ea94ce3
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1920/diff/
> Testing
>
> Thanks,
>
> Vitezslav Crhonek

Review Request 1920: [1/1] service: added LMI_HostedSystemService association

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1920/#review3148
-----------------------------------------------------------

Ship it!

Ship It!

- Michal Minar

On Čec. 23, 2014, 1:21 odp., Vitezslav Crhonek wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/1920/
>
> (Updated Čec. 23, 2014, 1:21 odp.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> service: added LMI_HostedSystemService association
> Diffs
>
> src/service-dbus/LMI_HostedSystemServiceProvider.c PRE-CREATION 
>   mof/60_LMI_Service.mof 9166fc217374f1b58f21b5e4f1e1ae984ea94ce3
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/1920/diff/
> Testing
>
> Thanks,
>
> Vitezslav Crhonek

Review Request 1920: [1/1] service: added LMI_HostedSystemService association

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1920/
-----------------------------------------------------------

(Updated July 24, 2014, 7:45 a.m.)

Status
------

This change has been marked as submitted.

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description
-------

service: added LMI_HostedSystemService association

Diffs
-----

src/service-dbus/LMI_HostedSystemServiceProvider.c PRE-CREATION 
  mof/60_LMI_Service.mof 9166fc217374f1b58f21b5e4f1e1ae984ea94ce3

Diff: http://reviewboard-openlmi.rhcloud.com/r/1920/diff/

Testing
-------

Thanks,

Vitezslav Crhonek