----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/449/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Handle generic device type properly
Recent NetworkManager (0.9.9) introduced generic device type that is used for devices that NetworkManager don't manage (like loopback).
This commit also make sure that newly added device type will not crash the provider.
Diffs -----
src/ipnetworkconnection.c 21ecd289a7ff3913c906dc1e536343ccfccb1e29 src/network.c 1adcc8054c749bd7efa5713983b4a0c9ddbb3d3c src/port.c 5f5c27d93d8b78147544d723c5a94cb2be56f609 src/port_nm.c 52ad5332a36e7a9f66344322047473d3596a6300
Diff: http://reviewboard-openlmi.rhcloud.com/r/449/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/449/#review545 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Synacek
On June 12, 2013, 11:22 a.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/449/
(Updated June 12, 2013, 11:22 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Handle generic device type properly
Recent NetworkManager (0.9.9) introduced generic device type that is used for devices that NetworkManager don't manage (like loopback).
This commit also make sure that newly added device type will not crash the provider.
Diffs
src/ipnetworkconnection.c 21ecd289a7ff3913c906dc1e536343ccfccb1e29 src/network.c 1adcc8054c749bd7efa5713983b4a0c9ddbb3d3c src/port.c 5f5c27d93d8b78147544d723c5a94cb2be56f609 src/port_nm.c 52ad5332a36e7a9f66344322047473d3596a6300
Diff: http://reviewboard-openlmi.rhcloud.com/r/449/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/449/ -----------------------------------------------------------
(Updated June 14, 2013, 3:44 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Handle generic device type properly
Recent NetworkManager (0.9.9) introduced generic device type that is used for devices that NetworkManager don't manage (like loopback).
This commit also make sure that newly added device type will not crash the provider.
Diffs -----
src/ipnetworkconnection.c 21ecd289a7ff3913c906dc1e536343ccfccb1e29 src/network.c 1adcc8054c749bd7efa5713983b4a0c9ddbb3d3c src/port.c 5f5c27d93d8b78147544d723c5a94cb2be56f609 src/port_nm.c 52ad5332a36e7a9f66344322047473d3596a6300
Diff: http://reviewboard-openlmi.rhcloud.com/r/449/diff/
Testing -------
Thanks,
Radek Novacek
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher