----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1749/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Test: get rid of 'import unittest'
Always use 'from lmi.test import unittest' instead of plain 'import unittest', because it automagically imports unittest2 on python 2.6.
Diffs -----
src/service-dbus/test/testService.py 1c0efeca0149c81a265cf4cebde589e25ed3a742 src/python/lmi/base/singletonmixin.py c252676581ca282f9e8c477611d54e8dc7e93a76 src/journald/test/TestWriting.py 7f53a3ceced8ba5cc653be594108e71f0026ea95 src/journald/test/TestIterators.py 4a79b57d8176622a88598f348ae78eff8cdc2808 src/journald/test/TestIndications.py 0a1acf7ef0fa82da4b13f3b398058f3ad9929f80 src/hardware/test/TestHardwareBase.py bea2224c9ba3aa83557fb8c006b083329a6a8050 src/hardware/test/TestHardware.py 949b6a38c9a66ea34568603a047f3e4a255c4146
Diff: http://reviewboard-openlmi.rhcloud.com/r/1749/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1749/#review2643 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On May 19, 2014, 10:09 a.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1749/
(Updated May 19, 2014, 10:09 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Test: get rid of 'import unittest'
Always use 'from lmi.test import unittest' instead of plain 'import unittest', because it automagically imports unittest2 on python 2.6.
Diffs
src/service-dbus/test/testService.py 1c0efeca0149c81a265cf4cebde589e25ed3a742 src/python/lmi/base/singletonmixin.py c252676581ca282f9e8c477611d54e8dc7e93a76 src/journald/test/TestWriting.py 7f53a3ceced8ba5cc653be594108e71f0026ea95 src/journald/test/TestIterators.py 4a79b57d8176622a88598f348ae78eff8cdc2808 src/journald/test/TestIndications.py 0a1acf7ef0fa82da4b13f3b398058f3ad9929f80 src/hardware/test/TestHardwareBase.py bea2224c9ba3aa83557fb8c006b083329a6a8050 src/hardware/test/TestHardware.py 949b6a38c9a66ea34568603a047f3e4a255c4146
Diff: http://reviewboard-openlmi.rhcloud.com/r/1749/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1749/ -----------------------------------------------------------
(Updated May 19, 2014, 12:49 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Test: get rid of 'import unittest'
Always use 'from lmi.test import unittest' instead of plain 'import unittest', because it automagically imports unittest2 on python 2.6.
Diffs -----
src/service-dbus/test/testService.py 1c0efeca0149c81a265cf4cebde589e25ed3a742 src/python/lmi/base/singletonmixin.py c252676581ca282f9e8c477611d54e8dc7e93a76 src/journald/test/TestWriting.py 7f53a3ceced8ba5cc653be594108e71f0026ea95 src/journald/test/TestIterators.py 4a79b57d8176622a88598f348ae78eff8cdc2808 src/journald/test/TestIndications.py 0a1acf7ef0fa82da4b13f3b398058f3ad9929f80 src/hardware/test/TestHardwareBase.py bea2224c9ba3aa83557fb8c006b083329a6a8050 src/hardware/test/TestHardware.py 949b6a38c9a66ea34568603a047f3e4a255c4146
Diff: http://reviewboard-openlmi.rhcloud.com/r/1749/diff/
Testing -------
Thanks,
Radek Novacek
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher