Review Request 1415: providers [1/2] software: test improvements

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1415/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

software: test improvements

* Suppress warnings when removing testing packages that may have been
  modified by finished test. Whe some installed file were missing, rpm
  produced ugly warnings and errors.
* Set LC_ALL=C when running yum and parsing its output. Otherwise
  numbers get localized, which confuses the parser.
* Allow to run tests from another directory.
* Minor cleanups and docstrings corrections.


Diffs
-----

  src/software/test/README 4a059bd99b269c94f008ed94f52af36bcb8212aa 
  src/software/test/package.py c4b7dfa54c10b4277823b2080c6e79dc97f85722 
  src/software/test/repository.py fce1707c094dbb6a3042af25fb9ffaded0048871 
  src/software/test/swbase.py a7d8e3c678ec4df9e5365dd2519c0782818ffc3c 
  src/software/test/test_resource_for_software_identity.py
05814f3772407629e75d6720c1995878490d362a 
  src/software/test/test_software_identity_checks.py
8a8761dc0af0cfbd3f1efceeb36dd2908e655787 
  src/software/test/test_software_identity_file_check.py
c1fb77b6f5f35e6f8eaea4f2f8fce22349cb4669 
  src/software/test/test_software_identity_resource.py
a53b361afca2b927492a5637ebfb7a7d99aa6809 
  src/software/test/test_software_installation_service.py
1b95c211bdc1411871cd6f1300a77ca59b3b2c50 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1415/diff/


Testing
-------


Thanks,

Michal Minar

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1415/#review2053
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Safranek


On Jan. 2, 2014, 3:31 p.m., Michal Minar wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1415/
>  -----------------------------------------------------------
>  
>  (Updated Jan. 2, 2014, 3:31 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  software: test improvements
>  
>  * Suppress warnings when removing testing packages that may have been
>    modified by finished test. Whe some installed file were missing, rpm
>    produced ugly warnings and errors.
>  * Set LC_ALL=C when running yum and parsing its output. Otherwise
>    numbers get localized, which confuses the parser.
>  * Allow to run tests from another directory.
>  * Minor cleanups and docstrings corrections.
>  
>  
>  Diffs
>  -----
>  
>    src/software/test/README 4a059bd99b269c94f008ed94f52af36bcb8212aa 
>    src/software/test/package.py c4b7dfa54c10b4277823b2080c6e79dc97f85722 
>    src/software/test/repository.py fce1707c094dbb6a3042af25fb9ffaded0048871 
>    src/software/test/swbase.py a7d8e3c678ec4df9e5365dd2519c0782818ffc3c 
>    src/software/test/test_resource_for_software_identity.py
> 05814f3772407629e75d6720c1995878490d362a 
>    src/software/test/test_software_identity_checks.py
> 8a8761dc0af0cfbd3f1efceeb36dd2908e655787 
>    src/software/test/test_software_identity_file_check.py
> c1fb77b6f5f35e6f8eaea4f2f8fce22349cb4669 
>    src/software/test/test_software_identity_resource.py
> a53b361afca2b927492a5637ebfb7a7d99aa6809 
>    src/software/test/test_software_installation_service.py
> 1b95c211bdc1411871cd6f1300a77ca59b3b2c50 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1415/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Michal Minar
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1415/
-----------------------------------------------------------

(Updated Jan. 6, 2014, 1:30 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

software: test improvements

* Suppress warnings when removing testing packages that may have been
  modified by finished test. Whe some installed file were missing, rpm
  produced ugly warnings and errors.
* Set LC_ALL=C when running yum and parsing its output. Otherwise
  numbers get localized, which confuses the parser.
* Allow to run tests from another directory.
* Minor cleanups and docstrings corrections.


Diffs
-----

  src/software/test/README 4a059bd99b269c94f008ed94f52af36bcb8212aa 
  src/software/test/package.py c4b7dfa54c10b4277823b2080c6e79dc97f85722 
  src/software/test/repository.py fce1707c094dbb6a3042af25fb9ffaded0048871 
  src/software/test/swbase.py a7d8e3c678ec4df9e5365dd2519c0782818ffc3c 
  src/software/test/test_resource_for_software_identity.py
05814f3772407629e75d6720c1995878490d362a 
  src/software/test/test_software_identity_checks.py
8a8761dc0af0cfbd3f1efceeb36dd2908e655787 
  src/software/test/test_software_identity_file_check.py
c1fb77b6f5f35e6f8eaea4f2f8fce22349cb4669 
  src/software/test/test_software_identity_resource.py
a53b361afca2b927492a5637ebfb7a7d99aa6809 
  src/software/test/test_software_installation_service.py
1b95c211bdc1411871cd6f1300a77ca59b3b2c50 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1415/diff/


Testing
-------


Thanks,

Michal Minar