Review Request 1647: Include profile (un)registration in the (un)register-PROVIDER make targets

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1647/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

This is an attempt to include profile (un)registration within the
(un)register-PROVIDER make target. This commit extends the cim_registration
macro by an extra argument of the profile file. However it is currently
limited to a single argument.


Diffs
-----

  cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa 
  src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01 
  src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69 
  src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f 
  src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69 
  src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde 
  src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2 
  src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11 
  src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098 
  src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9 
  src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/


Testing
-------


Thanks,

Tomáš Bžatek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1647/#review2547
-----------------------------------------------------------


Apart from Pegasus problem below, the patch is ok.


cmake/modules/OpenLMIMacros.cmake
<http://reviewboard-openlmi.rhcloud.com/r/1647/#comment1368>

    The profile (un-)registration works only in Pegasus, please add '-c
tog-pegasus'.


- Jan Safranek


On April 28, 2014, 1:14 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1647/
>  -----------------------------------------------------------
>  
>  (Updated April 28, 2014, 1:14 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  This is an attempt to include profile (un)registration within the
>  (un)register-PROVIDER make target. This commit extends the cim_registration
>  macro by an extra argument of the profile file. However it is currently
>  limited to a single argument.
>  
>  
>  Diffs
>  -----
>  
>    cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa 
>    src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01 
>    src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69 
>    src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f 
>    src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69 
>    src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde 
>    src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2 
>    src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11 
>    src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098 
>    src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9 
>    src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1647/#review2548
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Safranek


On April 28, 2014, 1:14 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1647/
>  -----------------------------------------------------------
>  
>  (Updated April 28, 2014, 1:14 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  This is an attempt to include profile (un)registration within the
>  (un)register-PROVIDER make target. This commit extends the cim_registration
>  macro by an extra argument of the profile file. However it is currently
>  limited to a single argument.
>  
>  
>  Diffs
>  -----
>  
>    cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa 
>    src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01 
>    src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69 
>    src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f 
>    src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69 
>    src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde 
>    src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2 
>    src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11 
>    src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098 
>    src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9 
>    src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1647/
-----------------------------------------------------------

(Updated May 5, 2014, 3:32 p.m.)


Review request for OpenLMI Developers.


Changes
-------

Posted new version of the patch:
 - extra argument changed to vargargs, no API break anymore
 - takes multiple files


Repository: openlmi-providers


Description (updated)
-------

    This is an attempt to include profile (un)registration within the
    (un)register-PROVIDER make target. This commit extends the cim_registration
    macro by an extra argument of the profile file or list of profile files.
    
    To preserve API of the CMake modules this extra argument is an variable arg
    in fact and does not need to be specified. Pass a list variable to specify
    multiple profile files.


Diffs (updated)
-----

  src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9 
  src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098 
  src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11 
  src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2 
  src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde 
  src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69 
  src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f 
  src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69 
  src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01 
  cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa 
  src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e 
  tools/devassistant/files/crt/c/openlmi/src/CMakeLists.txt.tpl
237f20e02a0c1dea9de9e74acf462e4b58029438 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/


Testing
-------


Thanks,

Tomáš Bžatek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1647/#review2630
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On May 5, 2014, 5:32 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1647/
>  -----------------------------------------------------------
>  
>  (Updated May 5, 2014, 5:32 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>      This is an attempt to include profile (un)registration within the
>      (un)register-PROVIDER make target. This commit extends the cim_registration
>      macro by an extra argument of the profile file or list of profile files.
>      
>      To preserve API of the CMake modules this extra argument is an variable arg
>      in fact and does not need to be specified. Pass a list variable to specify
>      multiple profile files.
>  
>  
>  Diffs
>  -----
>  
>    src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9 
>    src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098 
>    src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11 
>    src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2 
>    src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde 
>    src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69 
>    src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f 
>    src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69 
>    src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01 
>    cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa 
>    src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e 
>    tools/devassistant/files/crt/c/openlmi/src/CMakeLists.txt.tpl
> 237f20e02a0c1dea9de9e74acf462e4b58029438 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1647/#review2631
-----------------------------------------------------------

Ship it!


Ship It!

- Tomas Smetana


On May 5, 2014, 5:32 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1647/
>  -----------------------------------------------------------
>  
>  (Updated May 5, 2014, 5:32 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>      This is an attempt to include profile (un)registration within the
>      (un)register-PROVIDER make target. This commit extends the cim_registration
>      macro by an extra argument of the profile file or list of profile files.
>      
>      To preserve API of the CMake modules this extra argument is an variable arg
>      in fact and does not need to be specified. Pass a list variable to specify
>      multiple profile files.
>  
>  
>  Diffs
>  -----
>  
>    src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9 
>    src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098 
>    src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11 
>    src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2 
>    src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde 
>    src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69 
>    src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f 
>    src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69 
>    src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01 
>    cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa 
>    src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e 
>    tools/devassistant/files/crt/c/openlmi/src/CMakeLists.txt.tpl
> 237f20e02a0c1dea9de9e74acf462e4b58029438 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1647/
-----------------------------------------------------------

(Updated May 15, 2014, 2:21 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

    This is an attempt to include profile (un)registration within the
    (un)register-PROVIDER make target. This commit extends the cim_registration
    macro by an extra argument of the profile file or list of profile files.
    
    To preserve API of the CMake modules this extra argument is an variable arg
    in fact and does not need to be specified. Pass a list variable to specify
    multiple profile files.


Diffs
-----

  src/service/CMakeLists.txt 6d75d38247a8c06b8f6b5e5f4d3b1f8615c910d9 
  src/service-dbus/CMakeLists.txt 4ba32316993c78ec6ae41287fc97867e23fcf098 
  src/realmd/CMakeLists.txt dbf2e5463d9192d6dc1dbf767c7be1242e67eb11 
  src/power/CMakeLists.txt 44b2109ec5ce0c41c6d7091144bd58c0a86e84a2 
  src/logicalfile/CMakeLists.txt 3a09a4ad7a545f8a74f73175461943516e3f8fde 
  src/journald/CMakeLists.txt 1e6f19372172e5410f7b902ab5f61cac262fdf69 
  src/hardware/CMakeLists.txt 29b63d342039a2e19a1fcdfe626cfab2b3a3002f 
  src/fan/CMakeLists.txt 446e38b820ad53ae28b619df538c49f03a33bb69 
  src/account/CMakeLists.txt 83ca474a00a3a8a514bed4fc787360563ad56d01 
  cmake/modules/OpenLMIMacros.cmake d55f983d2589bb3bee1a14668275b2ed96142cfa 
  src/software-dbus/CMakeLists.txt 5202c33e302bca4b1a48f71bcdf884ff4e1ba01e 
  tools/devassistant/files/crt/c/openlmi/src/CMakeLists.txt.tpl
237f20e02a0c1dea9de9e74acf462e4b58029438 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1647/diff/


Testing
-------


Thanks,

Tomáš Bžatek