Re: Review Request 417: Account [1/1] Account: Correctly handle empty fields in shadow file

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/417/
-----------------------------------------------------------

(Updated May 30, 2013, 8:06 a.m.)


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: Correctly handle empty fields in shadow file

libuser returns -1 for empty fields. Handle the -1 on missing places.

Fixes Ticket #113: LMI_Account instance enumeration fails with "DateTime is out of
range"

Signed-off-by: Roman Rakus <rrakus(a)redhat.com&gt;


Diffs (updated)
-----

  src/account/LMI_AccountProvider.c c4a68f7c71d0f77821bdf95aec7ae60ffae0b455 
  src/account/macros.h 513d4723c29dcef20753130b037eb99db5a66a30 

Diff: http://reviewboard-openlmi.rhcloud.com/r/417/diff/


Testing
-------


Thanks,

Roman Rakus

Review Request 417: Account [1/1] Account: Correctly handle empty fields in shadow file

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/417/#review508
-----------------------------------------------------------

Ship it!


Ship It!

- Stephen Gallagher


On May 30, 2013, 8:06 a.m., Roman Rakus wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/417/
>  -----------------------------------------------------------
>  
>  (Updated May 30, 2013, 8:06 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Account: Correctly handle empty fields in shadow file
>  
>  libuser returns -1 for empty fields. Handle the -1 on missing places.
>  
>  Fixes Ticket #113: LMI_Account instance enumeration fails with "DateTime is out of
> range"
>  
>  Signed-off-by: Roman Rakus <rrakus(a)redhat.com&gt;
>  
>  
>  Diffs
>  -----
>  
>    src/account/LMI_AccountProvider.c c4a68f7c71d0f77821bdf95aec7ae60ffae0b455 
>    src/account/macros.h 513d4723c29dcef20753130b037eb99db5a66a30 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/417/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Roman Rakus
>  
>

Review Request 417: Account [1/1] Account: Correctly handle empty fields in shadow file

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/417/
-----------------------------------------------------------

(Updated May 31, 2013, 12:03 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Account: Correctly handle empty fields in shadow file

libuser returns -1 for empty fields. Handle the -1 on missing places.

Fixes Ticket #113: LMI_Account instance enumeration fails with "DateTime is out of
range"

Signed-off-by: Roman Rakus <rrakus(a)redhat.com&gt;


Diffs
-----

  src/account/LMI_AccountProvider.c c4a68f7c71d0f77821bdf95aec7ae60ffae0b455 
  src/account/macros.h 513d4723c29dcef20753130b037eb99db5a66a30 

Diff: http://reviewboard-openlmi.rhcloud.com/r/417/diff/


Testing
-------


Thanks,

Roman Rakus