----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Software-dbus: enhanced error reporting
Diffs -----
src/software-dbus/LMI_SoftwareIdentityProvider.c 73a8ae5d973e0b31d06b790949a60913f1efdad3 src/software-dbus/LMI_SoftwareIdentityResourceProvider.c ecf139177c5d8109884866e452673ef66caea048 src/software-dbus/sw-utils.h 5e61ccbf3a3924dcba81adafffa1b808d9e2803f src/software-dbus/sw-utils.c ca9722a1faed6fe8bb3b9bf805fa35fc39f84789
Diff: http://reviewboard-openlmi.rhcloud.com/r/1568/diff/
Testing -------
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/#review2392 -----------------------------------------------------------
Autoscan started for review(s) 1568[1]
- scanbot
On March 28, 2014, 2:02 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/
(Updated March 28, 2014, 2:02 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Software-dbus: enhanced error reporting
Diffs
src/software-dbus/LMI_SoftwareIdentityProvider.c 73a8ae5d973e0b31d06b790949a60913f1efdad3 src/software-dbus/LMI_SoftwareIdentityResourceProvider.c ecf139177c5d8109884866e452673ef66caea048 src/software-dbus/sw-utils.h 5e61ccbf3a3924dcba81adafffa1b808d9e2803f src/software-dbus/sw-utils.c ca9722a1faed6fe8bb3b9bf805fa35fc39f84789
Diff: http://reviewboard-openlmi.rhcloud.com/r/1568/diff/
Testing
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/#review2393 -----------------------------------------------------------
Autoscan finished OK
Scanned reviews: 1568
- scanbot
On March 28, 2014, 2:02 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/
(Updated March 28, 2014, 2:02 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Software-dbus: enhanced error reporting
Diffs
src/software-dbus/LMI_SoftwareIdentityProvider.c 73a8ae5d973e0b31d06b790949a60913f1efdad3 src/software-dbus/LMI_SoftwareIdentityResourceProvider.c ecf139177c5d8109884866e452673ef66caea048 src/software-dbus/sw-utils.h 5e61ccbf3a3924dcba81adafffa1b808d9e2803f src/software-dbus/sw-utils.c ca9722a1faed6fe8bb3b9bf805fa35fc39f84789
Diff: http://reviewboard-openlmi.rhcloud.com/r/1568/diff/
Testing
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/#review2394 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On March 28, 2014, 2:02 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/
(Updated March 28, 2014, 2:02 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Software-dbus: enhanced error reporting
Diffs
src/software-dbus/LMI_SoftwareIdentityProvider.c 73a8ae5d973e0b31d06b790949a60913f1efdad3 src/software-dbus/LMI_SoftwareIdentityResourceProvider.c ecf139177c5d8109884866e452673ef66caea048 src/software-dbus/sw-utils.h 5e61ccbf3a3924dcba81adafffa1b808d9e2803f src/software-dbus/sw-utils.c ca9722a1faed6fe8bb3b9bf805fa35fc39f84789
Diff: http://reviewboard-openlmi.rhcloud.com/r/1568/diff/
Testing
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/#review2395 -----------------------------------------------------------
You're leaking GError everywhere; be sure to free it either with g_error_free() or g_clear_error().
- Tomáš Bžatek
On March 28, 2014, 2:02 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/
(Updated March 28, 2014, 2:02 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Software-dbus: enhanced error reporting
Diffs
src/software-dbus/LMI_SoftwareIdentityProvider.c 73a8ae5d973e0b31d06b790949a60913f1efdad3 src/software-dbus/LMI_SoftwareIdentityResourceProvider.c ecf139177c5d8109884866e452673ef66caea048 src/software-dbus/sw-utils.h 5e61ccbf3a3924dcba81adafffa1b808d9e2803f src/software-dbus/sw-utils.c ca9722a1faed6fe8bb3b9bf805fa35fc39f84789
Diff: http://reviewboard-openlmi.rhcloud.com/r/1568/diff/
Testing
Thanks,
Peter Schiffer
On March 28, 2014, 4:29 p.m., Tomáš Bžatek wrote:
You're leaking GError everywhere; be sure to free it either with g_error_free() or g_clear_error().
Thanks, fixed.
- Peter
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/#review2395 -----------------------------------------------------------
On March 28, 2014, 4:56 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/
(Updated March 28, 2014, 4:56 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Software-dbus: enhanced error reporting
Diffs
src/software-dbus/LMI_SoftwareIdentityProvider.c 73a8ae5d973e0b31d06b790949a60913f1efdad3 src/software-dbus/LMI_SoftwareIdentityResourceProvider.c ecf139177c5d8109884866e452673ef66caea048 src/software-dbus/sw-utils.h 5e61ccbf3a3924dcba81adafffa1b808d9e2803f src/software-dbus/sw-utils.c ca9722a1faed6fe8bb3b9bf805fa35fc39f84789
Diff: http://reviewboard-openlmi.rhcloud.com/r/1568/diff/
Testing
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/ -----------------------------------------------------------
(Updated March 28, 2014, 4:56 p.m.)
Review request for OpenLMI Developers.
Changes -------
Free GError.
Repository: openlmi-providers
Description -------
Software-dbus: enhanced error reporting
Diffs (updated) -----
src/software-dbus/LMI_SoftwareIdentityProvider.c 73a8ae5d973e0b31d06b790949a60913f1efdad3 src/software-dbus/LMI_SoftwareIdentityResourceProvider.c ecf139177c5d8109884866e452673ef66caea048 src/software-dbus/sw-utils.h 5e61ccbf3a3924dcba81adafffa1b808d9e2803f src/software-dbus/sw-utils.c ca9722a1faed6fe8bb3b9bf805fa35fc39f84789
Diff: http://reviewboard-openlmi.rhcloud.com/r/1568/diff/
Testing -------
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1568/ -----------------------------------------------------------
(Updated March 28, 2014, 4:57 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Software-dbus: enhanced error reporting
Diffs -----
src/software-dbus/LMI_SoftwareIdentityProvider.c 73a8ae5d973e0b31d06b790949a60913f1efdad3 src/software-dbus/LMI_SoftwareIdentityResourceProvider.c ecf139177c5d8109884866e452673ef66caea048 src/software-dbus/sw-utils.h 5e61ccbf3a3924dcba81adafffa1b808d9e2803f src/software-dbus/sw-utils.c ca9722a1faed6fe8bb3b9bf805fa35fc39f84789
Diff: http://reviewboard-openlmi.rhcloud.com/r/1568/diff/
Testing -------
Thanks,
Peter Schiffer
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher