Review Request 558: Hardware: Update LMI_PCIDevice provider

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/558/
-----------------------------------------------------------

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description
-------

Hardware: Update LMI_PCIDevice provider

LMI_PCIDevice provider was updated to match the rest of the providers in the
Hardware, multiple information was added. As main and only source of information
is still libpci library, as udev doesn't provide all necessary information and
if used, it would have to be combined with libpci anyway.

Diffs
-----

mof/60_LMI_Hardware.mof 41e80b8d7d314a97205061e5c3c20077b7649cb4 
  src/hardware/LMI_Hardware.h 227ca51ac006878de22d455e402f404546c053b3 
  src/hardware/LMI_PCIDeviceProvider.c e879484a53bc29aa6109ad31a25a9616f03ca3e0

Diff: http://reviewboard-openlmi.rhcloud.com/r/558/diff/

Testing
-------

Thanks,

Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/558/#review680
-----------------------------------------------------------

Ship it!

src/hardware/LMI_PCIDeviceProvider.c
http://reviewboard-openlmi.rhcloud.com/r/558/#comment381

Use a constant.

src/hardware/LMI_PCIDeviceProvider.c
http://reviewboard-openlmi.rhcloud.com/r/558/#comment382

Use a constant.

Other than that, ship it!

- Jan Synacek

On July 16, 2013, 2:19 p.m., Peter Schiffer wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/558/
>
> (Updated July 16, 2013, 2:19 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Hardware: Update LMI_PCIDevice provider
>
> LMI_PCIDevice provider was updated to match the rest of the providers in the
> Hardware, multiple information was added. As main and only source of information
> is still libpci library, as udev doesn't provide all necessary information and
> if used, it would have to be combined with libpci anyway.
> Diffs
>
> mof/60_LMI_Hardware.mof 41e80b8d7d314a97205061e5c3c20077b7649cb4 
>   src/hardware/LMI_Hardware.h 227ca51ac006878de22d455e402f404546c053b3 
>   src/hardware/LMI_PCIDeviceProvider.c e879484a53bc29aa6109ad31a25a9616f03ca3e0
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/558/diff/
> Testing
>
> Thanks,
>
> Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/558/
-----------------------------------------------------------

(Updated July 18, 2013, 2:18 p.m.)

Status
------

This change has been marked as submitted.

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description
-------

Hardware: Update LMI_PCIDevice provider

LMI_PCIDevice provider was updated to match the rest of the providers in the
Hardware, multiple information was added. As main and only source of information
is still libpci library, as udev doesn't provide all necessary information and
if used, it would have to be combined with libpci anyway.

Diffs
-----

mof/60_LMI_Hardware.mof 41e80b8d7d314a97205061e5c3c20077b7649cb4 
  src/hardware/LMI_Hardware.h 227ca51ac006878de22d455e402f404546c053b3 
  src/hardware/LMI_PCIDeviceProvider.c e879484a53bc29aa6109ad31a25a9616f03ca3e0

Diff: http://reviewboard-openlmi.rhcloud.com/r/558/diff/

Testing
-------

Thanks,

Peter Schiffer