Review Request 431: Hardware: Added chassis ports provider

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/431/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Hardware: Added chassis ports provider

New providers:
 * LMI_PortPhysicalConnectorProvider
 * LMI_PortPhysicalConnectorContainerProvider


Diffs
-----

  mof/60_LMI_Hardware.mof 1a9ae4c36df1aac821cb0e075d1463968cdfe9b9 
  src/hardware/LMI_Hardware.h 2d09c00865a7a5a90f25e0223691bbd2e7527976 
  src/hardware/LMI_PortPhysicalConnectorContainerProvider.c PRE-CREATION 
  src/hardware/LMI_PortPhysicalConnectorProvider.c PRE-CREATION 
  src/hardware/dmidecode.h d3f8bd4b0fa3f4d4788ba1c31f503691b61bbd4b 
  src/hardware/dmidecode.c 4023cf3d82c30fc7bc562daaa7dc265408696cc9 

Diff: http://reviewboard-openlmi.rhcloud.com/r/431/diff/


Testing
-------


Thanks,

Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/431/#review515
-----------------------------------------------------------

Ship it!



src/hardware/LMI_PortPhysicalConnectorProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/431/#comment312>

    The second part of condition is useless.
    
    Why check if type is not "female" when you already know that type is
"male".


- Radek Novacek


On June 5, 2013, 5:52 p.m., Peter Schiffer wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/431/
>  -----------------------------------------------------------
>  
>  (Updated June 5, 2013, 5:52 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Hardware: Added chassis ports provider
>  
>  New providers:
>   * LMI_PortPhysicalConnectorProvider
>   * LMI_PortPhysicalConnectorContainerProvider
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Hardware.mof 1a9ae4c36df1aac821cb0e075d1463968cdfe9b9 
>    src/hardware/LMI_Hardware.h 2d09c00865a7a5a90f25e0223691bbd2e7527976 
>    src/hardware/LMI_PortPhysicalConnectorContainerProvider.c PRE-CREATION 
>    src/hardware/LMI_PortPhysicalConnectorProvider.c PRE-CREATION 
>    src/hardware/dmidecode.h d3f8bd4b0fa3f4d4788ba1c31f503691b61bbd4b 
>    src/hardware/dmidecode.c 4023cf3d82c30fc7bc562daaa7dc265408696cc9 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/431/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Peter Schiffer
>  
>

[Stephen Gallagher]

>  On June 6, 2013, 9:13 a.m., Radek Novacek wrote:
>  > src/hardware/LMI_PortPhysicalConnectorProvider.c, lines 104-105
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/431/diff/1/?file=2569#file2569li...
>  >
>  >     The second part of condition is useless.
>  >     
>  >     Why check if type is not "female" when you already know that type is
> "male". 
Ah, thanks. This is actually a bug. Gender is only a part of dmi_ports[i].type.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/431/#review515
-----------------------------------------------------------


On June 6, 2013, 1:41 p.m., Peter Schiffer wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/431/
>  -----------------------------------------------------------
>  
>  (Updated June 6, 2013, 1:41 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Hardware: Added chassis ports provider
>  
>  New providers:
>   * LMI_PortPhysicalConnectorProvider
>   * LMI_PortPhysicalConnectorContainerProvider
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Hardware.mof 1a9ae4c36df1aac821cb0e075d1463968cdfe9b9 
>    src/hardware/LMI_Hardware.h 2d09c00865a7a5a90f25e0223691bbd2e7527976 
>    src/hardware/LMI_PortPhysicalConnectorContainerProvider.c PRE-CREATION 
>    src/hardware/LMI_PortPhysicalConnectorProvider.c PRE-CREATION 
>    src/hardware/dmidecode.h d3f8bd4b0fa3f4d4788ba1c31f503691b61bbd4b 
>    src/hardware/dmidecode.c 4023cf3d82c30fc7bc562daaa7dc265408696cc9 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/431/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Peter Schiffer
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/431/
-----------------------------------------------------------

(Updated June 6, 2013, 1:41 p.m.)


Review request for OpenLMI Developers.


Changes
-------

Fixed incorrect condition.


Repository: openlmi-providers


Description
-------

Hardware: Added chassis ports provider

New providers:
 * LMI_PortPhysicalConnectorProvider
 * LMI_PortPhysicalConnectorContainerProvider


Diffs (updated)
-----

  mof/60_LMI_Hardware.mof 1a9ae4c36df1aac821cb0e075d1463968cdfe9b9 
  src/hardware/LMI_Hardware.h 2d09c00865a7a5a90f25e0223691bbd2e7527976 
  src/hardware/LMI_PortPhysicalConnectorContainerProvider.c PRE-CREATION 
  src/hardware/LMI_PortPhysicalConnectorProvider.c PRE-CREATION 
  src/hardware/dmidecode.h d3f8bd4b0fa3f4d4788ba1c31f503691b61bbd4b 
  src/hardware/dmidecode.c 4023cf3d82c30fc7bc562daaa7dc265408696cc9 

Diff: http://reviewboard-openlmi.rhcloud.com/r/431/diff/


Testing
-------


Thanks,

Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/431/
-----------------------------------------------------------

(Updated June 6, 2013, 1:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Hardware: Added chassis ports provider

New providers:
 * LMI_PortPhysicalConnectorProvider
 * LMI_PortPhysicalConnectorContainerProvider


Diffs
-----

  mof/60_LMI_Hardware.mof 1a9ae4c36df1aac821cb0e075d1463968cdfe9b9 
  src/hardware/LMI_Hardware.h 2d09c00865a7a5a90f25e0223691bbd2e7527976 
  src/hardware/LMI_PortPhysicalConnectorContainerProvider.c PRE-CREATION 
  src/hardware/LMI_PortPhysicalConnectorProvider.c PRE-CREATION 
  src/hardware/dmidecode.h d3f8bd4b0fa3f4d4788ba1c31f503691b61bbd4b 
  src/hardware/dmidecode.c 4023cf3d82c30fc7bc562daaa7dc265408696cc9 

Diff: http://reviewboard-openlmi.rhcloud.com/r/431/diff/


Testing
-------


Thanks,

Peter Schiffer

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/431/#review517
-----------------------------------------------------------

Ship it!


Ship It!

- Radek Novacek


On June 6, 2013, 1:46 p.m., Peter Schiffer wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/431/
>  -----------------------------------------------------------
>  
>  (Updated June 6, 2013, 1:46 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Hardware: Added chassis ports provider
>  
>  New providers:
>   * LMI_PortPhysicalConnectorProvider
>   * LMI_PortPhysicalConnectorContainerProvider
>  
>  
>  Diffs
>  -----
>  
>    mof/60_LMI_Hardware.mof 1a9ae4c36df1aac821cb0e075d1463968cdfe9b9 
>    src/hardware/LMI_Hardware.h 2d09c00865a7a5a90f25e0223691bbd2e7527976 
>    src/hardware/LMI_PortPhysicalConnectorContainerProvider.c PRE-CREATION 
>    src/hardware/LMI_PortPhysicalConnectorProvider.c PRE-CREATION 
>    src/hardware/dmidecode.h d3f8bd4b0fa3f4d4788ba1c31f503691b61bbd4b 
>    src/hardware/dmidecode.c 4023cf3d82c30fc7bc562daaa7dc265408696cc9 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/431/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Peter Schiffer
>  
>