Review Request 845: [1/1] Software: First upstream test for software provider from QA.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/845/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Software: First upstream test for software provider from QA.


Diffs
-----

  src/software/test/testSoftware.py PRE-CREATION 
  src/software/test/lmi-test.repo PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/845/diff/


Testing
-------


Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/845/#review1135
-----------------------------------------------------------



src/software/test/testSoftware.py
<http://reviewboard-openlmi.rhcloud.com/r/845/#comment670>

    Maybe we should use enum for magic numbers.



src/software/test/testSoftware.py
<http://reviewboard-openlmi.rhcloud.com/r/845/#comment665>

    We need function with less arguments.
    stderr=DEV_NULL is bolerplate.



src/software/test/testSoftware.py
<http://reviewboard-openlmi.rhcloud.com/r/845/#comment669>

    stderr=DEV_NULL is boilerplate.
    We need simpler function for calling processes.



src/software/test/testSoftware.py
<http://reviewboard-openlmi.rhcloud.com/r/845/#comment668>

    stderr=DEV_NULL is boilerplate.
    We need simpler function for calling processes.



src/software/test/testSoftware.py
<http://reviewboard-openlmi.rhcloud.com/r/845/#comment667>

    stderr=DEV_NULL is boilerplate.
    We need simpler function for calling processes.



src/software/test/testSoftware.py
<http://reviewboard-openlmi.rhcloud.com/r/845/#comment666>

    What about
    identities = cs.associators(Role="System", ...
    for identity in identities:
    
    For line is just too long.


- Robin Hack


On Sept. 10, 2013, 11:03 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/845/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 11:03 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Software: First upstream test for software provider from QA.
>  
>  
>  Diffs
>  -----
>  
>    src/software/test/testSoftware.py PRE-CREATION 
>    src/software/test/lmi-test.repo PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/845/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/845/#review1136
-----------------------------------------------------------



src/software/test/testSoftware.py
<http://reviewboard-openlmi.rhcloud.com/r/845/#comment671>

    What if output will have more than 2 lines which you want skip?
    Like more plugins in yum.


- Robin Hack


On Sept. 10, 2013, 11:03 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/845/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 11:03 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Software: First upstream test for software provider from QA.
>  
>  
>  Diffs
>  -----
>  
>    src/software/test/testSoftware.py PRE-CREATION 
>    src/software/test/lmi-test.repo PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/845/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/845/#review1138
-----------------------------------------------------------



src/software/test/testSoftware.py
<http://reviewboard-openlmi.rhcloud.com/r/845/#comment673>

    This is much faster:
    rpm -qa
    


- Michal Minar


On Sept. 10, 2013, 11:03 a.m., Robin Hack wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/845/
>  -----------------------------------------------------------
>  
>  (Updated Sept. 10, 2013, 11:03 a.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  Software: First upstream test for software provider from QA.
>  
>  
>  Diffs
>  -----
>  
>    src/software/test/testSoftware.py PRE-CREATION 
>    src/software/test/lmi-test.repo PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/845/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Robin Hack
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/845/
-----------------------------------------------------------

(Updated Oct. 16, 2013, 7:01 a.m.)


Status
------

This change has been discarded.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

Software: First upstream test for software provider from QA.


Diffs
-----

  src/software/test/testSoftware.py PRE-CREATION 
  src/software/test/lmi-test.repo PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/845/diff/


Testing
-------


Thanks,

Robin Hack