----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/441/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Account: Indication for creating instances
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs -----
mof/60_LMI_Account.mof d79db352f5d9b9891530a182f108720dc703e18a src/account/CMakeLists.txt 38ecd021a011c76a6f964d7b344a092787541b85 src/account/LMI_AccountInstanceCreationIndicationProvider.c PRE-CREATION src/account/macros.h 80a940089dfe79d8e6bd3cb3af93e84649050e6e
Diff: http://reviewboard-openlmi.rhcloud.com/r/441/diff/
Testing -------
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/441/#review526 -----------------------------------------------------------
src/account/LMI_AccountInstanceCreationIndicationProvider.c http://reviewboard-openlmi.rhcloud.com/r/441/#comment317
Please add some error message to simplify debugging. Also for the the other failures.
I won't mark it as issue, it could be done in subsequent commit.
src/account/LMI_AccountInstanceCreationIndicationProvider.c http://reviewboard-openlmi.rhcloud.com/r/441/#comment318
fd is closed here but not in other cases. Is this correct?
src/account/LMI_AccountInstanceCreationIndicationProvider.c http://reviewboard-openlmi.rhcloud.com/r/441/#comment319
Error checking is missing
- Radek Novacek
On June 10, 2013, 3:46 p.m., Roman Rakus wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/441/
(Updated June 10, 2013, 3:46 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Indication for creating instances
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs
mof/60_LMI_Account.mof d79db352f5d9b9891530a182f108720dc703e18a src/account/CMakeLists.txt 38ecd021a011c76a6f964d7b344a092787541b85 src/account/LMI_AccountInstanceCreationIndicationProvider.c PRE-CREATION src/account/macros.h 80a940089dfe79d8e6bd3cb3af93e84649050e6e
Diff: http://reviewboard-openlmi.rhcloud.com/r/441/diff/
Testing
Thanks,
Roman Rakus
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/441/ -----------------------------------------------------------
(Updated June 12, 2013, 12:29 p.m.)
Status ------
This change has been discarded.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Account: Indication for creating instances
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs -----
mof/60_LMI_Account.mof d79db352f5d9b9891530a182f108720dc703e18a src/account/CMakeLists.txt 38ecd021a011c76a6f964d7b344a092787541b85 src/account/LMI_AccountInstanceCreationIndicationProvider.c PRE-CREATION src/account/macros.h 80a940089dfe79d8e6bd3cb3af93e84649050e6e
Diff: http://reviewboard-openlmi.rhcloud.com/r/441/diff/
Testing -------
Thanks,
Roman Rakus
openlmi-reviews@lists.fedorahosted.org