Review Request 1648: devassistant: Add support for creating new scripts

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1648/
-----------------------------------------------------------

Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

This snippet first clones the upstream openlmi-scripts repo and uses
the make_new.py script to create new command. The generated structure
is independent from the openlmi-scripts repo and only depends on
openlmi-tools.


Diffs
-----

  tools/devassistant/assistants/crt/python/openlmi-scripts.yaml PRE-CREATION 
  tools/devassistant/assistants/prep/openlmi-scripts.yaml PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1648/diff/


Testing
-------


Thanks,

Tomáš Bžatek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1648/#review2545
-----------------------------------------------------------

Ship it!


Ship It!

- Jan Safranek


On April 28, 2014, 4:39 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1648/
>  -----------------------------------------------------------
>  
>  (Updated April 28, 2014, 4:39 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  This snippet first clones the upstream openlmi-scripts repo and uses
>  the make_new.py script to create new command. The generated structure
>  is independent from the openlmi-scripts repo and only depends on
>  openlmi-tools.
>  
>  
>  Diffs
>  -----
>  
>    tools/devassistant/assistants/crt/python/openlmi-scripts.yaml PRE-CREATION 
>    tools/devassistant/assistants/prep/openlmi-scripts.yaml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1648/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1648/#review2549
-----------------------------------------------------------



tools/devassistant/assistants/crt/python/openlmi-scripts.yaml
<http://reviewboard-openlmi.rhcloud.com/r/1648/#comment1369>

    Since openlmi-tools 0.9.1, lmi meta-command is not needed.
    
    openlmi-scripts 0.2.8 is just a package group pulling all the script packages as
dependencies.
    
    I would ditch openlmi-scripts dependency altogether.



tools/devassistant/assistants/crt/python/openlmi-scripts.yaml
<http://reviewboard-openlmi.rhcloud.com/r/1648/#comment1370>

    Change the url to
    http://pythonhosted.org/openlmi-tools/scripts/script-tutorial.html
    
    Original site is going to be deprecated.
    


- Michal Minar


On April 28, 2014, 2:39 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1648/
>  -----------------------------------------------------------
>  
>  (Updated April 28, 2014, 2:39 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  This snippet first clones the upstream openlmi-scripts repo and uses
>  the make_new.py script to create new command. The generated structure
>  is independent from the openlmi-scripts repo and only depends on
>  openlmi-tools.
>  
>  
>  Diffs
>  -----
>  
>    tools/devassistant/assistants/crt/python/openlmi-scripts.yaml PRE-CREATION 
>    tools/devassistant/assistants/prep/openlmi-scripts.yaml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1648/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

>  On April 29, 2014, 12:30 p.m., Michal Minar wrote:
>  > tools/devassistant/assistants/crt/python/openlmi-scripts.yaml, line 7
>  >
> <http://reviewboard-openlmi.rhcloud.com/r/1648/diff/1/?file=9128#file9128l...
>  >
>  >     Since openlmi-tools 0.9.1, lmi meta-command is not needed.
>  >     
>  >     openlmi-scripts 0.2.8 is just a package group pulling all the script packages as
> dependencies.
>  >     
>  >     I would ditch openlmi-scripts dependency altogether. 
Right, this was written before the change happened. Removed the openlmi-scripts
dependency. 

FYI, these are not only build requirements, rather a list of required runtime and
recommended packages for debugging, running and deployment.


- Tomáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1648/#review2549
-----------------------------------------------------------


On May 5, 2014, 3:54 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1648/
>  -----------------------------------------------------------
>  
>  (Updated May 5, 2014, 3:54 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  This snippet first clones the upstream openlmi-scripts repo and uses
>  the make_new.py script to create new command. The generated structure
>  is independent from the openlmi-scripts repo and only depends on
>  openlmi-tools.
>  
>  
>  Diffs
>  -----
>  
>    tools/devassistant/assistants/prep/openlmi-scripts.yaml PRE-CREATION 
>    tools/devassistant/assistants/crt/python/openlmi-scripts.yaml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1648/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1648/
-----------------------------------------------------------

(Updated May 5, 2014, 3:54 p.m.)


Review request for OpenLMI Developers.


Changes
-------

Updated patch with modified links.


Repository: openlmi-providers


Description
-------

This snippet first clones the upstream openlmi-scripts repo and uses
the make_new.py script to create new command. The generated structure
is independent from the openlmi-scripts repo and only depends on
openlmi-tools.


Diffs (updated)
-----

  tools/devassistant/assistants/prep/openlmi-scripts.yaml PRE-CREATION 
  tools/devassistant/assistants/crt/python/openlmi-scripts.yaml PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1648/diff/


Testing
-------


Thanks,

Tomáš Bžatek

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1648/#review2587
-----------------------------------------------------------

Ship it!


Ship It!

- Michal Minar


On May 5, 2014, 3:54 p.m., Tomáš Bžatek wrote:
>  
>  -----------------------------------------------------------
>  This is an automatically generated e-mail. To reply, visit:
>  http://reviewboard-openlmi.rhcloud.com/r/1648/
>  -----------------------------------------------------------
>  
>  (Updated May 5, 2014, 3:54 p.m.)
>  
>  
>  Review request for OpenLMI Developers.
>  
>  
>  Repository: openlmi-providers
>  
>  
>  Description
>  -------
>  
>  This snippet first clones the upstream openlmi-scripts repo and uses
>  the make_new.py script to create new command. The generated structure
>  is independent from the openlmi-scripts repo and only depends on
>  openlmi-tools.
>  
>  
>  Diffs
>  -----
>  
>    tools/devassistant/assistants/prep/openlmi-scripts.yaml PRE-CREATION 
>    tools/devassistant/assistants/crt/python/openlmi-scripts.yaml PRE-CREATION 
>  
>  Diff: http://reviewboard-openlmi.rhcloud.com/r/1648/diff/
>  
>  
>  Testing
>  -------
>  
>  
>  Thanks,
>  
>  Tomáš Bžatek
>  
>

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1648/
-----------------------------------------------------------

(Updated May 7, 2014, 12:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for OpenLMI Developers.


Repository: openlmi-providers


Description
-------

This snippet first clones the upstream openlmi-scripts repo and uses
the make_new.py script to create new command. The generated structure
is independent from the openlmi-scripts repo and only depends on
openlmi-tools.


Diffs
-----

  tools/devassistant/assistants/prep/openlmi-scripts.yaml PRE-CREATION 
  tools/devassistant/assistants/crt/python/openlmi-scripts.yaml PRE-CREATION 

Diff: http://reviewboard-openlmi.rhcloud.com/r/1648/diff/


Testing
-------


Thanks,

Tomáš Bžatek