Review Request 805: [1/1] Service tests: Upstream test for service profider from QA.

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/
-----------------------------------------------------------

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description
-------

Service tests: Upstream test for service profider from QA.

Diffs
-----

src/service-dbus/test/failing.service PRE-CREATION 
  src/service-dbus/test/testService.py PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/

Testing
-------

Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

src/service-dbus/test/testService.py
http://reviewboard-openlmi.rhcloud.com/r/805/#comment589

This is way too complicated only to get list of services (and also hard to read). I would go with simple loop like this:

sysd_services = []
    for line in subprocess.check_output(["/usr/bin/systemctl", "list-unit-files", "-t", "service", "--no-pager", "--no-legend"]).split("\n"):
        service_name = line.split(" ", 1)[0]
        if service_name and "@.service" not in service_name:
            sysd_services.append(service_name)

src/service-dbus/test/testService.py
http://reviewboard-openlmi.rhcloud.com/r/805/#comment590

sysd_state = ret == 0

src/service-dbus/test/testService.py
http://reviewboard-openlmi.rhcloud.com/r/805/#comment591

The test should make sure that this service got removed from the system, either in tearDown(Class) or use addCleanup.

- Radek Novacek

On Sept. 2, 2013, 1:16 p.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 1:16 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 11:58 a.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, line 114
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line114
> > sysd_state = ret == 0

It's more harder to read without parentheses.

- Robin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 11:16 a.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 11:16 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 11:58 a.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, line 431
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line431
> > The test should make sure that this service got removed from the system, either in tearDown(Class) or use addCleanup.

Fixed by:

def tearDown(self):
        os.unlink ("/etc/systemd/system/failing.service")
        subprocess.call ("systemctl daemon-reload".split())

- Robin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 11:16 a.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 11:16 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 1:58 p.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, line 114
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line114
> > sysd_state = ret == 0
>
> Robin Hack wrote:
>     It's more harder to read without parentheses.

I'm ok with parentheses but not with the ternary operator.

- Radek

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 1:16 p.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 1:16 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 11:58 a.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, line 114
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line114
> > sysd_state = ret == 0
>
> Robin Hack wrote:
>     It's more harder to read without parentheses.
>
> Radek Novacek wrote:
>     I'm ok with parentheses but not with the ternary operator.

Fixed with:
sysd_state = (ret == 0)
> On Sept. 2, 2013, 11:58 a.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, lines 100-102
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line100
> > This is way too complicated only to get list of services (and also hard to read). I would go with simple loop like this:
> >
> > sysd_services = []
> > for line in subprocess.check_output(["/usr/bin/systemctl", "list-unit-files", "-t", "service", "--no-pager", "--no-legend"]).split("\n"):
> >     service_name = line.split(" ", 1)[0]
> >     if service_name and "@.service" not in service_name:
> >         sysd_services.append(service_name)

It's not that hard to read when you know basics of functional programming. Maybe grep in subprocess.check_output can be replaced by better solution.

I don't like something like:
for line in some_very_long_function_name_with(lot, of, parameters, howg):

- Robin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 11:16 a.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 11:16 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 1:58 p.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, lines 100-102
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line100
> > This is way too complicated only to get list of services (and also hard to read). I would go with simple loop like this:
> >
> > sysd_services = []
> > for line in subprocess.check_output(["/usr/bin/systemctl", "list-unit-files", "-t", "service", "--no-pager", "--no-legend"]).split("\n"):
> >     service_name = line.split(" ", 1)[0]
> >     if service_name and "@.service" not in service_name:
> >         sysd_services.append(service_name)
>
> Robin Hack wrote:
>     It's not that hard to read when you know basics of functional programming. Maybe grep in subprocess.check_output can be replaced by better solution.
> I don't like something like:
> for line in some_very_long_function_name_with(lot, of, parameters, howg):

Then store the result of some_very_long_function_name_with function to temporary variable.

- Radek

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 1:16 p.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 1:16 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 11:58 a.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, lines 100-102
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line100
> > This is way too complicated only to get list of services (and also hard to read). I would go with simple loop like this:
> >
> > sysd_services = []
> > for line in subprocess.check_output(["/usr/bin/systemctl", "list-unit-files", "-t", "service", "--no-pager", "--no-legend"]).split("\n"):
> >     service_name = line.split(" ", 1)[0]
> >     if service_name and "@.service" not in service_name:
> >         sysd_services.append(service_name)
>
> Robin Hack wrote:
>     It's not that hard to read when you know basics of functional programming. Maybe grep in subprocess.check_output can be replaced by better solution.
> I don't like something like:
> for line in some_very_long_function_name_with(lot, of, parameters, howg):
>
> Radek Novacek wrote:
>     Then store the result of some_very_long_function_name_with function to temporary variable.

What about:
sysd_output = subprocess.check_output("systemctl list-unit-files -t service --no-pager --no-legend".split())
sysd_services_tmp = filter (lambda p: p and "@.service" not in p[0], map (lambda x: x.split(), sysd_output.split("\n")))

It's simpler. I removed the ugly grep and pipe.

- Robin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 11:16 a.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 11:16 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 1:58 p.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, lines 100-102
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line100
> > This is way too complicated only to get list of services (and also hard to read). I would go with simple loop like this:
> >
> > sysd_services = []
> > for line in subprocess.check_output(["/usr/bin/systemctl", "list-unit-files", "-t", "service", "--no-pager", "--no-legend"]).split("\n"):
> >     service_name = line.split(" ", 1)[0]
> >     if service_name and "@.service" not in service_name:
> >         sysd_services.append(service_name)
>
> Robin Hack wrote:
>     It's not that hard to read when you know basics of functional programming. Maybe grep in subprocess.check_output can be replaced by better solution.
> I don't like something like:
> for line in some_very_long_function_name_with(lot, of, parameters, howg):
>
> Radek Novacek wrote:
>     Then store the result of some_very_long_function_name_with function to temporary variable.
>
> Robin Hack wrote:
>     What about:
>     sysd_output = subprocess.check_output("systemctl list-unit-files -t service --no-pager --no-legend".split())
>     sysd_services_tmp = filter (lambda p: p and "@.service" not in p[0], map (lambda x: x.split(), sysd_output.split("\n")))
> It's simpler. I removed the ugly grep and pipe.

A little bit better :) Add comment what it does and it's good to go.

- Radek

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 1:16 p.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 1:16 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 1:58 p.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, lines 100-102
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line100
> > This is way too complicated only to get list of services (and also hard to read). I would go with simple loop like this:
> >
> > sysd_services = []
> > for line in subprocess.check_output(["/usr/bin/systemctl", "list-unit-files", "-t", "service", "--no-pager", "--no-legend"]).split("\n"):
> >     service_name = line.split(" ", 1)[0]
> >     if service_name and "@.service" not in service_name:
> >         sysd_services.append(service_name)
>
> Robin Hack wrote:
>     It's not that hard to read when you know basics of functional programming. Maybe grep in subprocess.check_output can be replaced by better solution.
> I don't like something like:
> for line in some_very_long_function_name_with(lot, of, parameters, howg):
>
> Radek Novacek wrote:
>     Then store the result of some_very_long_function_name_with function to temporary variable.
>
> Robin Hack wrote:
>     What about:
>     sysd_output = subprocess.check_output("systemctl list-unit-files -t service --no-pager --no-legend".split())
>     sysd_services_tmp = filter (lambda p: p and "@.service" not in p[0], map (lambda x: x.split(), sysd_output.split("\n")))
> It's simpler. I removed the ugly grep and pipe.
>
> Radek Novacek wrote:
>     A little bit better :) Add comment what it does and it's good to go.

Please, don't do this. This is impossible to read without staring at it for a while.

- Jan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 1:16 p.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 1:16 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 11:58 a.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, lines 100-102
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line100
> > This is way too complicated only to get list of services (and also hard to read). I would go with simple loop like this:
> >
> > sysd_services = []
> > for line in subprocess.check_output(["/usr/bin/systemctl", "list-unit-files", "-t", "service", "--no-pager", "--no-legend"]).split("\n"):
> >     service_name = line.split(" ", 1)[0]
> >     if service_name and "@.service" not in service_name:
> >         sysd_services.append(service_name)
>
> Robin Hack wrote:
>     It's not that hard to read when you know basics of functional programming. Maybe grep in subprocess.check_output can be replaced by better solution.
> I don't like something like:
> for line in some_very_long_function_name_with(lot, of, parameters, howg):
>
> Radek Novacek wrote:
>     Then store the result of some_very_long_function_name_with function to temporary variable.
>
> Robin Hack wrote:
>     What about:
>     sysd_output = subprocess.check_output("systemctl list-unit-files -t service --no-pager --no-legend".split())
>     sysd_services_tmp = filter (lambda p: p and "@.service" not in p[0], map (lambda x: x.split(), sysd_output.split("\n")))
> It's simpler. I removed the ugly grep and pipe.
>
> Radek Novacek wrote:
>     A little bit better :) Add comment what it does and it's good to go.
>
> Jan Synacek wrote:
>     Please, don't do this. This is impossible to read without staring at it for a while.

Final version:

#  Parse list of services. Filter blank lines and services with @.service string in name.
        sysd_services = []
        for line in sysd_output.split("\n"):
            service = line.split()
            if service and "@.service" not in service[0]:
                sysd_services.append(service)

- Robin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 11:16 a.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 11:16 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 1:58 p.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, lines 100-102
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line100
> > This is way too complicated only to get list of services (and also hard to read). I would go with simple loop like this:
> >
> > sysd_services = []
> > for line in subprocess.check_output(["/usr/bin/systemctl", "list-unit-files", "-t", "service", "--no-pager", "--no-legend"]).split("\n"):
> >     service_name = line.split(" ", 1)[0]
> >     if service_name and "@.service" not in service_name:
> >         sysd_services.append(service_name)
>
> Robin Hack wrote:
>     It's not that hard to read when you know basics of functional programming. Maybe grep in subprocess.check_output can be replaced by better solution.
> I don't like something like:
> for line in some_very_long_function_name_with(lot, of, parameters, howg):
>
> Radek Novacek wrote:
>     Then store the result of some_very_long_function_name_with function to temporary variable.
>
> Robin Hack wrote:
>     What about:
>     sysd_output = subprocess.check_output("systemctl list-unit-files -t service --no-pager --no-legend".split())
>     sysd_services_tmp = filter (lambda p: p and "@.service" not in p[0], map (lambda x: x.split(), sysd_output.split("\n")))
> It's simpler. I removed the ugly grep and pipe.
>
> Radek Novacek wrote:
>     A little bit better :) Add comment what it does and it's good to go.
>
> Jan Synacek wrote:
>     Please, don't do this. This is impossible to read without staring at it for a while.
>
> Robin Hack wrote:
>     Final version:
>         #  Parse list of services. Filter blank lines and services with @.service string in name.
>         sysd_services = []
>         for line in sysd_output.split("\n"):
>             service = line.split()
>             if service and "@.service" not in service[0]:
>                 sysd_services.append(service)

Nice, thanks.

- Radek

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 1:16 p.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 1:16 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

> On Sept. 2, 2013, 1:58 p.m., Radek Novacek wrote:
> > src/service-dbus/test/testService.py, lines 100-102
> > http://reviewboard-openlmi.rhcloud.com/r/805/diff/1/?file=4443#file4443line100
> > This is way too complicated only to get list of services (and also hard to read). I would go with simple loop like this:
> >
> > sysd_services = []
> > for line in subprocess.check_output(["/usr/bin/systemctl", "list-unit-files", "-t", "service", "--no-pager", "--no-legend"]).split("\n"):
> >     service_name = line.split(" ", 1)[0]
> >     if service_name and "@.service" not in service_name:
> >         sysd_services.append(service_name)
>
> Robin Hack wrote:
>     It's not that hard to read when you know basics of functional programming. Maybe grep in subprocess.check_output can be replaced by better solution.
> I don't like something like:
> for line in some_very_long_function_name_with(lot, of, parameters, howg):
>
> Radek Novacek wrote:
>     Then store the result of some_very_long_function_name_with function to temporary variable.
>
> Robin Hack wrote:
>     What about:
>     sysd_output = subprocess.check_output("systemctl list-unit-files -t service --no-pager --no-legend".split())
>     sysd_services_tmp = filter (lambda p: p and "@.service" not in p[0], map (lambda x: x.split(), sysd_output.split("\n")))
> It's simpler. I removed the ugly grep and pipe.
>
> Radek Novacek wrote:
>     A little bit better :) Add comment what it does and it's good to go.
>
> Jan Synacek wrote:
>     Please, don't do this. This is impossible to read without staring at it for a while.
>
> Robin Hack wrote:
>     Final version:
>         #  Parse list of services. Filter blank lines and services with @.service string in name.
>         sysd_services = []
>         for line in sysd_output.split("\n"):
>             service = line.split()
>             if service and "@.service" not in service[0]:
>                 sysd_services.append(service)
>
>
> Radek Novacek wrote:
>     Nice, thanks.

Yes, that's way better. I know, it's not that 'good looking' as using maps/filters, but it's much easier to read:) Thanks!

- Jan

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1060
-----------------------------------------------------------

On Sept. 2, 2013, 1:16 p.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 1:16 p.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1072
-----------------------------------------------------------

src/service-dbus/test/testService.py
http://reviewboard-openlmi.rhcloud.com/r/805/#comment596

This asserts only that the sysd_services is a subset of lmi_services. IMHO the opposite case should be checked also:
    self.assertEqual(set(sysd_services.keys()), set(lmi_services.keys()))

- Michal Minar

On Sept. 2, 2013, 11:16 a.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 2, 2013, 11:16 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/
-----------------------------------------------------------

(Updated Sept. 4, 2013, 7:02 a.m.)

Review request for OpenLMI Developers.

Changes
-------

I fixed what was needed.

Repository: openlmi-providers

Description
-------

Service tests: Upstream test for service profider from QA.

Diffs (updated)
-----

src/service-dbus/test/failing.service PRE-CREATION 
  src/service-dbus/test/testService.py PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/

Testing
-------

Thanks,

Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1089
-----------------------------------------------------------

Ship it!

Ship It!

- Radek Novacek

On Sept. 4, 2013, 9:02 a.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 4, 2013, 9:02 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/#review1090
-----------------------------------------------------------

Ship it!

Ship It!

- Robin Hack

On Sept. 4, 2013, 7:02 a.m., Robin Hack wrote:
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/805/
>
> (Updated Sept. 4, 2013, 7:02 a.m.)
>
> Review request for OpenLMI Developers.
>
> Repository: openlmi-providers
> Description
>
> Service tests: Upstream test for service profider from QA.
> Diffs
>
> src/service-dbus/test/failing.service PRE-CREATION 
>   src/service-dbus/test/testService.py PRE-CREATION
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/
> Testing
>
> Thanks,
>
> Robin Hack

[Stephen Gallagher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/805/
-----------------------------------------------------------

(Updated Sept. 4, 2013, 8 a.m.)

Status
------

This change has been marked as submitted.

Review request for OpenLMI Developers.

Repository: openlmi-providers

Description
-------

Service tests: Upstream test for service profider from QA.

Diffs
-----

src/service-dbus/test/failing.service PRE-CREATION 
  src/service-dbus/test/testService.py PRE-CREATION

Diff: http://reviewboard-openlmi.rhcloud.com/r/805/diff/

Testing
-------

Thanks,

Robin Hack