----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/848/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
This patch unifies the means of passing arguments to method call and instance filtering.
Example:
instance.MethodCall({"Param1" : val1, "Param2" : val2, ...})
compared to:
instance.MethodCall(Param1=val1, Param2=val2, ...)
NOTE: The previous way, how to pass parameters to the method call still works.
Diffs -----
cli/lmi/shell/LMIMethod.py 8168ca406df98ba4da49ff31ba7b4188195593b7
Diff: http://reviewboard-openlmi.rhcloud.com/r/848/diff/
Testing -------
Thanks,
Peter Hatina
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/848/#review1151 -----------------------------------------------------------
cli/lmi/shell/LMIMethod.py http://reviewboard-openlmi.rhcloud.com/r/848/#comment681
Is it necessary to mark it as *deprecated*? I still prefer this way more than passing a dictionary.
- Michal Minar
On Sept. 10, 2013, 3:35 p.m., Peter Hatina wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/848/
(Updated Sept. 10, 2013, 3:35 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
This patch unifies the means of passing arguments to method call and instance filtering.
Example:
instance.MethodCall({"Param1" : val1, "Param2" : val2, ...})
compared to:
instance.MethodCall(Param1=val1, Param2=val2, ...)
NOTE: The previous way, how to pass parameters to the method call still works.
Diffs
cli/lmi/shell/LMIMethod.py 8168ca406df98ba4da49ff31ba7b4188195593b7
Diff: http://reviewboard-openlmi.rhcloud.com/r/848/diff/
Testing
Thanks,
Peter Hatina
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/848/#review1152 -----------------------------------------------------------
Ship it!
Ship It!
- Michal Minar
On Sept. 10, 2013, 3:35 p.m., Peter Hatina wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/848/
(Updated Sept. 10, 2013, 3:35 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
This patch unifies the means of passing arguments to method call and instance filtering.
Example:
instance.MethodCall({"Param1" : val1, "Param2" : val2, ...})
compared to:
instance.MethodCall(Param1=val1, Param2=val2, ...)
NOTE: The previous way, how to pass parameters to the method call still works.
Diffs
cli/lmi/shell/LMIMethod.py 8168ca406df98ba4da49ff31ba7b4188195593b7
Diff: http://reviewboard-openlmi.rhcloud.com/r/848/diff/
Testing
Thanks,
Peter Hatina
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/848/ -----------------------------------------------------------
(Updated Sept. 19, 2013, 1:17 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description -------
This patch unifies the means of passing arguments to method call and instance filtering.
Example:
instance.MethodCall({"Param1" : val1, "Param2" : val2, ...})
compared to:
instance.MethodCall(Param1=val1, Param2=val2, ...)
NOTE: The previous way, how to pass parameters to the method call still works.
Diffs -----
cli/lmi/shell/LMIMethod.py 8168ca406df98ba4da49ff31ba7b4188195593b7
Diff: http://reviewboard-openlmi.rhcloud.com/r/848/diff/
Testing -------
Thanks,
Peter Hatina
openlmi-reviews@lists.fedorahosted.org
-
Stephen Gallagher